* Full S/MIME support based on GnuPG 2. http://www.mew.org/feature/smime.html.en * Automatic resizing for large JPEG/PNG images. * Hyper Estraier support. Reproducible: Always
Created attachment 118707 [details] mew-5.2.ebuild
Hi, thank you for submitting the ebuild. Some (very minor) comments: - virtual/emacs is not needed in RDEPEND since it is already in the dependencies of elisp.eclass. - It may be cleaner to introduce a variable instead of substituting ${P/_/} in several places. (Maybe use versionator.eclass, too?) - Variables should be in canonical order, i.e. IUSE should be after KEYWORDS.
Hm, there is the following patch in your src_unpack: sed -i -e "s/CHECK = xemacs/CHECK = emacs/" Makefile.in || die "sed failed" I believe $(CHECK) is only used in "make check" which is not called by the ebuild. So this patch is not needed? Or have I overlooked something?
> I believe $(CHECK) is only used in "make check" which is not called by the > ebuild. So this patch is not needed? Or have I overlooked something? Sorry, of course it is needed with FEATURES=test ...
(In reply to comment #4) > > I believe $(CHECK) is only used in "make check" which is not called by the > > ebuild. So this patch is not needed? Or have I overlooked something? > > Sorry, of course it is needed with FEATURES=test ... > (In reply to comment #3) > Hm, there is the following patch in your src_unpack: > sed -i -e "s/CHECK = xemacs/CHECK = emacs/" Makefile.in || die "sed failed" > > I believe $(CHECK) is only used in "make check" which is not called by the > ebuild. So this patch is not needed? Or have I overlooked something? > using ebuild mew-5.2.ebuild test, this launch make check. i'm not sure if this is the right way.
Could you please report this to upstream, too? They should either use CHECK=@emacsbin@ in Makefile.in, or add another option (like --with-check) to configure.
(In reply to comment #6) > Could you please report this to upstream, too? They should either use > CHECK=@emacsbin@ in Makefile.in, or add another option (like --with-check) to > configure. > done, sended to the ML
(In reply to comment #7) > done, sended to the ML For reference, here is upstream's answer: From: Kazu Yamamoto 山本和彦 <kazu <at> iij.ad.jp> Subject: [mew-int 2290] Re: changes request for Makefile.in on mew-5.2 Newsgroups: gmane.mail.mew.general Date: 2007-05-10 14:48:47 GMT [...] I could not see what is the problem actually. "make check" is used only by me (the main programmer of Mew). This is used to detect unused local variables. Mew does not support XEmacs anymore. But since Emacs does not have this functionality, I'm still using XEmacs to detect unused variables. So, CHECK must be 'xemacs'. And people are not supposed to use 'make check'. This means that we should just use RESTRICT="test" here.
Version bumped (copying mew-5.1.ebuild). Thanks for reporting.
