Bugzilla Bug 177338

Modified spamass-milter ebuild to have a dependency to libmilter instead having
a dependency to Sendmail. This allows me to run spamass-milter with Postfix
>=2.3.0

Reproducible: Always

Created an attachment (id=118348) [edit]
mail-filter/spamass-milter/spamass-milter-0.3.1-r2.ebuild

Created an attachment (id=118350) [edit]
mail-filter/spamass-milter/files/README.gentoo

Modified readme to include instructions on how to integrate spamass-milter into
Postfix >= 2.3.0

Created an attachment (id=118352) [edit]
mail-filter/spamass-milter/files/spamass-milter.conf3

/etc/conf.d/spamass-milter file

Created an attachment (id=118354) [edit]
mail-filter/spamass-milter/files/spamass-milter.rc3

/etc/init.d/spamass-milter file

This seems to be a good idea and it is working for me.

(In reply to comment #5)
> This seems to be a good idea and it is working for me.
> 
With Postfix or with Sendmail?

with postfix-2.3.8 and libmilter-8.13.7

(In reply to comment #7)
> with postfix-2.3.8 and libmilter-8.13.7
> 

Cool :)

I am working here with Postfix 2.4.1 and it works without problems :)

And i have to say, i really love this. It's by far the cleanest way i ever
included spamassassin in a mta.

Cut the talk, there's no need to sell the idea when i'm fine with it :-)
I'm checking with net-mail devs (since i just maintain spamass-milter) on the
best approach for this, for instance if postfix can provide a libmilter
replacement to make it let's say "cleaner" or more native (i'm a sendmail user
btw).
Otherwise this approach is fine.

(In reply to comment #10)
> I'm checking with net-mail devs (since i just maintain spamass-milter) on the
> best approach for this, for instance if postfix can provide a libmilter
> replacement to make it let's say "cleaner" or more native (i'm a sendmail user
> btw).

The best approach is to use libmilter. It makes no sense for postfix to provide
own library for same protocol. Milter is protocol, not library API. Packages
like spamass-milter, dk-milter, sendmail, etc just use libmilter to be able to
use/provide milter protocol functionality. Postfix internally implements their
own milter protocol support to avoid external dependencies.

(In reply to comment #11)
> (In reply to comment #10)
> > I'm checking with net-mail devs (since i just maintain spamass-milter) on the
> > best approach for this, for instance if postfix can provide a libmilter
> > replacement to make it let's say "cleaner" or more native (i'm a sendmail user
> > btw).
> 
> The best approach is to use libmilter. It makes no sense for postfix to provide
> own library for same protocol. Milter is protocol, not library API. Packages
> like spamass-milter, dk-milter, sendmail, etc just use libmilter to be able to
> use/provide milter protocol functionality. Postfix internally implements their
> own milter protocol support to avoid external dependencies.
> 
Postfix uses libmilter. Read here for more info:
http://www.postfix.org/MILTER_README.html

And Sendmail is using libmilter as well since quite some time. So switching
spamass-milter to use libmilter is the save approach for both packages.

(In reply to comment #12)

> Postfix uses libmilter. Read here for more info:
> http://www.postfix.org/MILTER_README.html

No, postfix itself doesn't use libmilter, but milter-based filters like
dk-milter, spamass-milter, etc. use libmilter. The README just tells how to
install milters based on libmilter library.

> And Sendmail is using libmilter as well since quite some time. So switching
> spamass-milter to use libmilter is the save approach for both packages.

My understanding is that mail-mta/sendmail package contains libmilter, and
there is a mail-filter/libmilter for those who don't want sendmail. So the
solution is one of:

1) make spamass-milter (and other milters) depend on || (mail-mta/sendmail
mail-filter/libmilter)
 - this approach is already used in amavisd-new and mimedefang packages

2) separate libmilter out of sendmail, make sendmail depend on libmilter with
USE flag "milter", make all milters depend on libmilter directly
 - more elegant and modularized, but requires heavier changes

First approach is trivial change in DEPENDS for spamass-milter.

The problem with libmilter (net-mail devs can correct me if i'm wrong) is that
IMHO it won't go stable soon since the sendmail and libmilter dev is MIA, so
it's lagging behind.
I'm all for a solution but i'm not a member of the net-mail herd, i just
maintain this and i'd want this to go stable when possible.

(In reply to comment #13)
> (In reply to comment #12)
> 
> > Postfix uses libmilter. Read here for more info:
> > http://www.postfix.org/MILTER_README.html
> 
> No, postfix itself doesn't use libmilter, but milter-based filters like
> dk-milter, spamass-milter, etc. use libmilter. The README just tells how to
> install milters based on libmilter library.
> 
Right. Postfix does not need libmilter.


> > And Sendmail is using libmilter as well since quite some time. So switching
> > spamass-milter to use libmilter is the save approach for both packages.
> 
> My understanding is that mail-mta/sendmail package contains libmilter, and
> there is a mail-filter/libmilter for those who don't want sendmail. So the
> solution is one of:
> 
> 1) make spamass-milter (and other milters) depend on || (mail-mta/sendmail
> mail-filter/libmilter)
>  - this approach is already used in amavisd-new and mimedefang packages
> 
> 2) separate libmilter out of sendmail, make sendmail depend on libmilter with
> USE flag "milter", make all milters depend on libmilter directly
>  - more elegant and modularized, but requires heavier changes
> 
I like that one much more.


> First approach is trivial change in DEPENDS for spamass-milter.
> 

(In reply to comment #14)
> The problem with libmilter (net-mail devs can correct me if i'm wrong) is that
> IMHO it won't go stable soon since the sendmail and libmilter dev is MIA, so
> it's lagging behind.
>
What is MIA?


> I'm all for a solution but i'm not a member of the net-mail herd, i just
> maintain this and i'd want this to go stable when possible.
> 
I think for the moment you could implement option 1 from comment #13 and later
maybe switch to option 2. What do you think?

Created an attachment (id=121156) [edit]
mail-filter/spamass-milter/files/spamass-milter.conf3

Corrections regarding the "-m" flag.

Created an attachment (id=121158) [edit]
mail-filter/spamass-milter/files/README.gentoo

Corrections for Postfix >= 2.4.0

libmilter is stable, why not add it as dependency for libmilter? I remember it
was some time ago. I do not want to use sendmail, Postfix works OK for me on
Gentoo and Debian systems. I use spamass-milter with actively used Postfix on
Debian and all works fine, why it should not work fine on Gentoo so that you
can not fix this for almost an year?

(In reply to comment #19)
> I remember it was some time ago.

Sorry, this was for clamav. And I don't see reasons for spamass to not work if
clamav works.

(In reply to comment #20)
> Sorry, this was for clamav. And I don't see reasons for spamass to not work if
> clamav works.

The Gentoo developer that this bug was assigned to retired some time ago.

http://www.gentoo.org/proj/en/devrel/roll-call/userinfo.xml?statusFilter=Retired

I added spamass-milter-0.3.1-r2 to CVS which includes these fixes. Thanks guys!