Bugzilla Bug 176893

In kmplayer, when using  the "mplayer" engine, nothing will play.  The sound 
file will load, but not play, and then the status bar displays "Mplayer not
running"  as if the sound clip had finished.

A little hacking and web searching revealed that:

As of mplayer-1.0_rc2, the deprecated -vop option to mplayer has been removed
(it has been replaced by the -vf option).  This breaks applications, such as
kmplayer, that have the -vop flag hard-coded into the source.

I will attach a patch and a new ebuild below.  I've tested it on an AMD64
machine, but no longer have an x86 box to test stuff on.

Reproducible: Always

Steps to Reproduce:
1.  Install the latest version of mplayer from the portage tree.
2.  Install kmplayer.
3.  Launch kmplayer and open a sound file.
4.  Click "play"

Actual Results:  
Nothing plays, status bar gives "Mplayer not running".

Expected Results:  
Played the sound file.

Created an attachment (id=118020) [details]
Patch to replace 'vop' flag with 'vf' flag in kmplayer source.

This worked for me and ought to work on other platforms.  Could have done the
same thing with sed in the ebuild, I guess (since that's how I patched it).  If
that's preferable to a patch file here are the commands I used:

sed -i -e 's/vop/vf/g' ${S}/src/*.cpp
sed -i -e 's/vop/vf/g' ${S}/src/*.h

Created an attachment (id=118022) [details]
Ebuild that patches the vop problem.

Created an attachment (id=118023) [details]
My emerge info

Oops.  Forgot to put my emerge --info in the bug.  Here it is, in case anyone
needs to compare notes....

Tried to submit upstream, but the only e-mail address I could find was for the
web master of the kde site that hosts the kmplayer home page.  Hope that's the
right place to send things....

Okay.  Discovered that kmplayer is on KDE's bugzilla.  Submitted upstream. 
From reading the bug there, it looks like they may have already fixed this in
the latest SVN.  I couldn't tell for sure...

Reopened KDE bug 133214 since closed bugs may not get enough attention. Robert,
could you attach the patch on KDE Bugzilla as well please?

Okay.  Patch submitted upstream.  Looks like Koos is on top of it.

Thanks for the patch Robert. Likely not the only application having this
compatibility problem...


Arch teams, please stabilize kmplayer-0.9.4a-r1 asap.

x86 stable

Compiles on amd64 no errors and no collision. 
I can still watch all my video's so I'd say amd64 is good to mark it stable.

Portage 2.1.2.2 (default-linux/amd64/2006.1/no-multilib, gcc-4.1.1,
glibc-2.5-r2, 2.6.20-gentoo-r3 x86_64)
=================================================================
System uname: 2.6.20-gentoo-r3 x86_64 AMD Turion(tm) 64 Mobile Technology MT-28
Gentoo Base System release 1.12.9
Timestamp of tree: Sat, 12 May 2007 07:50:01 +0000
distcc 2.18.3 x86_64-pc-linux-gnu (protocols 1 and 2) (default port 3632)
[enabled]
dev-java/java-config: 1.3.7, 2.0.31-r5
dev-lang/python:     2.4.3-r4
dev-python/pycrypto: 2.0.1-r5
sys-apps/sandbox:    1.2.17
sys-devel/autoconf:  2.13, 2.61
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2, 1.10
sys-devel/binutils:  2.16.1-r3
sys-devel/gcc-config: 1.3.16
sys-devel/libtool:   1.5.22
virtual/os-headers:  2.6.17-r2
ACCEPT_KEYWORDS="amd64"
AUTOCLEAN="yes"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=athlon64 -msse3 -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/3.5/env /usr/kde/3.5/share/config
/usr/kde/3.5/shutdown /usr/share/X11/xkb /usr/share/config"
CONFIG_PROTECT_MASK="/etc/env.d /etc/env.d/java/ /etc/gconf
/etc/java-config/vms/ /etc/revdep-rebuild /etc/terminfo /etc/texmf/web2c"
CXXFLAGS="-march=athlon64 -msse3 -O2 -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="collision-protect distcc distlocks metadata-transfer multilib-strict
sandbox sfperms strict test"
GENTOO_MIRRORS="ftp://gentoo.tiscali.nl/pub/mirror/gentoo/"
LINGUAS="en nl"
MAKEOPTS="-j4"
PKGDIR="/usr/portage/packages"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress
--force --whole-file --delete --delete-after --stats --timeout=180
--exclude=/distfiles --exclude=/local --exclude=/packages
--filter=H_**/files/digest-*"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/portage-overlay"
SYNC="rsync://rsync.nl.gentoo.org/gentoo-portage"
USE="X alsa amd64 apache2 bitmap-fonts bzip2 cli cracklib crypt cvs dvd dvdr
exif flac gdbm gif gstreamer highlight history iconv imagemagick ipod isdnlog
jpeg jpeg2k kde latex libg++ md5sum midi mp3 mplayer music ncurses nls nomotif
nptl nptlonly ogg opengl oss pcre pdf perl png ppds pppd python qt readline
reflection samba session spl ssl tcpd test tetex truetype-fonts type1-fonts
unicode vorbis xine xml xml2 xorg zlib" ALSA_CARDS="intel8x0"
ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file
hooks iec958 ioplug ladspa lfloat linear meter mulaw multi null plug rate route
share shm softvol" ELIBC="glibc" INPUT_DEVICES="keyboard mouse synaptics"
KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001
mtxorb ncurses text" LINGUAS="en nl" USERLAND="GNU" VIDEO_CARDS="sis"
Unset:  CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LANG, LC_ALL, LDFLAGS,
PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS

amd64 stable

ppc64 stable

stable on ppc. closing since we're last