Bugzilla Bug 176757

Due to changes in 2.6.21 the gnome battery applet shows you on AC at all times.
I found a report and link to a fix on the mactel-linux users ML.
http://sourceforge.net/mailarchive/forum.php?thread_name=463393D5.5000304%40mailsnare.net&forum_name=mactel-linux-users
patch to follow...

Created an attachment (id=117920) [details]
gnome-applets-2.16.2-acpi.patch

I fail to see the differences between the 2 codes, except that the second one
will not return FALSE if it can't read /proc/acpi/info which looks like a big
no-no to me.

Second idea : did you disable CONFIG_ACPI_PROCFS by any chance ? It's a new
option for 2.6.21 and it specifically moves /proc/acpi/info to
/sys/module/acpi/parameters/acpica_version

All in all, I don't feel that confident about that patch. But it's just me :)
I'll look more into this after coffee.

Agreed: patch looks odd and fix should be not disabling the deprecated stuff

I'm running kernel 2.6.21. And the gnome battery applet works since i enabled
CONFIG_ACPI_PROCFS again.

Well, you guys are better able to spot a dodgy patch than me. I'm just
reporting my findings wrt getting it to work.
For more info, you can see the gnome bug:

http://bugzilla.gnome.org/show_bug.cgi?id=427562

Thanks,
je_fro

according to drac XFCE battery monitor had a similar problem and they have a
patch for it in xfce-extra/xfce4-battery/files/xfce4-battery-0.5.0-2.6.21.patch
which might help doing a similar patch of our own

Created an attachment (id=122246) [details]
gnome-applets-acpi-depreciated-procfs.patch

Attached is successfully tested patch to update for reading the kernel ACPI
version in the new acpica_version sysfs entry.

However I would note there is also a second issue which might confuse people.
The gnome-power-manager creates a battery a notification icon (not an applet)
and folk might have previously disabled the original battery applet.

Unfortunately this is also no longer being created as hal is also not up to
date with Linux acpi procfs depreciation either. There was a change in hal
0.5.9 to get the kernel ACPI version from /sys/firmware/acpi/info but where
they got this bogus entry from who knows...

Will copy this to the Gnome bugzilla.

Created an attachment (id=123350) [details]
upstream patch

This is the patch I just committed upstream. I tested it with
gnome-applets-2.18.0 replacing the patch in -r1. It works nicely. Can I commit
it?

We also need to get this fixed in the stable tree before we can stable 2.6.21.
This same patch also applies against gnome-applets-2.16.2. Can someone please
compile test it?

committed both 2.16 and 2.18 versions. I'll see about marking the new 2.16
stable within the next couple of days...