Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 176201 - Stabilize dev-python/pylint-0.13.1
Summary: Stabilize dev-python/pylint-0.13.1
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Python Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-04-27 05:17 UTC by Rob Cakebread (RETIRED)
Modified: 2007-05-20 08:46 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
failed test log (build.log,43.65 KB, text/plain)
2007-05-16 02:51 UTC, Steve Dibb (RETIRED)
Details
build.log for pylint (build.log,244.03 KB, text/plain)
2007-05-16 10:55 UTC, Raúl Porcel (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Cakebread (RETIRED) gentoo-dev 2007-04-27 05:17:11 UTC
Arch testers, please mark dev-python/pylint-0.12.2 stable.

The only open bug for pylint is for a very old version which has a nasty file collision which is the only version marked stable and will be removed after x86 is marked stable.

There are 625 unit tests but 5 fail for me due to needing dependencies on testing packages not in portage and needing a working X server etc.
Comment 1 Tiziano Müller (RETIRED) gentoo-dev 2007-04-27 05:23:34 UTC
Then they should be patched out.
Comment 2 Raúl Porcel (RETIRED) gentoo-dev 2007-04-27 11:38:34 UTC
Err...pylint-gui needs tk...
Comment 3 Andrej Kacian (RETIRED) gentoo-dev 2007-04-29 18:42:57 UTC
(In reply to comment #1)
> Then they should be patched out.
> 

I'd say that would block the stabilization for x86, unless the same tests fail on currently stable version as well. Do they?
Comment 4 Steve Dibb (RETIRED) gentoo-dev 2007-05-12 09:45:13 UTC
tests failed on every version of logilab-common that I tried (one of the deps for amd64)

--------------------------------------------------------------------------------
Executing unittest_ureports_text
********************************************************************************
Ran 234 test cases in 0.46s (0.41s CPU) , 4 failed , 14 skipped
17 tests OK.
2 tests failed: unittest_fileutils, unittest_modutils

!!! ERROR: dev-python/logilab-common-0.21.2 failed.
Call stack:
  ebuild.sh, line 1614:   Called dyn_test
  ebuild.sh, line 1026:   Called qa_call 'src_test'
  environment, line 3411:   Called src_test
  logilab-common-0.21.2.ebuild, line 47:   Called die

!!! tests failed
!!! If you need support, post the topmost build error, and the call stack if relevant.
!!! A complete build log is located at '/var/tmp/portage/dev-python/logilab-common-0.21.2/temp/build.log'.

# emerge --info
Portage 2.1.2.2 (default-linux/amd64/2006.1, gcc-4.1.1, glibc-2.4-r4, 2.6.20-gentoo-r4 x86_64)
=================================================================
System uname: 2.6.20-gentoo-r4 x86_64 AMD Athlon(tm) 64 X2 Dual Core Processor 3800+
Gentoo Base System release 1.12.9
Timestamp of tree: Sun, 14 Jan 2007 17:00:01 +0000
ccache version 2.4 [disabled]
dev-java/java-config: 1.3.7, 2.0.31
dev-lang/python:     2.4.3-r4
dev-python/pycrypto: 2.0.1-r5
dev-util/ccache:     2.4-r6
sys-apps/sandbox:    1.2.17
sys-devel/autoconf:  2.13, 2.61
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2, 1.10
sys-devel/binutils:  2.16.1-r3
sys-devel/gcc-config: 1.3.15-r1
sys-devel/libtool:   1.5.22
virtual/os-headers:  2.6.17-r2
ACCEPT_KEYWORDS="amd64"
AUTOCLEAN="yes"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe -march=athlon64"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/3.5/env /usr/kde/3.5/share/config /usr/kde/3.5/shutdown /usr/share/X11/xkb /usr/share/config /usr/spool/PBS"
CONFIG_PROTECT_MASK="/etc/env.d /etc/env.d/java/ /etc/gconf /etc/java-config/vms/ /etc/php/apache1-php5/ext-active/ /etc/php/apache2-php5/ext-active/ /etc/php/cgi-php5/ext-active/ /etc/php/cli-php5/ext-active/ /etc/revdep-rebuild /etc/terminfo /etc/texmf/web2c"
CXXFLAGS="-O2 -pipe -march=athlon64"
DISTDIR="/var/distfiles"
EMERGE_DEFAULT_OPTS="--alphabetical"
FEATURES="collision-protect distlocks metadata-transfer multilib-strict parallel-fetch sandbox sfperms strict test"
GENTOO_MIRRORS="http://open-systems.ufl.edu/mirrors/gentoo http://gentoo.cites.uiuc.edu/pub/gentoo/ http://gentoo.mirrors.tds.net/gentoo ftp://gentoo.netnitco.net/pub/mirrors/gentoo/source/"
LINGUAS="en"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --delete-after --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --filter=H_**/files/digest-*"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="X a52 aac alsa amd64 ao apache2 berkdb bitmap-fonts bluetooth bzip2 chardet cli cracklib crypt cups curl dbus dri dts dvd dvdread encode fam fastcgi ffmpeg firefox flac foomaticdb fortran gd gdbm gif gnome gpm gtk gtk2 hal iconv ipv6 isdnlog java jpeg kde lame libg++ libwww live lm_sensors logrotate lua lzo mad memcache midi mikmod mng modplug mp3 mpeg mpi ncurses nls nptl nptlonly nsplugin ogg opengl oss pam pango pcre perl png ppds pppd python qt3 qt4 readline recode reflection ruby sasl scanner sdl seamonkey session snmp source spell spl ssl svg syslog tcl tcpd test theora tiff tk truetype truetype-fonts type1-fonts unicode usb vorbis webdav x264 xine xml xorg xscreensaver xv xvid zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mulaw multi null plug rate route share shm softvol" ELIBC="glibc" INPUT_DEVICES="keyboard mouse evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LINGUAS="en" USERLAND="GNU" VIDEO_CARDS="nv"
Unset:  CTARGET, INSTALL_MASK, LANG, LC_ALL, LDFLAGS, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, PORTDIR_OVERLAY
Comment 5 Marien Zwart (RETIRED) gentoo-dev 2007-05-14 21:41:19 UTC
I think I fixed the unittest_fileutils failure: those tests needed FEATURES=userpriv, I've patched the package to skip them when you're running the tests as root. I cannot reproduce the other failure. Can you please attach the actual traceback, which is somewhere in the middle of the build log? (or just attach the whole log if you're not sure what bit is relevant)
Comment 6 Raúl Porcel (RETIRED) gentoo-dev 2007-05-15 13:20:45 UTC
What's up with the dep of tk? It should be added...
Comment 7 Marien Zwart (RETIRED) gentoo-dev 2007-05-16 00:06:54 UTC
pylint works just fine without tk. The only thing that does not work is the gui frontend, which is far from a critical feature. And that is patched to tell you to remerge python with the right flags to make it work. I really don't want to force everyone using pylint to (re)merge python with USE=tk, since pylint is perfectly usable on a machine with no X bits at all.

Or do you mean the tests fail without a python with USE=tk? If you do, please say so :) (and include a traceback)
Comment 8 Steve Dibb (RETIRED) gentoo-dev 2007-05-16 02:51:02 UTC
Created attachment 119408 [details]
failed test log
Comment 9 Raúl Porcel (RETIRED) gentoo-dev 2007-05-16 08:29:29 UTC
Well, why install the gui if it doesn't have the dep? It should be removed if USE=-tk, imo :)

And btw, i get this on x86 and ia64:

Ran 562 test cases in 59.94s (45.08s CPU) , 62 errors , 6 failed , 2 skipped
5 tests OK.
5 tests failed: func_test, func_test_sample_config, regrtest, smoketest, unittest_lint

!!! ERROR: dev-python/pylint-0.12.2 failed.


I guess those are the tests that should fail as stated on the bug, going to fix that?. Logilab-common didn't fail any test.
Comment 10 Marien Zwart (RETIRED) gentoo-dev 2007-05-16 09:42:28 UTC
(In reply to comment #8)
> Created an attachment (id=119408) [edit]
> failed test log

That is quite odd. I'm not sure if I can debug this from here. The test is checking if the StringIO module is correctly classified as a stdlib module, so either you have a copy of StringIO that is not in the stdlib shadowing the stdlib module or the code is incorrectly determining what the location of the stdlib is. Output of the following would be interesting:

python -c 'import StringIO; print StringIO'
python -c 'from logilab.common import modutils; print modutils.STD_LIB_DIR'

And your emerge --info (mainly interested in the python version).

My wild guess right now is it's triggered by multilib (what modutils thinks is the stdlib location being in /usr/lib/ while the module is in /usr/lib64 or vice versa), but I'd like to see the paths from the above commands before making too many guesses :)

(In reply to comment #9)
> Well, why install the gui if it doesn't have the dep? It should be removed if
> USE=-tk, imo :)

The code (/usr/bin/pylint-gui specifically) is patched to print you need to remerge python with the tkinter flag set if you want the gui to work. I think this is more convenient than removing the file because it makes it easier to discover that pylint-gui exists and you do not have to unnecessarily remerge pylint to get pylint-gui if you change the value of the flag. If people think it is a big problem to have a pylint-gui that tells you that you need to rebuild python instead of no pylint-gui at all I will remove the file instead, but this actually makes the ebuild more complicated (currently there's a very straightforward unconditionally applied patch instead of a USE=tk conditional).

> And btw, i get this on x86 and ia64:
> 
> Ran 562 test cases in 59.94s (45.08s CPU) , 62 errors , 6 failed , 2 skipped
> 5 tests OK.
> 5 tests failed: func_test, func_test_sample_config, regrtest, smoketest,
> unittest_lint
> 
> !!! ERROR: dev-python/pylint-0.12.2 failed.

I thought I mentioned this already, but I really want pylint (and everything else in dev-python/ for that matter) to merge successfully even if that means simply skipping some or all tests. I cannot reproduce those test failures. Can you please attach a full log and include the versions of logilab-common and astng that were installed?

Everyone else reporting test failures in anything: pretty please include the actual tracebacks (or a complete log if you can't figure out what is and is not relevant) since it is likely whoever bumped the ebuild did test with FEATURES=test and got no failures.
Comment 11 Raúl Porcel (RETIRED) gentoo-dev 2007-05-16 10:55:05 UTC
Created attachment 119433 [details]
build.log for pylint

main armin # equery l logilab
[ Searching for package 'logilab' in all categories among: ]
 * installed packages
[I--] [ ~] dev-python/logilab-common-0.21.2 (0)
Comment 12 Marien Zwart (RETIRED) gentoo-dev 2007-05-16 11:40:49 UTC
I'm a moron. Reproduced, I was using the latest pylint instead of pylint 0.12.2. The bug is that pylint 0.12.2 does not work with the latest version of astng. I've tightened the deps now. If you still hit failures with either pylint 0.13.x + latest astng or pylint 0.12.x and the version of astng that now depends on attach a log.

I'd prefer to morph this bug into "stabilize pylint-0.13.1" (also requested by dsd) unless pythonhead objects.
Comment 13 Rob Cakebread (RETIRED) gentoo-dev 2007-05-16 19:56:15 UTC
(In reply to comment #12)
> I'd prefer to morph this bug into "stabilize pylint-0.13.1" (also requested by
> dsd) unless pythonhead objects.
> 

No, I'd prefer 0.13.1 also (I changed the summary). 0.13.1 hadn't been in portage very long when I filed the original bug.

p.s. I added a tk USE flag and check to see if Python was compiled with tk yesterday.
Comment 14 Raúl Porcel (RETIRED) gentoo-dev 2007-05-17 10:59:39 UTC
x86 stable, but i didn't stabilize it on ia64. We don't have a stable keyword and we don't want to stabilize it :)

Comment 15 nixnut (RETIRED) gentoo-dev 2007-05-19 16:24:34 UTC
Stable on ppc
Comment 16 Christian Faulhammer (RETIRED) gentoo-dev 2007-05-20 08:46:16 UTC
amd64 stable and closing