Bug 175948 – mail-filter/maildrop-2.0.4 fails to install (missing makedat/makedatprog)

• Status: RESOLVED TEST-REQUEST
• Product: Gentoo Linux

[Description Diego Elio Pettenò (RETIRED) 2007-04-25 11:09:22 UTC]

As per summary:

[snip]
/usr/bin/install -c liblock/lockmail /var/tmp/portage/mail-filter/maildrop-2.0.4/image//usr/bin/lockmail
/usr/bin/install -c maildir/maildirmake /var/tmp/portage/mail-filter/maildrop-2.0.4/image//usr/bin/maildirmake
/usr/bin/install -c rfc2045/reformime /var/tmp/portage/mail-filter/maildrop-2.0.4/image//usr/bin/reformime
/usr/bin/install -c rfc2045/makemime /var/tmp/portage/mail-filter/maildrop-2.0.4/image//usr/bin/makemime
/usr/bin/install -c makedat/makedatprog /var/tmp/portage/mail-filter/maildrop-2.0.4/image//usr/bin/makedatprog
/usr/bin/install: cannot stat `makedat/makedatprog': No such file or directory
make[2]: *** [install-maildrop] Error 1
make[2]: Leaving directory `/var/tmp/portage/mail-filter/maildrop-2.0.4/work/maildrop-2.0.4'
make[1]: *** [install-am] Error 2
make[1]: Leaving directory `/var/tmp/portage/mail-filter/maildrop-2.0.4/work/maildrop-2.0.4'
make: *** [install-recursive] Error 1

I'm attaching the build log, but I can't find any error in there. I'll check the build dir asap, too.

Thanks,
Diego

[Comment 1 Diego Elio Pettenò (RETIRED) 2007-04-25 11:09:50 UTC]

Created attachment 117216 [details]
Build log

[Comment 2 Diego Elio Pettenò (RETIRED) 2007-04-25 11:12:29 UTC]

The problem seems to be due to the fact that I have all db flags disabled (maildrop is used for a single user), and while the make all target considers this fine, make install doesn't take it into consideration.
I'm not sure how to handle it sincerely.

[Comment 3 Fernando J. Pereda (RETIRED) 2007-04-25 12:56:38 UTC]

Heck... forgot to try without db support. I'll take a look at it later.

Thanks Diego.

- ferdy

[Comment 4 Fernando J. Pereda (RETIRED) 2007-04-25 13:48:21 UTC]

How about something along the lines of:

---8<---
diff --git a/Makefile.am b/Makefile.am
index 988867e..cfa7e9a 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -127,7 +127,7 @@ install-maildrop:
 	$(INSTALL_PROGRAM) maildir/maildirmake $(DESTDIR)$(bindir)/maildirmake
 	$(INSTALL_PROGRAM) rfc2045/reformime $(DESTDIR)$(bindir)/reformime
 	$(INSTALL_PROGRAM) rfc2045/makemime $(DESTDIR)$(bindir)/makemime
-	$(INSTALL_PROGRAM) makedat/makedatprog $(DESTDIR)$(bindir)/makedatprog
+	test -x makedat/makedatprog && $(INSTALL_PROGRAM) makedat/makedatprog $(DESTDIR)$(bindir)/makedatprog
 	$(INSTALL_SCRIPT)  makedat/makedat     $(DESTDIR)$(bindir)/makedat
 	. maildrop/uidgid ; test -z "$$gid" && exit 0; test -w /etc || exit 0; cd $(DESTDIR)$(bindir) && chgrp $$gid maildrop lockmail
 	. maildrop/uidgid ; test -z "$$uid" && exit 0; test -w /etc || exit 0; cd $(DESTDIR)$(bindir) && chown $$uid maildrop lockmail && chmod 755 maildrop lockmail
---8<---

It definitely ain't pretty, though.

- ferdy

[Comment 5 Diego Elio Pettenò (RETIRED) 2007-04-25 13:55:59 UTC]

I thought about it but there is a problem with this: it won't fail if makedat/makedatprog is not built but should have been.
Of course it should fail during the building make run, but I'm for 100% safety.

[Comment 6 Fernando J. Pereda (RETIRED) 2007-04-26 09:52:54 UTC]

How about using bin_PROGRAMS instead of noinst_PROGRAMS in makedat/Makefile.am ? Would that work ?

- ferdy

[Comment 7 Doug Goldstein (RETIRED) 2007-04-26 16:55:55 UTC]

They've got their own installation section and they're using noinst_PROGRAMS? That's just silly. It should be bin_PROGRAMS..

[Comment 8 Fernando J. Pereda (RETIRED) 2007-04-26 17:27:48 UTC]

Ok, trying a simple fix. If it works I'll commit it.

- ferdy

[Comment 9 Fernando J. Pereda (RETIRED) 2007-04-26 19:33:15 UTC]

Ok, I commited a patch in maildrop-2.0.4 . It seems to work for me, please try it and reopen if it fails.

Thanks guys.

- ferdy