Bugzilla Bug 175694

Hi.

I created minimal ebuilds (app-emacs/ecmascript-mode and
app-emacs/javascript-mode) for editing javascript files in emacs. They will
conflict together so that emacs could decide which major-mode to load, but I
don't know this is a good way...

Please tell me if there is something wrong with them because I am newbie.

Thanks.


Reproducible: Always

Created an attachment (id=117076) [edit]
ecmascript-mode

Created an attachment (id=117078) [edit]
50ecmascript-mode-gentoo.el

Created an attachment (id=117080) [edit]
javascript-mode-1.12.ebuild

A version of this package is correctly 1.1-2. But a hyphen within the version
is not accepted, so I omitted the hyphen...

Created an attachment (id=117082) [edit]
50javascript-mode-gentoo.el

You will need to make sure some kind of emacs is installed. Like with
DEPEND="virtual/emacs" or DEPEND="app-editors/xemacs".

I did not write DEPEND="virtual/emacs" consciously because I found a same code
in /usr/portage/eclass/elisp.class.

(In reply to comment #5)
> You will need to make sure some kind of emacs is installed. Like with
> DEPEND="virtual/emacs" or DEPEND="app-editors/xemacs".

You need not; this is already set by elisp.eclass.

(In reply to comment #3)
> A version of this package is correctly 1.1-2. But a hyphen within the version
> is not accepted, so I omitted the hyphen...

You should do something like the following here:

inherit versionator
MY_PV=$(replace_version_separator 2 '-')
SRC_URI="http://gentoo.panicode.com/distfiles/${PN}-${MY_PV}.tar.gz"

And the ebuild should then be named "javascript-mode-1.1.2.ebuild".

(In reply to comment #8)
> > A version of this package is correctly 1.1-2. But a hyphen within the
> > version is not accepted, so I omitted the hyphen...

Sorry, I am confused. The distfile is really named 1.12, but the included elisp
file has javascript-mode-version = 1.10. Which one is right?

Note that there is also javascript mode by Karl Landström. See discussion at
<http://www.emacswiki.org/cgi-bin/wiki/JavaScriptMode>, especially the coloured
box at the bottom.

> Sorry, I am confused. The distfile is really named 1.12, but the included elisp
> file has javascript-mode-version = 1.10. Which one is right?
Sorry, I confused the version about the hyphen with another version of package
I created, but thanks to let me know I will fix it before posting :)
So, assuming that the author forgot to rewrite the version I decided 1.12 is
right from the following link.
http://cvs.xemacs.org/viewcvs.cgi/XEmacs/packages/xemacs-packages/prog-modes/javascript-mode.el

> Note that there is also javascript mode by Karl Landström. See discussion at
> <http://www.emacswiki.org/cgi-bin/wiki/JavaScriptMode>, especially the coloured
> box at the bottom.
It seems that this javascript-mode is better than both I posted, especially
about indentation.
I want to create an ebuild for new one like app-emacs/karl-javascript-mode if
such the measure is usual. Or I should replace old one with new one?

(In reply to comment #10)
> It seems that this javascript-mode is better than both I posted, especially
> about indentation.
> I want to create an ebuild for new one like app-emacs/karl-javascript-mode if
> such the measure is usual. Or I should replace old one with new one?

You may just post the ebuild if you wish. We can decide about the name of the
package later.

Created an attachment (id=117298) [edit]
ecmascript-mode-1.1.ebuild

Created an attachment (id=117299) [edit]
javascript-mode-1.12.ebuild

Created an attachment (id=117300) [edit]
karl-javascript-mode-2.0_beta8

Created an attachment (id=117302) [edit]
50karl-javascript-mode-gentoo.el

I posted karl-javascript-mode-2.0_beta8.ebuild and
50karl-javascript-mode-gentoo.el.

Please check them.

(In reply to comment #16)
> I posted karl-javascript-mode-2.0_beta8.ebuild and
> 50karl-javascript-mode-gentoo.el.
> 
> Please check them.

Syntax looks O.K. (You could use ${PN} for the SITEFILE, i.e. 50${PN}-gentoo.el
but this is not mandatory.)

Have you tested it on all architectures that are in KEYWORDS?

(In reply to comment #16)
> Please check them.

 Thumbs up from me, too.  Same comments though.

> Syntax looks O.K. (You could use ${PN} for the SITEFILE, i.e. 50${PN}-gentoo.el
> but this is not mandatory.)
I will fix it.

> Have you tested it on all architectures that are in KEYWORDS?
I have tested on amd64 only...

(In reply to comment #19)
> > Have you tested it on all architectures that are in KEYWORDS?
> I have tested on amd64 only...

 Then please remove all those you have not tested yourself.

Created an attachment (id=117364) [edit]
ecmascript-mode/ecmascript-mode-1.1.ebuild

Created an attachment (id=117366) [edit]
javascript-mode-1.12.ebuild

Created an attachment (id=117368) [edit]
karl-javascript-mode-2.0_beta8.ebuild

I rewrote SITEFILE with ${PN} like SITEFILE="50${PN}-gentoo.el" and removed
untested keywords.

Karl Landström's javascript mode is available as package app-emacs/javascript
in the Emacs Overlay, see <http://overlays.gentoo.org/proj/emacs/>.
(It may take a few hours for the distfile to appear on the Gentoo mirrors.)

(In reply to comment #25)
> Karl Landström's javascript mode is available as package app-emacs/javascript
> in the Emacs Overlay, see <http://overlays.gentoo.org/proj/emacs/>.

Added to CVS, thank you for submitting the ebuild.
(Keyworded as ~x86; the ~amd64 keyword will follow soon.)