Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 175639 - [PATCH] optionally set nice priority for syslog-ng
Summary: [PATCH] optionally set nice priority for syslog-ng
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Mr. Bones. (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-04-23 02:43 UTC by Mike Mattie
Modified: 2007-05-05 23:08 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch for files/syslog-ng.rc6 (syslog-ng-prio.diff,637 bytes, text/plain)
2007-04-23 02:45 UTC, Mike Mattie
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Mattie 2007-04-23 02:43:45 UTC
modify the /etc/init.d/syslog-ng script to honor SYSLOG_NG_NICELEVEL in
/etc/conf.d/syslog-ng

if no nicelevel is specified it defaults to 0.



Reproducible: Always
Comment 1 Mike Mattie 2007-04-23 02:45:20 UTC
Created attachment 117032 [details]
patch for files/syslog-ng.rc6

There was alot of noise in the diffing, I dropped all the hunks but the change
I wanted, but I had to hand-edit the last hunk so there may be some fuzz.
Comment 2 Mr. Bones. (RETIRED) gentoo-dev 2007-04-23 05:06:18 UTC
This doesn't seem generally useful.  Why do you need it?
Comment 3 Mike Mattie 2007-04-23 07:02:04 UTC
If it isn't useful for a person they can ignore it. Not setting a
SYSLOG_NG_NICELEVEL value results in "0" which is what it would default to
on a normal system.

For me it is important that syslog-ng does not have high latencies under load.
First in my mind is accurate time-stamping of log events. In any case when
the system is not behaving properly , overloaded or other reasons I will
absolutely need the log daemon running smoothly.

The simplest way to stabalize the latency is to simply to set the nice value appropriately.

I can't see any real downside, it is a one-liner that will not affect other
people, and those that do want to set the nice level for the daemon will not
have merge noise for every update.
Comment 4 Mr. Bones. (RETIRED) gentoo-dev 2007-04-24 04:06:54 UTC
ok, I can dig it.  In CVS.  resync/remerge if you need it.
Comment 5 Mike Mattie 2007-04-24 10:30:30 UTC
Much appreciated. I like the state of this package alot.
Comment 6 Roy Marples (RETIRED) gentoo-dev 2007-05-05 12:33:09 UTC
Could we revert this please? Not only does it re-introduce a bashism by using [[ .. ]] (thus breaking fbsd), but we already have this feature in baselayout-2 where SSD nice values can be done like so in /etc/conf.d/foo

export SSD_NICELEVEL=19
Comment 7 Mr. Bones. (RETIRED) gentoo-dev 2007-05-05 23:08:31 UTC
oh great.  I'd rather use the more generic method anyhow.  Thanks for pointing it out.  I reverted back to the previous version in CVS.