Hello, I create the patch for media-video/mplayer-1.0_rc2_pre20070321-r4, which cleaned dvd/dvdnav/dvdread use flags and configured mplayer properly. I discovered that dvdread flag is not needed because configure of mplayer check dvdnav first, and if that is failed, it defaults to internal dvdread. Therefore, dvd useflag is also obsolete. Anyway, see the patch.
Created attachment 116343 [details, diff] mplayer-1.0_rc2_pre20070321-r4.ebuild.patch The patch itself
Also, i create a patch for mplayer configure - please, see http://svn.mplayerhq.hu/mplayer/trunk/configure?r1=22997&r2=22998
Created attachment 116345 [details, diff] files/mplayer-dvd-verbose.patch patch for mplayer configure
Send the configure script patches upstream, to see if they would take them. Other than that, the ebuild patch looks good, but the policy is not to forcibly enable anything, which is why you only see --disable flags for those.
It's already in upstream - please, see comment #2
Created attachment 117461 [details, diff] mplayer-1.0_rc2_pre20070321-r4.ebuild.patch v2 Version without --enable-dvdnav
And BTW, it's need a modification in ogmrip which needed mplayer with dvd flag. I delete this flag because it's not needed (it's replaced by dvdnav flag). It was needed because of dvdnav and dvdread flags. But dvdread didn't do anything! (with "-dvdread -dvdnav" mplayer was compiled with internal dvdread/dvdcss)
Created attachment 118085 [details, diff] mplayer-20070427.patch Updated patch for ebuild without patch for configure (which in upstream)
(In reply to comment #7) > And BTW, it's need a modification in ogmrip which needed mplayer with dvd flag. > I delete this flag because it's not needed (it's replaced by dvdnav flag). It > was needed because of dvdnav and dvdread flags. But dvdread didn't do anything! > (with "-dvdread -dvdnav" mplayer was compiled with internal dvdread/dvdcss) > That's because the ebuild doesn't include --disable-dvdread-internal, it just disables external dvdread.
It's internal, so we don't need to disable it anyway
Should be good now, removed 'dvdread' use flag, so now we only have 'dvd' for generic DVD stuff, and 'dvdnav' for new libdvdnav support from upstream.
