Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 174422 - rename PATH/ROOTPATH in gcc env.d files
Summary: rename PATH/ROOTPATH in gcc env.d files
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All All
: High enhancement (vote)
Assignee: Gentoo Toolchain Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-04-13 10:34 UTC by SpanKY
Modified: 2019-09-08 09:15 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description SpanKY gentoo-dev 2007-04-13 10:34:21 UTC
there's no point in using PATH/ROOTPATH in the /etc/env.d/gcc/ config files since we turn around and translate the file before writing the gcc file in /etc/env.d/

renaming to GCC_PATH and simply dropping ROOTPATH should allow us to drop all the funky PATH search hacks and such (and in the process, work nicely with baselayout-2)
Comment 1 SpanKY gentoo-dev 2007-05-03 05:19:04 UTC
fixed with gcc-config-1.4.0
Comment 2 Larry the Git Cow gentoo-dev 2019-09-05 07:24:00 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/gcc-config.git/commit/?id=231bc60d6fa6b8eb309ac2ca308f7c60213f81a3

commit 231bc60d6fa6b8eb309ac2ca308f7c60213f81a3
Author:     Sergei Trofimovich <slyfox@gentoo.org>
AuthorDate: 2019-09-05 07:20:05 +0000
Commit:     Sergei Trofimovich <slyfox@gentoo.org>
CommitDate: 2019-09-05 07:20:05 +0000

    gcc-config: drop GCC_PATH reconstruction in /etc/env.d/gcc
    
    toolchain.eclass constructs correct GCC_PATH since 2007:
    commit 7d9f89700a2ee50674c0d871ec6d21b468ac6206
    ("start moving to GCC_PATH for env.d #174422 and cleanup "
    "gcc-config logic so that it doesnt matter what the ROOT value is")
    
    We don't need to rewrite /etc/env.d/gcc/<TARGET>-<VER>
    files anymore (owned by gcc ebuilds).
    
    Bug: https://bugs.gentoo.org/174422
    Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>

 gcc-config | 24 ------------------------
 1 file changed, 24 deletions(-)
Comment 3 Larry the Git Cow gentoo-dev 2019-09-05 19:06:02 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=534e0f7d5e8a02264b7b7fc97c3ef11441e35c5c

commit 534e0f7d5e8a02264b7b7fc97c3ef11441e35c5c
Author:     Sergei Trofimovich <slyfox@gentoo.org>
AuthorDate: 2019-09-05 19:01:04 +0000
Commit:     Sergei Trofimovich <slyfox@gentoo.org>
CommitDate: 2019-09-05 19:05:56 +0000

    toolchain.eclass: drop PATH and ROOTPATH from /etc/env.d/gcc/
    
    toolchain.eclass constructs correct GCC_PATH since 2007:
    commit 7d9f89700a2ee50674c0d871ec6d21b468ac6206
    ("start moving to GCC_PATH for env.d #174422 and cleanup "
    "gcc-config logic so that it doesnt matter what the ROOT value is")
    
    gcc-config moved over as well. Let's leave GCC_PATH as
    the only available variable to locate gcc's whereabouts.
    
    Bug: https://bugs.gentoo.org/174422
    Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>

 eclass/toolchain.eclass | 2 --
 1 file changed, 2 deletions(-)
Comment 4 Larry the Git Cow gentoo-dev 2019-09-08 08:29:46 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/gcc-config.git/commit/?id=1e2e76a2b23caef964de881b14146c58b0a0ee77

commit 1e2e76a2b23caef964de881b14146c58b0a0ee77
Author:     Arfrever Frehtes Taifersar Arahesis <Arfrever@Apache.Org>
AuthorDate: 2019-09-08 06:48:14 +0000
Commit:     Sergei Trofimovich <slyfox@gentoo.org>
CommitDate: 2019-09-08 08:29:31 +0000

    gcc-config: Ignore PATH set in profile files.
    
    Profile files created by toolchain.eclass before gentoo commit 534e0f7d5e8a02264b7b7fc97c3ef11441e35c5c
    contain assignment of PATH variable (e.g. PATH="/usr/x86_64-pc-linux-gnu/gcc-bin/9.2.0").
    Sourcing them without restoring previous PATH value breaks gcc-config.
    
    Fixes: 231bc60d6fa6b8eb309ac2ca308f7c60213f81a3
    Bug: https://bugs.gentoo.org/174422
    Signed-off-by: Arfrever Frehtes Taifersar Arahesis <Arfrever@Apache.Org>
    Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>

 gcc-config | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
Comment 5 Larry the Git Cow gentoo-dev 2019-09-08 08:37:27 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/gcc-config.git/commit/?id=84ba7d0ccde1869bed07f9d9b9c2fac09f48c13a

commit 84ba7d0ccde1869bed07f9d9b9c2fac09f48c13a
Author:     Sergei Trofimovich <slyfox@gentoo.org>
AuthorDate: 2019-09-08 08:35:51 +0000
Commit:     Sergei Trofimovich <slyfox@gentoo.org>
CommitDate: 2019-09-08 08:35:51 +0000

    gcc-config: consolidate profiles sourcing logic in a single function
    
    Bug: https://bugs.gentoo.org/174422
    Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>

 gcc-config | 29 +++++++++++------------------
 1 file changed, 11 insertions(+), 18 deletions(-)
Comment 6 Larry the Git Cow gentoo-dev 2019-09-08 09:15:21 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=cc51dde0d07754dd5ce1155424d730274372739f

commit cc51dde0d07754dd5ce1155424d730274372739f
Author:     Sergei Trofimovich <slyfox@gentoo.org>
AuthorDate: 2019-09-08 09:13:26 +0000
Commit:     Sergei Trofimovich <slyfox@gentoo.org>
CommitDate: 2019-09-08 09:15:09 +0000

    sys-devel/gcc-config: bump up to 2.1
    
    - Don't cleanup /lib/libunwind.so (bug #667020)
    - Drop GCC_PATH reconstruction (bug #174422)
    - Use findmnt for mountpoint check when available (bug #693588)
    - drop /etc/env.d/gcc/.NATIVE symlink
    - drop /etc/env.d/gcc/config migration code
    - drop empty /etc/env.d/05gcc-${CTARGET} files
    - add einfo logging around library backup
    
    Bug: https://bugs.gentoo.org/667020
    Bug: https://bugs.gentoo.org/174422
    Bug: https://bugs.gentoo.org/693588
    Package-Manager: Portage-2.3.75, Repoman-2.3.17
    Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>

 sys-devel/gcc-config/Manifest               |  1 +
 sys-devel/gcc-config/gcc-config-2.1.ebuild  | 54 +++++++++++++++++++++++++++++
 sys-devel/gcc-config/gcc-config-9999.ebuild |  4 +--
 3 files changed, 57 insertions(+), 2 deletions(-)