Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 173795 - xfce-base/thunar-0.8.0-r2: Command chosen in UCA browse isn't quoted
Summary: xfce-base/thunar-0.8.0-r2: Command chosen in UCA browse isn't quoted
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High trivial (vote)
Assignee: XFCE Team
URL: http://bugzilla.xfce.org/show_bug.cgi...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-04-08 20:04 UTC by Alexander Skwar
Modified: 2007-05-02 12:34 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch against thunar-uca-editor.c, adding quotes (thunar-uca-editor_add-quotes.patch,1.27 KB, patch)
2007-04-08 20:06 UTC, Alexander Skwar
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Skwar 2007-04-08 20:04:56 UTC
In Thunar, a user can select a so-called "UCA" (User Configurable Action). In doing so, he can BROWSE to select a command which is to be run. If the path to command (including the actual filename) contains spaces, the command is to be put in quotes. If it's not, when the UCA is selected, nothing will happen, as the programm cannot be found.

Attached patch fixes this issue. When a user selects (after browsing) a filename which contains spaces, the quotes (") are put before and after the filename.

There's also a bug at upstream reg. this - http://bugzilla.xfce.org/show_bug.cgi?id=3105
Comment 1 Alexander Skwar 2007-04-08 20:06:12 UTC
Created attachment 115747 [details, diff]
Patch against thunar-uca-editor.c, adding quotes

The attached patch makes it so, that the filename has quotes (") before and
after it, if quotes are required. Right now, it only checks for the occurance
of space.
Comment 2 Alexander Skwar 2007-04-08 20:07:04 UTC
Forgot to mention the purpose of this bug - I'd like to suggest to add this patch to a (possible) r3, as it makes Thunar easier and better to use.
Comment 3 Samuli Suominen (RETIRED) gentoo-dev 2007-04-13 12:18:41 UTC
Alexander, We'll wait until upstream responses in http://bugzilla.xfce.org/show_bug.cgi?id=3105 before doing this change.
Comment 4 Samuli Suominen (RETIRED) gentoo-dev 2007-04-23 12:18:18 UTC
Upstream is here saying 'This bug should be marked INVALID'. http://bugzilla.xfce.org/show_bug.cgi?id=3105#c7

If they change their mind, let us know.. ty.
Comment 5 Samuli Suominen (RETIRED) gentoo-dev 2007-04-25 12:08:02 UTC
http://bugzilla.xfce.org/show_bug.cgi?id=3105#c11 , status has changed to upstream patch in form of unapplied patch attached to upstream bug. waiting for resolution.
Comment 6 Samuli Suominen (RETIRED) gentoo-dev 2007-05-02 12:34:28 UTC
(In reply to comment #2)
> Forgot to mention the purpose of this bug - I'd like to suggest to add this
> patch to a (possible) r3, as it makes Thunar easier and better to use.
> 

I applied Nick Schermer's patch from upstream bug in -r3. Thanks for your work and reporting.