Bug 173131 – genpatches: speakup console speech drivers compilation error

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Guryanov Dmitry 2007-04-02 12:24:00 UTC]

jiffies variable used in all drivers, but jiffies.h included only on i386 through linux/module.h -> linux/elf.h -> asm/elf.h -> linux/utsname.h -> linux/sched.h
on other platforms linux/utsname.h not included in asm/elf.h




Reproducible: Always




possible solution:

diff -uprN linux-2.6.20.orig/drivers/char/speakup/spk_priv.h linux-2.6.20/drivers/char/speakup/spk_priv.h
--- linux-2.6.20.orig/drivers/char/speakup/spk_priv.h   2007-04-02 14:15:36.000000000 +0400
+++ linux-2.6.20/drivers/char/speakup/spk_priv.h        2007-04-02 14:29:44.000000000 +0400
@@ -34,6 +34,7 @@
 #include <linux/wait.h>                /* for wait_queue */
 #include <linux/init.h> /* for __init */
 #include <linux/module.h>
+#include <linux/jiffies.h>
 #ifdef CONFIG_PROC_FS
 #include <linux/proc_fs.h>
 #endif

[Comment 1 Guryanov Dmitry 2007-04-04 12:54:53 UTC]

Checked in gentoo-sources-2.6.20-r4 and vanilla 2.6.20 patched with genpatches-2.6.20-5

[Comment 2 Daniel Drake (RETIRED) 2007-04-25 15:45:40 UTC]

Thanks, it's correct, I'll get to this soon.

[Comment 3 Daniel Drake (RETIRED) 2007-04-26 20:17:26 UTC]

Fixed in gentoo-sources-2.6.20-r7