Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 173009 - media-gfx/xfig has invalid SRC_URI + straight to stable
Summary: media-gfx/xfig has invalid SRC_URI + straight to stable
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High trivial (vote)
Assignee: Anant Narayanan (RETIRED)
URL:
Whiteboard:
Keywords:
: 173036 (view as bug list)
Depends on:
Blocks:
 
Reported: 2007-04-01 13:40 UTC by Konrad Karczewski
Modified: 2007-04-02 18:31 UTC (History)
6 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Konrad Karczewski 2007-04-01 13:40:09 UTC
Currently emerge tries to download:
http://www.xfig.org/xfigdist/xfig.3.2.5.full.tar.gz

Proper URI would be:
http://xfig.org/software/xfig/3.2.5/xfig.3.2.5.full.tar.gz

Probably there as been a change on the site recently

Reproducible: Always

Steps to Reproduce:
Comment 1 Jakub Moc (RETIRED) gentoo-dev 2007-04-01 14:18:37 UTC
There's no xfig-3.2.5 in the tree.
Comment 2 Jakub Moc (RETIRED) gentoo-dev 2007-04-01 16:40:23 UTC
*** Bug 173036 has been marked as a duplicate of this bug. ***
Comment 3 Csaba Biro 2007-04-01 18:39:39 UTC
(In reply to comment #1)
> There's no xfig-3.2.5 in the tree.

Yes, there is. Yes, there is. I can confirm this bug.

Comment 4 Anant Narayanan (RETIRED) gentoo-dev 2007-04-01 19:00:03 UTC
Thanks, fixed in CVS.
Comment 5 Jakub Moc (RETIRED) gentoo-dev 2007-04-01 22:25:45 UTC
Why exactly has this been committed straight to stable?
Comment 6 Peter Volkov (RETIRED) gentoo-dev 2007-04-02 15:39:30 UTC
Thilo. I've CC you here as seems that you've commited xfig directly into stable.
Philip, I've CC you... See the last paragraph. :)

So. Thank you for version bump of xfig. Although I saw announce there was always maintainer of xfig, but after you bumped it I've look why everything was so fast and found another package I enjoy with empty metadata. 

But there are some issues with xfig-3.2.5 which you missed during commit:

1. Policy prohibits to bumping directly into arch.

2. Upstream requirement to depend on transfig 3.2.5:
"You also need to get TransFig version 3.2.5."
http://xfig.org/software/xfig/3.2.5/xfig.README
though xfig works with the previous versions too.

3. Some xfig files are installed into /usr/local/ and this path does not follow policy...

4. xfig uses gcc and does not use user CFLAGS, LDFLAGS although it should.
http://devmanual.gentoo.org/ebuild-writing/functions/src_compile/building/index.html

I went ahead and fixed all this issues. I even took package, so Jakub knew where xfig bugs should be directed ;) But only after I wrote ebuild I've noticed that all bugs are assigned on you Anant. Sorry. If you wish to take the package you are free to do that.

And the last thing is that xfig and transfig are packages with the same upstream. So seems that it's natural to maintain them together. Philip, I found that you are the maintainer of transfig. If you want to maintain it that's very good, but as I've bumped new transfig version as a dependency of xfig like to be sure that you have reviewed ebuild I've commited. Also may be you know how to avoid: "incompatible implicit declaration of built-in function ‘strlen’" during compilation of sys.c? Solution that I suggest is in comments of the ebuild, but I'd like to ask somebody who knows imake build system rather well is that solution the right one.
Comment 7 Thilo Bangert (RETIRED) (RETIRED) gentoo-dev 2007-04-02 17:49:08 UTC
yeah - my bad. i am really sorry. i need to buy you guys a beer or hot chocolate for covering me.
pva: thanks for the fixes.

btw, i think 3.2.5_alpa5 can be removed (incl. the p.mask)

also, the following has to be considered, 
from http://xfig.org/art15.html:

"This is expected to be the final version, since Brian V. Smith has no time for further development. A tip 'o the hat to Brian for all of his work over the years."

/me retracts himself from everything xfig.
Comment 8 Anant Narayanan (RETIRED) gentoo-dev 2007-04-02 18:31:16 UTC
> I went ahead and fixed all this issues. I even took package, so Jakub knew
> where xfig bugs should be directed ;) But only after I wrote ebuild I've
> noticed that all bugs are assigned on you Anant. Sorry. If you wish to take the
> package you are free to do that.

Thanks, Peter, for the fixes. Thilo did ask me to review the ebuild before he committed it, but I guess I missed these issues. Feel free to take over maintanence of the package :)