Bugzilla Bug 172586

The build system for fish always executes the user_doc rule, which
requires doxygen irrespective of any USE flag setting.

  Possible fixes include:

    * simply depending on doxygen unconditionally even though it isn't
      strictly required,
    * patching user_doc out of the `all' target or calling the others
      manually in the ebuild,
    * a stub function if USE=doc isn't set to skip doxygen usage because
      the docs are already prebuilt anyway.

  Being lazy, and not wanting doxygen needlessly, I went for the second
option and attached is a patch which does this.  Although, I imagine
some will prefer a cleaner fix :/

Thanks,

James

Created an attachment (id=114808) [details]
fish-no_doxygen.patch

  The patch also changes the with USE=doc conditional to use the
`user_doc' rule, because the doc files that are built with the `doc'
rule aren't even installed.

*** Bug 170809 has been marked as a duplicate of this bug. ***

Please file this bug with the upstream developers. I'll be happy to add a fix
once upstream accepts it.

I don't agree with closing the bug as resolved, since it is obviously not
resolved.

Whats wrong with the patch anyway? You didn't even leave a comment on this.

(In reply to comment #4)
> I don't agree with closing the bug as resolved, since it is obviously not
> resolved.

It is not resolved as fixed, it is resolved as this is an upstream issue to
fix. Once this fix is upstream, we will reopen this bug, add the patch and mark
it as fixed.

> Whats wrong with the patch anyway? You didn't even leave a comment on this.

It's not in the upstream source code. I don't add patches that aren't in the
upstream code, because it increases Gentoo's maintenance burden and makes us
the end-point of support instead of upstream.

  For what it is worth as the original poster I *won't* personally be taking 
this upstream, I'm not a fish user I only installed it to check on a user's 
collision report with another package(#131638 and #145928) and the latest 
ebuild's behaviour of just forcing the doxygen dep is fine with me(minus the
spurious doc USE flag anyhow).

(In reply to comment #6)
> ebuild's behaviour of just forcing the doxygen dep is fine with me(minus the
> spurious doc USE flag anyhow).

Thanks for pointing that out, I just fixed it.

Reopening as app-shells/fish-1.22.2 is still affected by this bug. Adding the
dep on app-doc/doxygen works over here.

please add the doxygen dep, or apply the patch.

uhm, sorry for the spam.  doxygen dep is already in there.

fish-1.23.0 does not comes anymore with doc useflag , and it builds fine
without doxygen installed.

Removing doxygen DEPEND