First Last Prev Next    No search results available      Search page      Enter new bug
Bug#: 172533
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Gentoo Toolchain Maintainers <toolchain@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Kevin F. Quinn (RETIRED) <kevquinn@gentoo.org>
Add CC:
CC:
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
autogen-5.8.8-test_filter_gdb_properly.patch Fixup insufficient sed script to remove any -g* debug flag, not just drop '-g' patch Kevin F. Quinn (RETIRED) 2007-03-28 09:51 0000 371 bytes Details | Diff
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 172533 depends on: Show dependency tree
Bug 172533 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug


Description:   Opened: 2007-03-28 09:50 0000
The test autoopts/test/immediate.test fails if CFLAGS contains any of the debug
flags (apart from -g).  This is because it tries to filter those flags out by
using this:

  CFLAGS="-g `echo ${CFLAGS} | \
    sed 's,-O2,,;s/-g//'`"

which clearly replaces -ggdb2 (for example) with -gdb2 - which isn't a valid
CFLAG and the test compilation fails.  A simple fix is to make the sed script a
little more consistent.  The following works:

  CFLAGS="-g `echo ${CFLAGS} | \
    sed 's,-O2,,;s/-g[^ \t]*//g'`"

I figured really they want to remove any -g* flags.  Patch to follow.

------- Comment #1 From Kevin F. Quinn (RETIRED) 2007-03-28 09:51:41 0000 -------
Created an attachment (id=114708) [edit]
Fixup insufficient sed script to remove any -g* debug flag, not just drop '-g'

------- Comment #2 From Kevin F. Quinn (RETIRED) 2007-03-28 09:52:56 0000 -------
(In reply to comment #0)
> which clearly replaces -ggdb2 (for example) with -gdb2

I meant it is replaced with 'gdb2' (no '-').

------- Comment #3 From SpanKY 2007-03-30 06:03:25 0000 -------
i've gone with:
+  sed 's,-O2,,;s/-g[^[:space:]]*//'`"

cheers

------- Comment #4 From Mikko Tiihonen 2007-04-21 13:27:32 0000 -------
I just found two new gcc parameters that the fix in the ebuild doesn't handle
but the fix applied upstream does.

--param max-gcse-passes=4
--param max-gcse-memory=209715200

I suggest changing the patch in ebuild to use the sed script from upsteam with
sed 's,-O2,,;s/[ \t][ \t]*-g[^ \t]*[ \t][ \t]*/ /'

First Last Prev Next    No search results available      Search page      Enter new bug