Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 172198 - media-video/mplayer installing .svn directories into /usr/share/doc/
Summary: media-video/mplayer installing .svn directories into /usr/share/doc/
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High minor (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-03-25 16:53 UTC by Ryan Hill (RETIRED)
Modified: 2007-05-01 13:52 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
mplayer-1.0_rc2_pre20070321-r4.ebuild.diff (mplayer-1.0_rc2_pre20070321-r4.ebuild.diff,746 bytes, patch)
2007-03-25 16:53 UTC, Ryan Hill (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Hill (RETIRED) gentoo-dev 2007-03-25 16:53:26 UTC
the mplayer ebuild is installing a crapload of .svn directories into the docdir.  this patch is against mplayer-1.0_rc2_pre20070321-r4 but other versions are probably affected too.
Comment 1 Ryan Hill (RETIRED) gentoo-dev 2007-03-25 16:53:52 UTC
Created attachment 114389 [details, diff]
mplayer-1.0_rc2_pre20070321-r4.ebuild.diff
Comment 2 Martin von Gagern 2007-03-26 17:48:02 UTC
I would prefer to strip .svn dirs as early as possible, instead of copying files just to delete them again immediately afterwards.

I would like it best if I could even avoid unpacking those directories, but right now it seems to be impossible to pass arguments for tar to the unpack function. I just filed bug #172322 with this suggestion, but it will probably take some time till a new portage version is prevalent. Duplicating unpack inside the ebuild seems too much work to be woth the effort.

So I'd run the delete on ${S} immediately after the main tarball has been unpacked, instead of waiting till the install phase.

While working on bug #172314 I found out that at least dohtml has the option to exclude specific dirs, but this solution would not help TOOLS for example.

Another possibility to realize a copy with excludes would be a pipe connecting two tar commands. An alternative if there is a good reason why you don't want to delete files from the source tree, and it might perhaps help with permissions as well.
Comment 3 Georgi Georgiev 2007-04-27 18:10:21 UTC
Come-on guys, this one's a no-brainer. And it's even a *stable* package now.
Comment 4 Steve Dibb (RETIRED) gentoo-dev 2007-04-27 21:48:22 UTC
(In reply to comment #3)
> Come-on guys, this one's a no-brainer. And it's even a *stable* package now.
> 

Stable because of bug 168917.

Either way, fixed in CVS in mplayer-1.0.20070427.ebuild
Comment 5 Steve Dibb (RETIRED) gentoo-dev 2007-05-01 13:52:50 UTC
Finally fixed correctly in mplayer-1.0.20070321-r1.ebuild