Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 171787 - sys-apps/parted-1.8.8 stabilization request
Summary: sys-apps/parted-1.8.8 stabilization request
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo LiveCD Package Maintainers
URL:
Whiteboard:
Keywords: STABLEREQ
Depends on:
Blocks: 182358
  Show dependency tree
 
Reported: 2007-03-22 13:04 UTC by Natanael Copa
Modified: 2007-12-11 12:57 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
parted-1.8.2-no-iconv.patch (parted-1.8.2-no-iconv.patch,858 bytes, patch)
2007-03-22 13:18 UTC, Natanael Copa
Details | Diff
parted-1.8.2-no-iconv.patch (parted-1.8.2-no-iconv.patch,1.20 KB, patch)
2007-03-22 13:25 UTC, Natanael Copa
Details | Diff
parted-1.8.2-libintl.patch (parted-1.8.2-libintl.patch,1.77 KB, patch)
2007-03-26 08:51 UTC, Natanael Copa
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Natanael Copa 2007-03-22 13:04:30 UTC
i386-gentoo-linux-uclibc-gcc -DHAVE_CONFIG_H -I. -I. -I../.. -I../../include -march=i386 -Os -pipe -fomit-frame-pointer -D_REENTRANT -D_FILE_OFFSET_BITS=64 -DLOCALEDIR=\"/usr/share/locale\" -DLOCALEDIR=\"/usr/share/locale\" -W -Wall -Wno-unused -Wno-switch -Wno-format -MT fdasd.lo -MD -MP -MF .deps/fdasd.Tpo -c fdasd.c  -fPIC -DPIC -o .libs/fdasd.o
make[3]: *** [dasd.lo] Error 1
make[3]: *** Waiting for unfinished jobs....
fdasd.c:24:21: libintl.h: No such file or directory
make[3]: *** [fdasd.lo] Error 1
make[3]: Leaving directory `/var/tmp/portage/sys-apps/parted-1.8.2/work/parted-1.8.2/libparted/labels'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/var/tmp/portage/sys-apps/parted-1.8.2/work/parted-1.8.2/libparted'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/var/tmp/portage/sys-apps/parted-1.8.2/work/parted-1.8.2'
make: *** [all] Error 2

!!! ERROR: sys-apps/parted-1.8.2 failed.
Comment 1 Natanael Copa 2007-03-22 13:18:02 UTC
Created attachment 114047 [details, diff]
parted-1.8.2-no-iconv.patch

The patch take care of the iconv problem.
Should be reported upstream.
Comment 2 Natanael Copa 2007-03-22 13:25:54 UTC
Created attachment 114049 [details, diff]
parted-1.8.2-no-iconv.patch

dasd.c slipped away in previous patch somehow.
Comment 3 Natanael Copa 2007-03-22 13:28:13 UTC
After no-inconv patch is applied it stops with this:

i386-gentoo-linux-uclibc-gcc -march=i386 -Os -pipe -fomit-frame-pointer -D_REENTRANT -D_FILE_OFFSET_BITS=64 -DLOCALEDIR=\"/usr/share/locale\" -DLOCALEDIR=\"/usr/share/locale\" -W -Wall -Wno-unused -Wno-switch -Wno-format -o .libs/parted parted-command.o parted-parted.o parted-strlist.o parted-ui.o parted-table.o  ../libparted/.libs/libparted.so -luuid -lreadline -ldl -lncurses 
../libparted/.libs/libparted.so: undefined reference to `posix_memalign'
collect2: ld returned 1 exit status
make[2]: *** [parted] Error 1

I suspect we need to add posix_memalign to uclibc? No idea...
Comment 4 SpanKY gentoo-dev 2007-03-22 22:48:36 UTC
we've already implemented that in uClibc trunk ... get the iconv issue fixed as the posix_memalign one is a different one
Comment 5 SpanKY gentoo-dev 2007-03-22 22:49:20 UTC
the logic should probably be:
#ifdef HAVE_LIBINTL_H
#include <libintl.h>
#endif
Comment 6 Natanael Copa 2007-03-23 08:19:45 UTC
(In reply to comment #5)
> the logic should probably be:
> #ifdef HAVE_LIBINTL_H
> #include <libintl.h>
> #endif
> 

Then you also need an 

AC_CHECK_HEADERS(libintl.h)

in configure.ac.

I wonder if #ifdef ENABLE_NLS could be used?
Comment 7 SpanKY gentoo-dev 2007-03-24 05:50:45 UTC
then update configure.ac accordingly ...
Comment 8 SpanKY gentoo-dev 2007-03-24 05:51:20 UTC
... and yes, it should also be ENABLE_NLS

#ifdef ENABLE_NLS
#ifdef HAVE_LIBINTL_H
#include <libtintl.h>
#endif
...
#endif
Comment 9 Natanael Copa 2007-03-26 08:30:56 UTC
parted-1.8.6 is released upstream. The problem is still ther so I'm reporting upstream. Could we get parted 1.8.6 into the portage tree? So I avoid double work (the 1.8.2 configure.ac patch will not work on 1.8.6)

Thanks!
Comment 10 Natanael Copa 2007-03-26 08:51:17 UTC
Created attachment 114463 [details, diff]
parted-1.8.2-libintl.patch

Here is a patch for 1.8.2. It fixes the #ifdefs and configure.ac. however, eautoreconf will still fail on a non-nls system. Best would be if upstream could provide a proper configure script so we don't need to run autoreconf.
Comment 11 Natanael Copa 2007-03-26 09:00:40 UTC
Upstream trac ticket:
http://parted.alioth.debian.org/cgi-bin/trac.cgi/ticket/28

Comment 12 Raúl Porcel (RETIRED) gentoo-dev 2007-03-28 11:10:02 UTC
Moved back to ~x86.
Comment 13 Raúl Porcel (RETIRED) gentoo-dev 2007-06-13 14:04:33 UTC
is this still broken in 1.8.6?
Comment 14 solar (RETIRED) gentoo-dev 2007-06-14 12:33:38 UTC
(In reply to comment #13)
> is this still broken in 1.8.6?

Yes.

The error is as follows.

 i386-gentoo-linux-uclibc-gcc -std=gnu99 -I. -I../../lib -I../../include -Os -pipe -fforce-addr -fomit-frame-pointer -Wstack-protector -Wformat=2 -MT fdasd.lo -MD -MP -MF .deps/fdasd.Tpo -c fdasd.c  -fPIC -DPIC -o .libs/fdasd.o
fdasd.c:25:21: libintl.h: No such file or directory
 i386-gentoo-linux-uclibc-gcc -std=gnu99 -I. -I../../lib -I../../include -Os -pipe -fforce-addr -fomit-frame-pointer -Wstack-protector -Wformat=2 -MT dasd.lo -MD -MP -MF .deps/dasd.Tpo -c dasd.c  -fPIC -DPIC -o .libs/dasd.o
make[2]: *** [fdasd.lo] Error 1
make[2]: *** Waiting for unfinished jobs....
 i386-gentoo-linux-uclibc-gcc -std=gnu99 -I. -I../../lib -I../../include -Os -pipe -fforce-addr -fomit-frame-pointer -Wstack-protector -Wformat=2 -MT rdb.lo -MD -MP -MF .deps/rdb.Tpo -c rdb.c  -fPIC -DPIC -o .libs/rdb.o
 i386-gentoo-linux-uclibc-gcc -std=gnu99 -I. -I../../lib -I../../include -Os -pipe -fforce-addr -fomit-frame-pointer -Wstack-protector -Wformat=2 -MT bsd.lo -MD -MP -MF .deps/bsd.Tpo -c bsd.c -o bsd.o >/dev/null 2>&1
dasd.c:43:21: libintl.h: No such file or directory
make[2]: *** [dasd.lo] Error 1
mv -f .deps/bsd.Tpo .deps/bsd.Plo
 i386-gentoo-linux-uclibc-gcc -std=gnu99 -I. -I../../lib -I../../include -Os -pipe -fforce-addr -fomit-frame-pointer -Wstack-protector -Wformat=2 -MT rdb.lo -MD -MP -MF .deps/rdb.Tpo -c rdb.c -o rdb.o >/dev/null 2>&1
mv -f .deps/rdb.Tpo .deps/rdb.Plo
make[2]: Leaving directory `/var/tmp/portage/sys-apps/parted-1.8.6/work/parted-1.8.6/libparted/labels'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/var/tmp/portage/sys-apps/parted-1.8.6/work/parted-1.8.6/libparted'
make: *** [all-recursive] Error 1

!!! ERROR: sys-apps/parted-1.8.6 failed.
Comment 15 Chris Gianelloni (RETIRED) gentoo-dev 2007-06-19 23:11:04 UTC
Do any versions of parted (in the tree) work on uclibc?
Comment 16 Natanael Copa 2007-06-20 08:53:02 UTC
(In reply to comment #15)
> Do any versions of parted (in the tree) work on uclibc?
> 

yes. parted-1.7.1-r1 works.
Comment 17 Jakub Moc (RETIRED) gentoo-dev 2007-09-05 07:33:49 UTC
*** Bug 191337 has been marked as a duplicate of this bug. ***
Comment 18 Natanael Copa 2007-09-05 07:56:59 UTC
Looks like this issue is fixed in 1.8.8
Comment 19 Chris Gianelloni (RETIRED) gentoo-dev 2007-09-13 17:27:33 UTC
Well, it hasn't quite been 30 days, but what do you guys think of asking for parted-1.8.8 to go stable?  This will resolve this bug and allow me to clean up the parted ebuilds in the tree.
Comment 20 SpanKY gentoo-dev 2007-09-15 01:03:25 UTC
*shrug* embedded team tends to look just to the future rather than requiring everything be fixed in stable YESTERDAY
Comment 21 Chris Gianelloni (RETIRED) gentoo-dev 2007-09-20 19:25:58 UTC
Arches, please mark sys-apps/parted-1.8.8 stable.  Target KEYWORDS="alpha amd64 arm hppa ia64 ~mips ppc ppc64 s390 sh sparc x86"
Comment 22 Lars Weiler (RETIRED) gentoo-dev 2007-09-20 20:15:04 UTC
ppc stable.
Comment 23 Jurek Bartuszek (RETIRED) gentoo-dev 2007-09-22 23:04:24 UTC
x86 stable
Comment 24 Raúl Porcel (RETIRED) gentoo-dev 2007-09-24 11:40:05 UTC
alpha/ia64 stable, thanks Tobias
Comment 25 Jeroen Roovers (RETIRED) gentoo-dev 2007-09-25 15:18:32 UTC
Stable for HPPA.
Comment 26 Togge 2007-09-26 09:37:59 UTC
--- amd64 ---
 
sys-apps/parted-1.8.8 - USE: nls readline -debug -selinux device-mapper

1: emerges
2: passes collision-protect, (multilib-)strict, test
3: works (Write not tested, no free disc :( )

Portage 2.1.3.9 (default-linux/amd64/2007.0/desktop, gcc-4.1.2, glibc-2.5-r4, 2.6.22-gentoo-r5 x86_64)
=================================================================
System uname: 2.6.22-gentoo-r5 x86_64 AMD Athlon(tm) 64 X2 Dual Core Processor 4200+
Timestamp of tree: Wed, 26 Sep 2007 04:00:01 +0000
ccache version 2.4 [enabled]
app-shells/bash:     3.2_p17
dev-java/java-config: 1.3.7, 2.0.33-r1
dev-lang/python:     2.4.4-r5
dev-python/pycrypto: 2.0.1-r6
dev-util/ccache:     2.4-r7
sys-apps/baselayout: 1.12.9-r2
sys-apps/sandbox:    1.2.17
sys-devel/autoconf:  2.13, 2.61-r1
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2, 1.10
sys-devel/binutils:  2.17-r1
sys-devel/gcc-config: 1.3.16
sys-devel/libtool:   1.5.24
virtual/os-headers:  2.6.21
ACCEPT_KEYWORDS="amd64"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -ggdb -march=athlon64 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/3.5/env /usr/kde/3.5/share/config /usr/kde/3.5/shutdown /usr/share/X11/xkb /usr/share/config"
CONFIG_PROTECT_MASK="/etc/env.d /etc/env.d/java/ /etc/gconf /etc/init.d /etc/php/apache2-php5/ext-active/ /etc/php/cgi-php5/ext-active/ /etc/php/cli-php5/ext-active/ /etc/revdep-rebuild /etc/terminfo /etc/texmf/web2c"
CXXFLAGS="-O2 -ggdb -march=athlon64 -pipe"
DISTDIR="/tmp/portage"
FEATURES="ccache collision-protect distlocks metadata-transfer multilib-strict parallel-fetch sandbox sfperms splitdebug strict test unmerge-orphans userfetch"
GENTOO_MIRRORS="http://ds.thn.htu.se/linux/gentoo 		http://ftp.belnet.be/mirror/rsync.gentoo.org/gentoo/ 		http://ftp-stud.fht-esslingen.de/pub/Mirrors/gentoo/ 		http://mirror.switch.ch/mirror/gentoo/ 		http://trumpetti.atm.tut.fi/gentoo/"
LANG="en_US.utf-8"
LINGUAS="en sv"
MAKEOPTS="-j3"
PKGDIR="/tmp/packages"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --delete-after --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --filter=H_**/files/digest-*"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/portage/local/private"
SYNC="rsync://dx/gentoo-portage"
USE="3dnow 3dnowext X a52 aac acpi aiglx alsa amd64 apache2 arts asf avi bash-completion berkdb bitmap-fonts branding browserplugin cairo ccache cdr cli cpudetection cracklib crypt cscope css cups cvs dbus divx divx4linux dlloader dri dvd dvdr dvdread eds emboss encode esd evo fam ffmpeg firefox flac foomaticdb fortran freetype gdbm geoip gif gimp gmedia gnokii gnome gpm gstreamer gtk hal http iconv ieee1394 imap imlib ipv6 isdnlog java javascript jfs jpeg kde kdeenablefinal kdehiddenvisibility kdepim kerberos logitech-mouse mad madwifi maildir midi mikmod mmx mmx2 mmxext mono mozbranding moznopango mozsvg mp3 mpeg mplayer msn mudflap mysql ncurses nls nptl nptlonly nsplugin ntfs nvidia obex ogg oggvorbis opengl openmp oss pam pcre pdf pdflib perl png pppd python qt qt3 qt3support qt4 quicktime readline realmedia reflection reiserfs samba scanner sdl session spell spl sse sse2 ssl subversion svg symlink tcpd test tetex theora threads tiff truetype truetype-fonts type1-fonts udev unicode usb v4l v4l2 vim-syntax vim-with-x visualization vorbis wifi wmf wmp wxwindows xcomposite xface xfs xine xinerama xml xorg xosd xpm xprint xv xvid zlib" ALSA_CARDS="emu10k1" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mulaw multi null plug rate route share shm softvol" ELIBC="glibc" INPUT_DEVICES="mouse keyboard evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LINGUAS="en sv" USERLAND="GNU" VIDEO_CARDS="nv nvidia"
Unset:  CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, LDFLAGS, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
Comment 27 Christoph Mende (RETIRED) gentoo-dev 2007-09-26 12:27:44 UTC
amd64 stable
Comment 28 Tom Gall (RETIRED) gentoo-dev 2007-10-06 05:24:56 UTC
stable on ppc64
Comment 29 Jorge Manuel B. S. Vicetto (RETIRED) Gentoo Infrastructure gentoo-dev 2007-10-24 02:22:58 UTC
sys-apps/parted-1.8.8

1. Emerges on SPARC64.
2. No collisions.
3. Tests always hang after:

make[2]: Entering directory `/var/tmp/portage/sys-apps/parted-1.8.8/work/parted-1.8.8/tests'
*   ok 1: create the test file
* FAIL 2: run parted -s FILE mklabel msdos
        parted -s $dev mklabel msdos > out 2>&1
* FAIL 3: expect no output
        $compare out /dev/null
*   ok 4: erase the left-over label

4. parted runs, removed a sun-ufs partition and created it back.

tried with:
sys-apps/parted-1.8.8 (nls)
sys-apps/parted-1.8.8 (nls readline)
sys-apps/parted-1.8.8 (device-mapper nls readline)

Tests worked with parted-1.7.1-r1

emerge --info:
Portage 2.1.3.9 (default-linux/sparc/sparc64/2007.0, gcc-4.1.2, glibc-2.6.1-r0, 2.6.17-gentoo-r8 sparc64)
=================================================================
System uname: 2.6.17-gentoo-r8 sparc64 sun4u
Timestamp of tree: Sat, 20 Oct 2007 11:50:01 +0000
app-shells/bash:     3.2_p17
dev-lang/python:     2.4.4-r5
dev-python/pycrypto: 2.0.1-r6
sys-apps/baselayout: 1.12.9-r2
sys-apps/sandbox:    1.2.17
sys-devel/autoconf:  2.13, 2.61-r1
sys-devel/automake:  1.7.9-r1, 1.10
sys-devel/binutils:  2.18-r1
sys-devel/gcc-config: 1.3.16
sys-devel/libtool:   1.5.24
virtual/os-headers:  2.6.22-r2
ACCEPT_KEYWORDS="sparc"
CBUILD="sparc-unknown-linux-gnu"
CFLAGS="-O2 -mcpu=ultrasparc3 -pipe"
CHOST="sparc-unknown-linux-gnu"
CONFIG_PROTECT="/etc /var/bind"
CONFIG_PROTECT_MASK="/etc/env.d /etc/gconf /etc/php/apache2-php5/ext-active/ /etc/php/cgi-php5/ext-active/ /etc/php/cli-php5/ext-active/ /etc/revdep-rebuild /etc/terminfo /etc/udev/rules.d"
CXXFLAGS="-O2 -mcpu=ultrasparc3 -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="collision-protection distlocks metadata-transfer parallel-fetch sandbox sfperms strict test unmerge-orphans userfetch"
GENTOO_MIRRORS="http://ftp.belnet.be/mirror/rsync.gentoo.org/gentoo/ ftp://ftp.gentoo-pt.org/pub/gentoo ftp://mirrors1.netvisao.pt/gentoo/ http://trumpetti.tut.atm.fi/gentoo"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --delete-after --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --filter=H_**/files/digest-*"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://atl64.acores.pt/gentoo-portage"
USE="bitmap-fonts cli cracklib crypt cups dri fortran gdbm gpm iconv isdnlog midi mudflap nls nptl nptlonly openmp pam pcre ppds pppd reflection session sparc spl tcpd test truetype-fonts type1-fonts unicode vhosts xorg" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mulaw multi null plug rate route share shm softvol" ELIBC="glibc" INPUT_DEVICES="keyboard mouse evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" USERLAND="GNU" VIDEO_CARDS="dummy fbdev glint mach64 mga r128 radeon sunbw2 suncg14 suncg3 suncg6 sunffb sunleo tdfx v4l voodoo"
Unset:  CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LANG, LC_ALL, LDFLAGS, LINGUAS, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
Comment 30 Raúl Porcel (RETIRED) gentoo-dev 2007-11-05 17:47:34 UTC
sparc stable, thanks Jorge