Bugzilla Bug 171529

This is my first attempt at ebuild writing other than patching small bits so
please review/test.  It is based off the madwifi-ng-0.9.2 ebuild.

The madwifi-ng-tools-0.9.2 ebuild can simply be copied to
madwifi-ng-tools-0.9.3 I believe.  Atleast that is what I did for the moment.

Compiles, installs and works on x86/hardened hostapd machine.  Clients have
connectivity.  Very little testing otherwise.  Have not tried it with
wpa_supplicant yet, too late, need sleep.

Reproducible: Always

Created an attachment (id=113835) [details]
madwifi-ng-0.9.3.ebuild

Created an attachment (id=113836) [details]
madwifi-ng-0.9.3-uudecode-gcda-fix.patch

Created an attachment (id=113838) [details]
madwifi-ng-0.9.3.ebuild-rev02

revised ebuild (obsoletes madwifi-ng-0.9.3.ebuild attachment):
-testing (~) not stable
-don't export variables

Very nice - the ARCH bit (well, really the src_compile() isn't needed at all)
isn't necessary (that I have seen) - I actually bumped this last night
sometime, and didn't get this bug until this morning.  Great work though, and
look forward to hearing from you if there are any bugs (aside from a few known
ones ;) )

One issue.  With madwifi-ng-0.9.3 rate control module selection is done at
module load time instead of compile time as in madwifi-ng-0.9.2*.  No special
USE flags or any related stuff is needed.  Patch against the
madwifi-ng-0.9.3.ebuild in portage incoming now.

Regarding the ARCH stuff: You are correct, I get rid of src_compile() and no
problems.  I was getting ARCH mismatch errors related to madwifi's ARCH
detection script, scripts/get_arch.mk while I was working on this but not
anymore. *shrug*

Created an attachment (id=113878) [details]
madwifi-build_all_ratemods.patch

Good catch - when I get out of work, I will apply and bump

Created an attachment (id=113910) [details]
madwifi-build_all_ratemods-rev2.patch

BUILD_PARAMS variable is also no longer used.  I missed removing that in the
first patch.

Bumped and added to CVS - Thanks for the work on this :)

Some issues with the latest ebuild:

BUILD_PARAMS has been removed, now madwifi builds against the running kernel
rather than the one in /usr/src/linux and this is not the correct behaviour

IUSE is missing from the ebuild

Using ${PN}-${PV} is redundant, use ${P} instead (in the epatch line)

Created an attachment (id=113972) [details]
Fixes issues in comment #10

Those are my fault entirely.  Sorry, still learning.  Here is a patch against
-r1.  Thank you for the constructive feedback.

Those changes look correct, thanks!

Fixed, I hope.  Added IUSE after it was pointed out that it is a MUST
apparently.  Repoman didn't complain, so I assumed it was correct.  If I keep
screwing up the ebuild it will never get stabled ;)