Bugzilla Bug 171414

Klamav has an option to update itself and clamav from gui, but this option is
not good and secure cause patches and configure parameters will not be included
to those updates so it should be disabled in the gui.

Reproducible: Always

Created an attachment (id=113760) [details]
No update patch

Patch to disable update gui in klamav and some utf8 fix

I think that instead comments the following is better:

#ifdef GUI_UPDATE
Some code
#endif

Gentoo is about choices and the above solution adds users the possibility of
the enabling of the updating of Klamav from GUI by using CXXFLAGS="${CXXFLAGS}
-DGUI_UPDATE" (If they very need it.).
The ebuild also needs to have appropriate `einfo` message telling about it.

(In reply to comment #2)
> I think that instead comments the following is better:
> 
> #ifdef GUI_UPDATE
> Some code
> #endif
> 
> Gentoo is about choices and the above solution adds users the possibility of
> the enabling of the updating of Klamav from GUI by using CXXFLAGS="${CXXFLAGS}
> -DGUI_UPDATE" (If they very need it.).
> The ebuild also needs to have appropriate `einfo` message telling about it.
> 

That sounds messy, and it's not a good idea to add arbitrary -D flags into
C(XX)FLAGS. How about a local USE flag, if you really want the option to be
there?

(In reply to comment #3)
> That sounds messy, and it's not a good idea to add arbitrary -D flags into
> C(XX)FLAGS. How about a local USE flag, if you really want the option to be
> there?

So it's better to unconditionally disable this feature.

Why we dont just disable to update klamav and clamav from klamav gui :)
This job is not klamav's duty but emerge, isn't it?

I believe that we should disable update option in klamav

comments?

This looks like a feature enhancement that should really be pushed upstream. I
agree that it is portage's job to update these packages and would like to see
an option to disable updates from the GUI.

Did anyone contact upstream about this?

(In reply to comment #8)
> Did anyone contact upstream about this?

Probably no.

 (In reply to comment #9)
> (In reply to comment #8)
> > Did anyone contact upstream about this?
> Probably no.

I did! :-)

I've just committed klamav 0.42 which includes a switch to turn off updates
from the GUI. Those are now disabled.

Created an attachment (id=142749) [details]
klamav-0.42.ebuild.patch

The ebuild in portage ignores the standard kde useflags because it calls econf
by itself. This is especially a problem since klamav fails to build if arts is
not installed even with USE=-arts.
The attached patch adds the --with-disableupdates parameter to configure "the
KDE way".

(In reply to comment #12)
> Created an attachment (id=142749) [edit] [details]
> klamav-0.42.ebuild.patch
> 
> The ebuild in portage ignores the standard kde useflags because it calls econf
> by itself. This is especially a problem since klamav fails to build if arts is
> not installed even with USE=-arts.
> The attached patch adds the --with-disableupdates parameter to configure "the
> KDE way".
> 

Andrei, please open a separate bug for this, as it is not in any way related to
what this bug was about. Thanks.

(In reply to comment #13)
> (In reply to comment #12)
> > Created an attachment (id=142749) [edit] [details]
> > klamav-0.42.ebuild.patch
> > 
> > The ebuild in portage ignores the standard kde useflags because it calls econf
> > by itself. This is especially a problem since klamav fails to build if arts is
> > not installed even with USE=-arts.
> > The attached patch adds the --with-disableupdates parameter to configure "the
> > KDE way".
> > 
> 
> Andrei, please open a separate bug for this, as it is not in any way related to
> what this bug was about. Thanks.
> 

I placed the patch here because the problem I was relating is a collateral of
the fix for this bug. Maybe I was not clear in my comment about this. Anyway,
this patch made it to portage so it's fine now.