Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 170795 - app-portage/portage-utils - add a -E/--eclass option to qgrep
Summary: app-portage/portage-utils - add a -E/--eclass option to qgrep
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Portage Utils Team
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks:
 
Reported: 2007-03-13 22:27 UTC by TGL
Modified: 2007-04-05 18:43 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
qgrep--add_eclass_option.patch (qgrep--add_eclass_option.patch,3.74 KB, patch)
2007-03-13 22:28 UTC, TGL 		Details | Diff
qgrep--add_eclass_option.patch (qgrep--add_eclass_option.patch,3.00 KB, patch)
2007-03-17 16:32 UTC, TGL 		Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description TGL 2007-03-13 22:27:26 UTC 
Here is a patch which adds an --eclass option, which makes qgrep search in eclasses instead of ebuilds.
Comment 1 TGL 2007-03-13 22:28:35 UTC 
Created attachment 113220 [details, diff]
qgrep--add_eclass_option.patch
Comment 2 solar (RETIRED) gentoo-dev 2007-03-16 22:18:01 UTC 
The new -E option does not print the path relative to $PORTDIR for the matching eclass.
Comment 3 TGL 2007-03-17 08:36:39 UTC 
(In reply to comment #2)
> The new -E option does not print the path relative to $PORTDIR for the matching
> eclass.
> 

Ok, a new patch follows which changes that (now prints "eclass/foo.eclass"). It is also a bit shorter, since it reuses the "ebuild" local var for eclass file paths, instead of adding a new one. And finally it adds a closedir() that was missing.
Comment 4 solar (RETIRED) gentoo-dev 2007-03-17 16:14:11 UTC 
(In reply to comment #3)
..
> Ok, a new patch follows which changes that (now prints "eclass/foo.eclass").

Did you forget to attach the patch?
Comment 5 TGL 2007-03-17 16:32:04 UTC 
Created attachment 113578 [details, diff]
qgrep--add_eclass_option.patch

Ooops...
Comment 6 solar (RETIRED) gentoo-dev 2007-03-17 20:32:12 UTC 
/var/cvsroot/gentoo-projects/portage-utils/qgrep.c,v  <--  qgrep.c
new revision: 1.16; previous revision: 1.15
Comment 7 solar (RETIRED) gentoo-dev 2007-04-05 18:42:18 UTC 
This is released in 0.1.25

Bug #168334 ; q -r dies with a segfault after emerge --sync
Bug #168442 ; does not  properly parse the profile location
Bug #170795 ; add a -E/--eclass option to qgrep
Bug #170797 ; add a -s/--skip-comments option to qgrep
Bug #171024 ; opening '/usr/portage/.metadata.x' failed
Bug #171374 ; Misc enhancements for qgrep
Bug #172240 ; -A/-B options for qgrep (context lines) 
Bug #172338 ; qgrepping through installed ebuilds (in the VDB) 
Bug #173005 ; Colorized output for qgrep.
Comment 8 solar (RETIRED) gentoo-dev 2007-04-05 18:43:02 UTC 
Closing