Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 169697 - dev-db/phpmyadmin - improved phpmyadmin postinstall file
Summary: dev-db/phpmyadmin - improved phpmyadmin postinstall file
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo Web Application Packages Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-03-07 01:40 UTC by David Grant
Modified: 2007-05-30 18:39 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
improved postinstall-en-2.8.0.txt (postinstall-en-2.8.0.txt,1.43 KB, text/plain)
2007-03-07 01:43 UTC, David Grant
Details

Note You need to log in before you can comment on or make changes to this bug.
Description David Grant 2007-03-07 01:40:31 UTC
The postinstall message says this:

   Alternatively, use the default config file in libraries/config.default.php

   mkdir /var/www/goliath.internal.dwavesys.com/htdocs/phpmyadmin/config
   chmod o+rw /var/www/goliath.internal.dwavesys.com/htdocs/phpmyadmin/config
   # if you want to edit existing configuration:
   cp /var/www/goliath.internal.dwavesys.com/htdocs/phpmyadmin/config.inc.php /var/www/goliath.internal.dwavesys.com/htdocs/phpmyadmin/config/
   chown -R apache:apache /var/www/goliath.internal.dwavesys.com/htdocs/phpmyadmin/config

This is confusing because:

1) The instructions are preceded by "alternatively, use the default config file in libraries/config.default.php". This implies that the following instructions are going to be related with how to do that, but they aren't.
2) It talks about copying /var/www/goliath.internal.dwavesys.com/htdocs/phpmyadmin/config.inc.php which does not exist in a fresh install (and it might not even exist in an old install), but it sounds like these instructions are for fresh installs only, as above in step 0 is says "If this is a new installation," and below after step 2 there is a break "==============" and then it says "If you are upgrading from an earlier version..."

How to fix it:

I will attach my suggested new version
Comment 1 David Grant 2007-03-07 01:43:00 UTC
Created attachment 112356 [details]
improved postinstall-en-2.8.0.txt
Comment 2 Jakub Moc (RETIRED) gentoo-dev 2007-03-07 01:43:44 UTC
Again? Please, you've already filed this 3 times, enough.

*** This bug has been marked as a duplicate of bug 140140 ***
Comment 3 David Grant 2007-03-07 01:55:37 UTC
I know but I keep noticing the problem every time I upgrade phpmyadmin.

Renat's comment in Bug #140140: "as the comment says, the line you're referring to is meant for editing an_existing_ config.inc.php" is correct but I never read it closely enough at the time and forgot about that bug (until I upgraded to phpmyadmin again).

The real problem with the postinstall text is that it is worded strangely. Or put another way, step 1 (in the original, I renamed it to step 2) is trying to do 3 things but it is not clear that those 3 things are really three things as the word "alternatively" is only used once. I have split this up into a), b), and c) and now it is much more clear. I would like the maintainer of phpmyadmin to have a look at this. I'm sorry for not resolving this earlier but I didn't realize because I only use the "default config file" option so I was a bit oblivious to the "existing configuration" and "web-based" options.
Comment 4 Jakub Moc (RETIRED) gentoo-dev 2007-03-07 01:59:06 UTC
Really, as noone else but you is noticing the 'problem', chances are that the problem is somewhere else than in the instructions itself...

Comment 5 David Grant 2007-03-07 17:25:25 UTC
Well I already explained why the original message is unclear so I think the onus is on someone else to explain why it is so perfectly clear and cannot use any improvement.
Comment 6 Gunnar Thielebein 2007-04-09 09:51:14 UTC
Hi,

I have problems getting phpmyadmin without pma user running and phpmyadmin guys answered that this is because of a broken config.default.php of gentoo install.

For my understanding this file is also needed for the setup script to working correctly and *mustn't* be changed in anyway.

Correct way is to only take a copy of the file (or creating new one) as config.inc.php.

BTW: They already state a comment in phpmyadmin Wiki (http://wiki.cihar.com/pma/Quick_Install#Download) to avoid gentoo package
Comment 7 Renat Lumpau (RETIRED) gentoo-dev 2007-05-26 23:26:48 UTC
Many thanks for this.  Your version (almost in its entirety) is in. 
Comment 8 Renat Lumpau (RETIRED) gentoo-dev 2007-05-26 23:27:12 UTC
(In reply to comment #6)
> Hi,
> 
> I have problems getting phpmyadmin without pma user running and phpmyadmin guys
> answered that this is because of a broken config.default.php of gentoo install.
> 
> For my understanding this file is also needed for the setup script to working
> correctly and *mustn't* be changed in anyway.
> 
> Correct way is to only take a copy of the file (or creating new one) as
> config.inc.php.
> 
> BTW: They already state a comment in phpmyadmin Wiki
> (http://wiki.cihar.com/pma/Quick_Install#Download) to avoid gentoo package
> 

We no longer patch the config file.
Comment 9 David Grant 2007-05-30 18:39:16 UTC
God damn jakub was such an asshat sometimes. Thanks Renat.