Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 169477 - media-libs/libsdl-1.2.11-r1 double free
Summary: media-libs/libsdl-1.2.11-r1 double free
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: x86 Linux
: High normal (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-03-05 18:05 UTC by Peter Alfredsen (RETIRED)
Modified: 2007-03-20 03:41 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
libsdl-1.2.11-r2.ebuild (libsdl-1.2.11-r2.ebuild,5.09 KB, text/plain)
2007-03-05 18:06 UTC, Peter Alfredsen (RETIRED)
Details
dont-propagate-lpthread.patch (libsdl-1.2.11-dont-propagate-lpthread.patch,1.81 KB, patch)
2007-03-05 18:07 UTC, Peter Alfredsen (RETIRED)
Details | Diff
libsdl-1.2.11-supermount-double-free-issue.patch (libsdl-1.2.11-supermount-double-free-issue.patch,1.18 KB, patch)
2007-03-05 18:08 UTC, Peter Alfredsen (RETIRED)
Details | Diff
libsdl-1.2.11-dont-propagate-lpthread.patch (libsdl-1.2.11-dont-propagate-lpthread.patch,1.81 KB, patch)
2007-03-05 18:09 UTC, Peter Alfredsen (RETIRED)
Details | Diff
libsdl-1.2.11-no-yasm.patch (libsdl-1.2.11-no-yasm.patch,1.67 KB, patch)
2007-03-05 18:10 UTC, Peter Alfredsen (RETIRED)
Details | Diff
libsdl-1.2.11-r1-libsdl-1.2.11-r2.patch (diff,2.25 KB, patch)
2007-03-16 11:20 UTC, Peter Alfredsen (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Alfredsen (RETIRED) gentoo-dev 2007-03-05 18:05:55 UTC
Import patches from Debian/Mandriva to fix a number of bugs:

libsdl-1.2.11-supermount-double-free-issue.patch fixes:
Debian 401950 (nexuiz: double free, memory errors)
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=401950
Debian 380508 (libsdl1.2debian: dosbox doesn't start due to invalid free)
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=380508

libsdl-1.2.11-dont-propagate-lpthread.patch
Fixes spurious dependency as reported in Debian 375822
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=375822

libsdl-1.2.11-no-yasm.patch
Fixes bug #163053. Included here because I need it to get libsdl to build without hacks. Strictly speaking, that libsdl uses yasm in the first place is a spurious dependency, since libsdl only depends on nasm.

Included for testing of patches: libsdl-1.2.11-r2.ebuild

Reproducible: Always

Steps to Reproduce:
Comment 1 Peter Alfredsen (RETIRED) gentoo-dev 2007-03-05 18:06:59 UTC
Created attachment 112190 [details]
libsdl-1.2.11-r2.ebuild
Comment 2 Peter Alfredsen (RETIRED) gentoo-dev 2007-03-05 18:07:51 UTC
Created attachment 112192 [details, diff]
dont-propagate-lpthread.patch
Comment 3 Peter Alfredsen (RETIRED) gentoo-dev 2007-03-05 18:08:25 UTC
Created attachment 112193 [details, diff]
libsdl-1.2.11-supermount-double-free-issue.patch
Comment 4 Peter Alfredsen (RETIRED) gentoo-dev 2007-03-05 18:09:27 UTC
Created attachment 112195 [details, diff]
libsdl-1.2.11-dont-propagate-lpthread.patch

Get name right this time
Comment 5 Peter Alfredsen (RETIRED) gentoo-dev 2007-03-05 18:10:07 UTC
Created attachment 112197 [details, diff]
libsdl-1.2.11-no-yasm.patch
Comment 6 Sheldon Hearn 2007-03-09 13:16:32 UTC
What patches do you remove to make yours build?

I ask because your ebuild and patches cause at least libsdl-1.2.11-fbcon-page-header.patch to break.
Comment 7 Peter Alfredsen (RETIRED) gentoo-dev 2007-03-16 11:20:32 UTC
Created attachment 113468 [details, diff]
libsdl-1.2.11-r1-libsdl-1.2.11-r2.patch

(In reply to comment #6)
> What patches do you remove to make yours build?
> 
> I ask because your ebuild and patches cause at least
> libsdl-1.2.11-fbcon-page-header.patch to break.
> 
I cannot replicate that. I noticed that the fbcon patch has been updated recently so I added that to my ebuild and rebuilt it. Nowhere does it reject any patches.
Attached a diff from the current portage ebuild to the one in my overlay.
Comment 8 teidakankan 2007-03-19 09:46:08 UTC
Thanks for the this ebuild as -r1 wouldn't build for me.  I did have to comment out this patch as it was not included:

	epatch "${FILESDIR}"/${P}-linux-headers.patch #159923
Comment 9 SpanKY gentoo-dev 2007-03-20 03:41:54 UTC
ive taken the cdrom fix from upstream and added it to 1.2.11-r2 ... the pthread fix i'll take upstream