Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 169383 - Better symlink handling for genkernel
Summary: Better symlink handling for genkernel
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Hosted Projects
Classification: Unclassified
Component: genkernel (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo Genkernel Maintainers
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks:
 
Reported: 2007-03-05 00:03 UTC by John R. Graham
Modified: 2007-04-05 15:01 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch implements new --symlink handling. (genkernel-3.4.6-symlink.patch,11.22 KB, patch)
2007-03-05 00:04 UTC, John R. Graham
Details | Diff
Updates man page and internal --help documentation. (genkernel-3.4.6-docs.patch,1.97 KB, patch)
2007-03-31 16:39 UTC, John R. Graham
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John R. Graham gentoo-dev 2007-03-05 00:03:42 UTC
I've always liked the way the manual kernel install, through "make install", maintained the vmlinuz and vmlinuz.old symlinks (and their brethren for config and System.map).  The other nice thing about "make install" is that it maintains the previous kernel image and related products, renamed with .old extensions.

In looking at the genkernel script, I found the currently undocumented --symlink feature.  Alas, this feature didn't fully mirror what "make install" did.  I've kind of beefed up the implementation of this command line option so that it very closely mimics that process.

I've included a patch against genkernel-3.4.6.

Is this something that you all would be willing to accept into the source?  If so, I'll update the documentation source as well.

- John


Reproducible: Always

Steps to Reproduce:
Comment 1 John R. Graham gentoo-dev 2007-03-05 00:04:46 UTC
Created attachment 112126 [details, diff]
Patch implements new --symlink handling.
Comment 2 Chris Gianelloni (RETIRED) gentoo-dev 2007-03-09 20:32:13 UTC
I've added this to subversion and it'll show up in the next genkernel version.  I haven't tested it, but it looks good.

Thanks for the patch.
Comment 3 John R. Graham gentoo-dev 2007-03-31 16:30:33 UTC
Chris,

Thanks.  Sorry it's taken me so long, but, here's another patch, additive to the last one, that updates the man page and the internal documentation produced by "genkernel --help".

I made one other operational change:  Consistent with the other options, like --install / --no-install, I added a --no-symlink option to complement the new --symlink option.  Hope that's okay.

- John
Comment 4 John R. Graham gentoo-dev 2007-03-31 16:39:05 UTC
Created attachment 115061 [details, diff]
Updates man page and internal --help documentation.
Comment 5 Chris Gianelloni (RETIRED) gentoo-dev 2007-04-05 15:01:06 UTC
This is fixed in genkernel 3.4.7 which is now in the tree.