Bug List: (This bug is not in your last search results)   Show last search results      Search page      Enter new bug
Bug#: 168540
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Gentoo KDE team <kde@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: cameta <cameta@gmail.com>
Add CC:
CC:
Remove selected CCs
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
add-gentoo-path-to-screensaver-search-dir.patch Patch to kcontrol's kcm_screensaver patch Brian S. Stephan 2007-03-16 01:49 0000 848 bytes Details | Diff
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 168540 depends on: Show dependency tree
Bug 168540 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug


Description:   Opened: 2007-02-27 09:46 0000
I have emerged rss-glx-0.8.1-r4  USE="kde sse xscreensaver -3dnow -openal". But
this time they not appers in controlcenter, instead I found them in KMenu in
"Lost & Found".
The problem is where the *.desktop files are installed:/usr/share/applications
instead of /usr/kde/3.5/share/applnk/System/ScreenSavers.
I have modified the ebuild and now is working fine

Reproducible: Always

Steps to Reproduce:
1.emerge rss-glx
2.
3.

Actual Results:  
The screensavers don't appers in controlcenter, instead I found them in KMenu
in "Lost & Found". The .desktop files are installed in the
/usr/share/applications 

Expected Results:  
Install the .desktop files to /usr/kde/3.5/share/applnk/System/ScreenSavers

I have modified the rss-glx-0.8.1-r4ebuild:
Code:

if use kde; then
      find . -name '*.desktop' -exec \
         sed -i \
            -e 's:Exec=kxsrun \(.*\):Exec=kxsrun \1:g' \
            -e 's:Exec=kxsconfig \(.*\):Exec=kxsconfig \1:g' \
            '{}' \
         \; \
         || die "couldnt sed desktop files"
# the problem is here
      myconf="${myconf} --with-kdessconfigdir=usr/share/applications"
   fi

To this
Code:

if use kde; then
      find . -name '*.desktop' -exec \
         sed -i \
            -e 's:Exec=kxsrun \(.*\):Exec=kxsrun \1:g' \
            -e 's:Exec=kxsconfig \(.*\):Exec=kxsconfig \1:g' \
            '{}' \
         \; \
         || die "couldnt sed desktop files"
      myconf="${myconf} 
#This is the solution to the problem
--with-kdessconfigdir=/usr/kde/3.5/share/applnk/System/ScreenSavers"
   fi

------- Comment #1 From Jakub Moc (RETIRED) 2007-02-27 10:51:24 0000 -------
(In reply to comment #0)
> #This is the solution to the problem
> --with-kdessconfigdir=/usr/kde/3.5/share/applnk/System/ScreenSavers"
>    fi

No, this is not the solution; that location is deprecated and shouldn't be used
anywhere. Does /usr/share/applications/screensavers work for you?

------- Comment #2 From cameta 2007-02-27 12:21:59 0000 -------
/usr/share/applications/screensavers don't work for me.
With this location I have the same problem.
There is a screenshoot:
http://img228.imageshack.us/my.php?image=lostfoundscreensaversio4.jpg

------- Comment #3 From Samuli Suominen 2007-02-27 15:45:10 0000 -------
KDE, where do you want your extra screensaver .desktop files installed by
rss-glx with --with-kdessconfigdir= ?

It's a KDE only thing, these savers work fine without the mentioned files in
other environments and in xscreensaver itself.

------- Comment #4 From Brian S. Stephan 2007-03-16 01:42:49 0000 -------
The paths kcm_screensaver uses to look for .desktop files seems really limited.
A quick patch to kcontrol adds the current install path for rss-glx
(/usr/share/applications/).

If you don't feel like patching, you can copy rss-glx's .desktop files into
~/.kde/share/applnk/System/ScreenSavers/ and they'll show up in the screensaver
dialog.

Note that the .desktop files kind of suck, they don't put the screensavers in
any of the dialog's categories (they are put in the root of the list instead
of, say, OpenGL Screen Savers). rss-glx needs to be patched for that.

------- Comment #5 From Brian S. Stephan 2007-03-16 01:49:17 0000 -------
Created an attachment (id=113432) [details]
Patch to kcontrol's kcm_screensaver

Patches kcm_screensaver to add /usr/share/applications/ to the paths searched
when looking for .desktop files (necessary for the entries being displayed in
the dialog).

------- Comment #6 From Samuli Suominen 2007-03-24 15:14:46 0000 -------
KDE should follow standards from freedesktop.org.. 
http://standards.freedesktop.org/basedir-spec/basedir-spec-latest.html#variables

------- Comment #7 From Wulf Krueger (RETIRED) 2007-06-17 07:52:18 0000 -------
Yes, it should but currently it does only half-heartedly. Please file an
upstream bug for this and add its URL to this bug.

------- Comment #8 From Marcus D. Hanwell 2007-07-17 19:08:33 0000 -------
I would like to see an upstream bug filed about this issue and linked to from
here. This does look like a very minimal patch to fix an issue. It seems
unlikely to introduce bugs and allows KDE to better function within the
freedesktop.org standards.

I have applied the patch in 3.5.7 but didn't rev bump as this is an issue that
only affects a small number of users in a very minimal way. Works just fine
here and some of those screensavers are very pretty - would be a shame to hide
them from KDE users. I do agree that it would be good if they had better
.desktop files...

Bug List: (This bug is not in your last search results)   Show last search results      Search page      Enter new bug