Bug 168248 – media-tv/mythtv: tv_grab_nl does not use ~/.mythtv/somefile.xmltv

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Xander Hover 2007-02-24 16:44:45 UTC]

When using mythfilldatabase, tv_grab_nl will use the default config: ~/.xmltv/tv_grab_nl.conf. As it turns out, tv_grab_nl is not called with the --config-file option during mythfilldatabase

Reproducible: Always

Steps to Reproduce:
Run mythfilldatabase.
Verify how tv_grab_nl is called with the ps command.


Expected Results:  
mythfilldatabase should call tv_grab_nl with the --config-file option in addition to the --output option.

I have made the following trivial change which solves the problem.
See patch below.

diff -Naur programs/mythfilldatabase/filldata.cpp programs/mythfilldatabase/filldata.cpp
--- programs/mythfilldatabase/filldata.cpp      2007-02-24 16:25:29.000000000 +0000
+++ programs/mythfilldatabase/filldata.cpp      2007-02-24 16:26:47.000000000 +0000
@@ -2574,8 +2574,8 @@
                         xmltv_grabber.ascii(), configfile.ascii(),
                         filename.ascii());
     else if (xmltv_grabber == "tv_grab_nl")
-        command.sprintf("nice %s --output %s",
-                        xmltv_grabber.ascii(),
+        command.sprintf("nice %s --config-file '%s' --output %s",
+                        xmltv_grabber.ascii(), configfile.ascii(),
                         filename.ascii());
     else if (xmltv_grabber == "tv_grab_fi")
         // Use the default of 10 days for Finland's grabber

[Comment 1 Doug Goldstein (RETIRED) 2007-02-24 17:47:58 UTC]

Have you submitted this patch upstream? If not, please submit it upstream and provide the bug number.

[Comment 2 Stuart Morgan 2007-02-26 12:42:25 UTC]

(In reply to comment #1)
> Have you submitted this patch upstream? If not, please submit it upstream and
> provide the bug number.
> 

This only applied to 0.20, the relevant code has been removed in the development version.

I've now committed a fix to the 0.20-fixes branch.

[Comment 3 Doug Goldstein (RETIRED) 2007-03-01 05:50:04 UTC]

Thanks Stuart.

This is available in mythtv-0.20_p12884 now.