Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 168044 - www-*, x11-* ebuilds abusing ROOT
Summary: www-*, x11-* ebuilds abusing ROOT
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Quality Assurance Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 258096
  Show dependency tree
 
Reported: 2007-02-22 21:48 UTC by Ciaran McCreesh
Modified: 2009-02-08 13:01 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ciaran McCreesh 2007-02-22 21:48:11 UTC
Some notes on ROOT:

* The idea behind ROOT is that one can build a system with ROOT=/somewhere and then chroot into it or tar up /somewhere as a system image. It is not designed to allow the user to run /somewhere/usr/bin/foo.

* ROOT can't be used correctly in src_*, since ROOT might be different when merging a binary package. For example, a binary package might be built with ROOT=/ and then installed onto a system using ROOT=/somewhere.

* ROOT isn't used for library dependencies. When building, libraries, headers etc. on / have to be used. Cross-compiling etc is done by configuring the toolchain correctly, not by hacking ebuilds in a way that breaks binary packages.

Summary of all mentioned herds:
  apache desktop-dock desktop-misc media-tv no-herd perl sci www-servers x11

Summary of all mentioned maintainers:
  <cryos@gentoo.org>
  <dragonheart@gentoo.org>
  <perl@gentoo.org>
  <trapni@gentoo.org>
  Cédric Krier <cedk@gentoo.org>
  David Shakaryan <omp@gentoo.org>
  Jim Ramsay <lack@gentoo.org>
  Matti Bickel <mabi@gentoo.org>

QA checks for package directory /www-apache/mod_gnutls:
/www-apache/mod_gnutls/mod_gnutls-0.2.0.ebuild
  39: keepdir "${ROOT}"/var/cache/${PN}
herds: apache
maintainer: <trapni@gentoo.org>

QA checks for package directory /www-apache/mod_perl:
/www-apache/mod_perl/mod_perl-2.0.2.ebuild
  29: INSTALLED_MPM="$(${ROOT}/usr/sbin/apxs2 -q MPM_NAME)"
/www-apache/mod_perl/mod_perl-2.0.3.ebuild
  29: INSTALLED_MPM="$(${ROOT}/usr/sbin/apxs2 -q MPM_NAME)"
herds: perl
maintainer: <perl@gentoo.org>

QA checks for package directory /www-servers/monkeyd:
/www-servers/monkeyd/monkeyd-0.9.1.ebuild
  67: [[ -e ${ROOT}/${WEBROOT}/htdocs/index.html ]] && \
herds: www-servers

QA checks for package directory /x11-base/kdrive:
/x11-base/kdrive/kdrive-4.3.0-r5.ebuild
  138: (  [ -e "${ROOT}/usr/src/linux" ] && \
herds: x11

QA checks for package directory /x11-libs/fxscintilla:
/x11-libs/fxscintilla/fxscintilla-1.62-r1.ebuild
  44: --with-foxinclude=${ROOT}usr/include \
  45: --with-foxlib=${ROOT}usr/lib \
  58: --with-foxinclude=${ROOT}usr/include \
  59: --with-foxlib=${ROOT}usr/lib \
/x11-libs/fxscintilla/fxscintilla-1.62-r2.ebuild
  42: --with-foxinclude=${ROOT}usr/include \
  43: --with-foxlib=${ROOT}usr/lib \
/x11-libs/fxscintilla/fxscintilla-1.71.ebuild
  45: --with-foxinclude=${ROOT}usr/include \
  46: --with-foxlib=${ROOT}usr/lib \
  60: --with-foxinclude=${ROOT}usr/include \
  61: --with-foxlib=${ROOT}usr/lib \
  75: --with-foxinclude=${ROOT}usr/include \
herds: no-herd
maintainer: Matti Bickel <mabi@gentoo.org>

QA checks for package directory /x11-libs/qwtplot3d:
/x11-libs/qwtplot3d/qwtplot3d-0.2.6-r2.ebuild
  34: echo >> ${file} "INCLUDEPATH += ${ROOT}usr/include/qwtplot3d"
herds: sci
maintainer: <cryos@gentoo.org>

QA checks for package directory /x11-misc/dmenu:
/x11-misc/dmenu/dmenu-2.1.ebuild
  35: for root in "${PORTAGE_CONFIGROOT}" "${ROOT}" /; do
herds: desktop-misc
maintainer: Cédric Krier <cedk@gentoo.org>
maintainer: David Shakaryan <omp@gentoo.org>

QA checks for package directory /x11-misc/electricsheep:
/x11-misc/electricsheep/electricsheep-2.6.7-r1.ebuild
  70: if [ ! -f "${ROOT}/usr/share/electricsheep/electricsheep-uniqueid" ]
/x11-misc/electricsheep/electricsheep-2.6.8.ebuild
  70: if [ ! -f "${ROOT}/usr/share/electricsheep/electricsheep-uniqueid" ]
herds: no-herd
maintainer: <dragonheart@gentoo.org>

QA checks for package directory /x11-plugins/gkrellsun:
/x11-plugins/gkrellsun/gkrellsun-0.9.1.ebuild
  18: if [ -f ${ROOT}/usr/bin/gkrellm ]
  24: if [ -f ${ROOT}/usr/bin/gkrellm2 ]
  34: if [ -f ${ROOT}/usr/bin/gkrellm ]
  41: if [ -f ${ROOT}/usr/bin/gkrellm2 ]
herds: desktop-dock
maintainer: Jim Ramsay <lack@gentoo.org>

QA checks for package directory /x11-themes/mythtv-themes:
/x11-themes/mythtv-themes/mythtv-themes-0.19.ebuild
  23: ./configure --prefix="${ROOT}"/usr || die "configure died"
/x11-themes/mythtv-themes/mythtv-themes-0.20.ebuild
  23: ./configure --prefix="${ROOT}"/usr || die "configure died"
herds: media-tv
Comment 1 Marcus D. Hanwell (RETIRED) gentoo-dev 2007-02-23 12:09:11 UTC
Looks like it was introduced with qwtplot3d-0.2.6-r2, reverted that line to -r1. That should take care of qwtplot3d - let me know if there are any further problems. Think that is all on here for me or sci so removing us both.
Comment 2 Jim Ramsay (lack) (RETIRED) gentoo-dev 2007-02-23 13:16:10 UTC
As part of my regular cleanup, this version was removed on February 22, 2007.

  x11-plugins/gkrellsun-0.9.1

And so it shall trouble you no more.
Comment 3 Michael Cummings (RETIRED) gentoo-dev 2007-02-23 14:24:45 UTC
perl is no longer r00t3d here.
Comment 4 Matti Bickel (RETIRED) gentoo-dev 2007-02-23 16:28:03 UTC
fxscintilla rootless.
Comment 5 Thilo Bangert (RETIRED) (RETIRED) gentoo-dev 2007-02-23 19:40:46 UTC
www-servers/monkeyd done!
thanks!
Comment 6 Cédric Krier gentoo-dev 2007-02-24 18:00:28 UTC
x11-misc/dmenu done
Comment 7 Luca Longinotti (RETIRED) gentoo-dev 2007-04-11 14:51:26 UTC
www-apache/mod_gnutls done.
Best regards, CHTEKK.
Comment 8 Daniel Black (RETIRED) gentoo-dev 2007-04-14 00:01:50 UTC
x11-misc/electricsheep happy and $ROOTless
Comment 9 Mark Loeser (RETIRED) gentoo-dev 2007-12-31 23:21:09 UTC
Only ones remaining from this list are:

x11-base/kdrive
x11-themes/mythtv-themes
Comment 10 Donnie Berkholz (RETIRED) gentoo-dev 2008-01-11 08:11:29 UTC
kdrive done
Comment 11 Donnie Berkholz (RETIRED) gentoo-dev 2008-01-11 08:15:32 UTC
kdrive done
Comment 12 Christoph Mende (RETIRED) gentoo-dev 2008-12-15 20:03:39 UTC
www-apache/mod_gnutls was already fixed and I just fixed mythtv-themes. QA, I guess this bug can be closed?
Comment 13 Petteri Räty (RETIRED) gentoo-dev 2008-12-16 18:11:51 UTC
(In reply to comment #12)
> www-apache/mod_gnutls was already fixed and I just fixed mythtv-themes. QA, I
> guess this bug can be closed?
> 

Looking at qualudis www-*  x11-* | grep root_variable
there seems to be stuff to fix
Comment 14 Petteri Räty (RETIRED) gentoo-dev 2008-12-16 18:22:10 UTC
web-apps:

www-misc/zoneminder/zoneminder-1.23.3.ebuild:
  [?] root_variable: ROOT abuse in src_compile on line 77: --with-webdir="${ROOT}/var/www/zoneminder/htdocs" \
  [?] root_variable: ROOT abuse in src_compile on line 78: --with-cgidir="${ROOT}/var/www/zoneminder/cgi-bin" \
  [?] root_variable: ROOT abuse in src_install on line 108: dodir "${ROOT}"/var/www/zoneminder/htdocs/${DIR}

voxus:
www-servers/nginx/nginx-0.7.26.ebuild:
  [?] root_variable: ROOT abuse in src_install on line 83: dodir "${ROOT}"/etc/${PN}
  [?] root_variable: ROOT abuse in src_install on line 84: insinto "${ROOT}"/etc/${PN}

x11:
x11-terms/xterm/xterm-237.ebuild:
  [?] root_variable: ROOT abuse in src_compile on line 58: --x-libraries=${ROOT}/usr/lib \

media-tv:

x11-themes/mythtv-themes/mythtv-themes-0.22_alpha18947.ebuild:
  [?] root_variable: ROOT abuse in src_compile on line 17: ./configure --prefix="${ROOT}"/usr || die "configure died"

x11-themes/mythtv-themes-extra/mythtv-themes-extra-0.21_p18657.ebuild:
  [?] root_variable: ROOT abuse in src_compile on line 18: ./configure --prefix="${ROOT}"/usr || die "configure died"

desktop-effects:
x11-wm/compiz/compiz-0.7.8-r1.ebuild:
  [?] root_variable: ROOT abuse in src_prepare on line 83: ln -s "${ROOT}"/usr/share/aclocal/gconf-2.m4 acinclude.m4
Comment 15 Petteri Räty (RETIRED) gentoo-dev 2008-12-18 01:06:43 UTC
(In reply to comment #14)
> 
> x11:
> x11-terms/xterm/xterm-237.ebuild:
>   [?] root_variable: ROOT abuse in src_compile on line 58:
> --x-libraries=${ROOT}/usr/lib \
> 

fixed
Comment 16 Thilo Bangert (RETIRED) (RETIRED) gentoo-dev 2009-02-08 13:01:36 UTC
please open individual bug reports for easier tracking of progress.

all fixed, except zoneminder (bug #258116), nginx (bug #258118), mythtv-themes-extra (bug #258115) and compiz (bug #258114).
please refer to the indvidual reports - thanks.