Bugzilla Bug 166539

The package fails to compile when using the "ffmpeg player" USE flags for it.
The bug occurs due to the invalid casting in files (as far as I can tell).

Reproducible: Always

Steps to Reproduce:
1.USE="ffmpeg player" emerge mpeg4ip (other USE flags are not important, I
think).
Actual Results:  
mpeg4ip fails to compile.

Expected Results:  
mpeg4ip with player and ffmpeg support should have been emerged successfully.

Here is my "emerge --info" output:
Portage 2.1.1-r2 (default-linux/amd64/2006.0, gcc-3.4.6, glibc-2.4-r4,
2.6.18-gentoo-r6 x86_64)
=================================================================
System uname: 2.6.18-gentoo-r6 x86_64 AMD Athlon(tm) 64 X2 Dual Core Processor
3800+
Gentoo Base System release 1.12.8
Last Sync: Fri, 09 Feb 2007 10:50:01 +0000
distcc 2.18.3 x86_64-pc-linux-gnu (protocols 1 and 2) (default port 3632)
[disabled]
app-admin/eselect-compiler: [Not Present]
dev-java/java-config: 1.3.7, 2.0.31
dev-lang/python:     2.4.3-r4
dev-python/pycrypto: 2.0.1-r5
dev-util/ccache:     [Not Present]
dev-util/confcache:  [Not Present]
sys-apps/sandbox:    1.2.17
sys-devel/autoconf:  2.13, 2.61
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2, 1.10
sys-devel/binutils:  2.16.1-r3
sys-devel/gcc-config: 1.3.14
sys-devel/libtool:   1.5.22
virtual/os-headers:  2.6.17-r1
ACCEPT_KEYWORDS="amd64"
AUTOCLEAN="yes"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe -march=k8"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /home/mythtv/ /usr/kde/3.5/env /usr/kde/3.5/share/config
/usr/kde/3.5/shutdown /usr/lib64/mozilla/defaults/pref /usr/share/X11/xkb
/usr/share/config"
CONFIG_PROTECT_MASK="/etc/env.d /etc/env.d/java/ /etc/gconf
/etc/java-config/vms/ /etc/revdep-rebuild /etc/splash /etc/terminfo
/etc/texmf/web2c"
CXXFLAGS="-O2 -pipe -march=k8"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoconfig distlocks metadata-transfer sandbox sfperms strict"
GENTOO_MIRRORS="http://distro.ibiblio.org/pub/linux/distributions/gentoo/
http://mirror.etf.bg.ac.yu/gentoo "
LANG="sr_CS.UTF-8"
LC_ALL="sr_CS.UTF-8"
LINGUAS="en sr sr_CS"
MAKEOPTS="-j1"
PKGDIR="/usr/portage/packages"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress
--force --whole-file --delete --delete-after --stats --timeout=180
--exclude='/distfiles' --exclude='/local' --exclude='/packages'"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://rsync.europe.gentoo.org/gentoo-portage"
USE="amd64 X a52 aac aalib acl acpi afs aim alsa alsa_cards_ali5451
alsa_cards_als4000 alsa_cards_atiixp alsa_cards_atiixp-modem alsa_cards_bt87x
alsa_cards_ca0106 alsa_cards_cmipci alsa_cards_emu10k1x alsa_cards_ens1370
alsa_cards_ens1371 alsa_cards_es1938 alsa_cards_es1968 alsa_cards_fm801
alsa_cards_hda-intel alsa_cards_intel8x0 alsa_cards_intel8x0m
alsa_cards_maestro3 alsa_cards_trident alsa_cards_usb-audio alsa_cards_via82xx
alsa_cards_via82xx-modem alsa_cards_ymfpci alsa_pcm_plugins_adpcm
alsa_pcm_plugins_alaw alsa_pcm_plugins_asym alsa_pcm_plugins_copy
alsa_pcm_plugins_dmix alsa_pcm_plugins_dshare alsa_pcm_plugins_dsnoop
alsa_pcm_plugins_empty alsa_pcm_plugins_extplug alsa_pcm_plugins_file
alsa_pcm_plugins_hooks alsa_pcm_plugins_iec958 alsa_pcm_plugins_ioplug
alsa_pcm_plugins_ladspa alsa_pcm_plugins_lfloat alsa_pcm_plugins_linear
alsa_pcm_plugins_meter alsa_pcm_plugins_mulaw alsa_pcm_plugins_multi
alsa_pcm_plugins_null alsa_pcm_plugins_plug alsa_pcm_plugins_rate
alsa_pcm_plugins_route alsa_pcm_plugins_share alsa_pcm_plugins_shm
alsa_pcm_plugins_softvol apache apache2 apm audiofile bash-completion bcmath
berkdb bidi bitmap-fonts blas bluetooth bonobo bzip2 cairo calendars canna cdb
cddb cdparanoia cdr chasen cjk clamav cli cracklib crypt cups curl curlwrappers
dbus dga directfb dlloader doc dri dv dvb dvd dvdr dvdread eds elibc_glibc
emboss encode examples exif expat fam fbcon ffmpeg fftw firefox flac foomaticdb
fortran freewnn ftp gb gcj gd gif ginac glut gphoto2 gpm gps graphviz gstreamer
gtk gtk2 gtkhtml guile hal iconv icq imagemagick imap imlib
input_devices_keyboard input_devices_mouse ipv6 isdnlog jabber java javascript
joystick jpeg jpeg2k kde kdeenablefinal kernel_linux lcd_devices_bayrad
lcd_devices_cfontz lcd_devices_cfontz633 lcd_devices_glk lcd_devices_hd44780
lcd_devices_lb216 lcd_devices_lcdm001 lcd_devices_mtxorb lcd_devices_ncurses
lcd_devices_text ldap libcaca libg++ libgda libnotify libwww linguas_en
linguas_sr linguas_sr_CS lirc lm_sensors lua lzw lzw-tiff mad matroska midi
mikmod mime mng mono mp3 mpeg mplayer msn mysql mysqli ncurses nls nntp nptl
nsplugin ogg opengl oscar pam pcre pda pdf perl php plotutils png posix pppd
python qt3 qt4 quicktime readline reflection ruby samba sasl scanner sdl
session sharedext simplexml sockets speex spell spl sqlite3 ssl
startup-notification svg szip tcl tcltk tcpd tetex theora threads tidy tiff tk
tokenizer truetype truetype-fonts type1-fonts unicode usb userland_GNU v4l vcd
vhosts video_cards_fbdev video_cards_nvidia video_cards_vesa vorbis wmf
wxwindows x264 xine xinetd xml xorg xpm xv xvid yahoo zlib"
Unset:  CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LDFLAGS,
PORTAGE_RSYNC_EXTRA_OPTS


I have verified that this problem occurs only if you try to compile the package
with USE flags "player ffmpeg" used together. Combination of "player -ffmpeg"
or "-player ffmpeg" works without any problem. I have also verified that this
problem occurs on x86 arch as well.
Problem seems to occur due to invalid casting in files (relative to root of the
unpacked source) "player/plugin/video/ffmpeg/ffmpeg.cpp" and
"player/plugin/audio/ffmpeg/ffmpeg.cpp", on lines 258 and 169, respectively.
Instead of casting to "void *", one should be casting to "uint8_t *". This is
an application bug, obviously, and it should probably be pushed upstream. I
could write a patch to be added to repository which would (hopefully) fix this
issue in Gentoo GNU/Linux portage (since I doubt that the they will release
repaired source codes for this version of software, since it is not the newest
one). I haven't tested the newer versions of this software (which are masked as
testing for my arch).

This is the topmost relevant output of the emerge in which the error occurs.
Sorry for not including it in the first post.

 x86_64-pc-linux-gnu-g++ -DHAVE_CONFIG_H -I. -I. -I../../../..
-I../../../../player/src -I../../../../player/lib -I../../../../include
-I../../../../lib -I../../../../lib/mp4av -I../../../../lib/mp4v2
-I../../../../lib/sdp -D_REENTRANT -DNOCONTROLS -fexceptions -Wall
-Wno-char-subscripts -Woverloaded-virtual -Wno-unknown-pragmas -Wno-deprecated
-Wformat=2 -Wpointer-arith -Wsign-compare -O2 -pipe -march=k8 -DMPEG4IP
-I/usr/include/SDL -D_GNU_SOURCE=1 -D_REENTRANT -MT ffmpeg.lo -MD -MP -MF
.deps/ffmpeg.Tpo -c ffmpeg.cpp  -fPIC -DPIC -o .libs/ffmpeg.o
ffmpeg.cpp: In function `codec_data_t* ffmpeg_create(const char*, const char*,
int, int, format_list_t*, audio_info_t*, const uint8_t*, uint32_t,
audio_vft_t*, void*)':
ffmpeg.cpp:169: error: invalid conversion from `void*' to `uint8_t*'
make[5]: *** [ffmpeg.lo] Error 1
make[5]: Leaving directory
`/var/tmp/portage/mpeg4ip-1.4.1/work/mpeg4ip-1.4.1/player/plugin/audio/ffmpeg'
make[4]: *** [all-recursive] Error 1
make[4]: Leaving directory
`/var/tmp/portage/mpeg4ip-1.4.1/work/mpeg4ip-1.4.1/player/plugin/audio'
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory
`/var/tmp/portage/mpeg4ip-1.4.1/work/mpeg4ip-1.4.1/player/plugin'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory
`/var/tmp/portage/mpeg4ip-1.4.1/work/mpeg4ip-1.4.1/player'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/var/tmp/portage/mpeg4ip-1.4.1/work/mpeg4ip-1.4.1'
make: *** [all] Error 2

!!! ERROR: media-video/mpeg4ip-1.4.1 failed.
Call stack:
  ebuild.sh, line 1546:   Called dyn_compile
  ebuild.sh, line 937:   Called src_compile
  mpeg4ip-1.4.1.ebuild, line 116:   Called die

!!! make failed
!!! If you need support, post the topmost build error, and the call stack if
relevant.

Try w/ 1.5.0.1-r1 please.

(In reply to comment #2)
> Try w/ 1.5.0.1-r1 please.
I have successfully emerged this version (it pulled 2 new masked packages,
though). The old version, of course, still won't compile.

(In reply to comment #3)
> (In reply to comment #2)
> > Try w/ 1.5.0.1-r1 please.
> I have successfully emerged this version

Thanks for reporting back. Arches, please stabilize something that actually
compiles.

Yes please stabilize, thank you.

(In reply to comment #5)
> Yes please stabilize, thank you.
> 

that's gonna mean stabling these too:

media-libs/libmp4v2-1.5.0.1
>=media-libs/faac-1.24-r2

any objections from sound team?

No objection here.

removing sound and x86 stable

amd64 stable

ppc stable

ppc done.