Bug 166500 – app-admin/conky-1.4.5 - USE="-X" has no effect

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Anthony Brown 2007-02-12 14:18:30 UTC]

I use conky with X11 disabled in order to be able to send its output to stdout. After upgrading to conky-1.4.5 setting the "-X" USE flag seems to have no effect anymore. It looks like the ebuild assumed --enable-X11 by default.

I have the "-X" flag set in package.use and also tried so set it directly on the command-line but "conky -v" always gives:

Conky 1.4.5 compiled Mon Feb 12 15:01:49 MET 2007 for Linux 2.6.18-gentoo-r6 (x86_64)

Compiled in features:

 X11:
  * Xdamage extension
  * Xdbe extension (double buffer)
  * xft

 Music detection:

 General features:

[Comment 1 Philip Kovacs 2007-02-20 17:01:48 UTC]

Created attachment 110736 [details]
app-admin/conky-1.4.5-r1.ebuild

The attached ebuild revision corrects the problem.  With -X, we were not
explicitly disabling X, but rather falling back to auto-detection.

-X will now strictly disable X and associated items.

Since this ebuild may build a different binary with no change in USE flags,
I am bumping it to -r1.  I believe that is the prescribed policy.

ebuild diff follows.

[Comment 2 Philip Kovacs 2007-02-20 17:03:28 UTC]

Created attachment 110737 [details]
conky-1.4.5-r1.ebuild

cvs header cleared.

[Comment 3 Philip Kovacs 2007-02-20 17:05:54 UTC]

Created attachment 110739 [details, diff]
conky-1.4.5-r1.ebuild.diff

Daniel,

Note I also removed --enable-proc-uptime which has no effect.

Phil

[Comment 4 Philip Kovacs 2007-02-20 17:17:13 UTC]

Created attachment 110740 [details]
app-admin/conky-1.4.5-r1.ebuild

putting --enable-proc-uptime back in, sry.  i pulled this in a later version.

[Comment 5 Philip Kovacs 2007-02-20 17:17:44 UTC]

Created attachment 110741 [details, diff]
app-admin/conky-1.4.5-r1.ebuild.diff

[Comment 6 Brenden Matthews 2007-02-25 05:24:07 UTC]

Created attachment 111163 [details]
app-admin/conky-1.4.5-r1.ebuild

I wanted to try and sneak this in...its the same as the patch from Philip plus I removed the runtime dep for mpd, since it is not necessary.

[Comment 7 Brenden Matthews 2007-02-25 05:24:24 UTC]

Created attachment 111165 [details, diff]
app-admin/conky-1.4.5-r1.ebuild.diff

[Comment 8 Philip Kovacs 2007-02-25 20:09:37 UTC]

I believe you can make the same claim for removing the RDEPEND on hddtemp.

In both cases, the USE flags (mpd or hddtemp) configure conky for use with the respective package, however it is not *strictly* necessary for either package to be installed in order to use conky.  If you do configure for either one, however, the related conky variables are "dead" without the associated runtime package.

Phil

[Comment 9 Anthony Brown 2007-03-01 14:52:10 UTC]

I've now tested the new ebuild and it does what I need. X11 support is not included now (when setting the -X USE variable) and conky then works the way I want it to.

Thanks!

When will the new ebuild appear in the portage tree?

Anthony

[Comment 10 Daniel Black (RETIRED) 2007-03-08 12:07:24 UTC]

*** Bug 169595 has been marked as a duplicate of this bug. ***

[Comment 11 Daniel Black (RETIRED) 2007-03-08 12:36:08 UTC]

Thanks Anthony, Brenden and Philip and Pavel.

Pavel - realized bug 169595 wasn't quite a dup but i did fix it.

Philip - wrt a version bump - tough call.
Though its a new binary I'm guessing most users use it in a X mode. I didn't want these users doing a recompile for no real benefit.
Weak argument but strictly speaking you're probably right with policy. I'm just bending it slightly.

[Comment 12 Pavel Denisov 2007-03-08 15:46:15 UTC]

Confirmed fixed. Its already in the portage! Great job, guys!