Bugzilla Bug 166401

As per summary:

c++ -o nsType1.o -c -DOSTYPE=\"Linux2.6\" -DOSARCH=\"Linux\"
-DHAVE_DEPENDENT_LIBS -I../.. -I./..  -I../../../dist/include/xpcom
-I../../../dist/includ
e/string -I../../../dist/include/widget -I../../../dist/include/pref
-I../../../dist/include/caps -I../../../dist/include/locale
-I../../../dist/includ
e/uconv -I../../../dist/include/view -I../../../dist/include/necko
-I../../../dist/include/imglib2 -I../../../dist/include/unicharutil
-I../../../dist/
include/gfx -I../../../dist/include
-I/var/tmp/portage/app-editors/nvu-1.0-r4/work/mozilla/dist/include/nspr    
-I. -I/usr/include/freetype2    -fPIC
  -fno-rtti -fno-exceptions -Wall -Wconversion -Wpointer-arith -Wcast-align
-Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -
Wno-long-long -pipe -fshort-wchar -pthread -pipe  -DNDEBUG -DTRIMMED -O2
-I/usr/include/gtk-2.0 -I/usr/lib64/gtk-2.0/include -I/usr/include/atk-1.0 -I/
usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/glib-2.0
-I/usr/lib64/glib-2.0/include     -DMOZILLA_CLIENT -include
../../../mozilla-config.
h -Wp,-MD,.deps/nsType1.pp nsType1.cpp
nsType1.cpp:371: error: invalid conversion from 'int (*)(FT_Vector*, void*)' to
'int (*)(const FT_Vector*, void*)'
nsType1.cpp:371: error: invalid conversion from 'int (*)(FT_Vector*, void*)' to
'int (*)(const FT_Vector*, void*)'
nsType1.cpp:371: error: invalid conversion from 'int (*)(FT_Vector*,
FT_Vector*, void*)' to 'int (*)(const FT_Vector*, const FT_Vector*, void*)'
nsType1.cpp:371: error: invalid conversion from 'int (*)(FT_Vector*,
FT_Vector*, FT_Vector*, void*)' to 'int (*)(const FT_Vector*, const FT_Vector*,
co
nst FT_Vector*, void*)'
gmake[5]: *** [nsType1.o] Error 1
gmake[5]: Leaving directory
`/var/tmp/portage/app-editors/nvu-1.0-r4/work/mozilla/gfx/src/ps'
gmake[4]: *** [libs] Error 2
gmake[4]: Leaving directory
`/var/tmp/portage/app-editors/nvu-1.0-r4/work/mozilla/gfx/src'
gmake[3]: *** [libs] Error 2
gmake[3]: Leaving directory
`/var/tmp/portage/app-editors/nvu-1.0-r4/work/mozilla/gfx'
gmake[2]: *** [tier_9] Error 2
gmake[2]: Leaving directory
`/var/tmp/portage/app-editors/nvu-1.0-r4/work/mozilla'
make[1]: *** [default] Error 2
make[1]: Leaving directory
`/var/tmp/portage/app-editors/nvu-1.0-r4/work/mozilla'
make: *** [build] Error 2

I am also seeing this problem.

Portage 2.1.2-r9 (default-linux/x86/2006.1/desktop, gcc-4.1.1, glibc-2.5-r0,
2.6.17.13-reiser4-3 i686)
=================================================================
System uname: 2.6.17.13-reiser4-3 i686 AMD Athlon(TM) XP 1800+
Gentoo Base System release 1.12.9
Timestamp of tree: Sun, 11 Feb 2007 17:50:01 +0000
distcc 2.18.3 i686-pc-linux-gnu (protocols 1 and 2) (default port 3632)
[enabled]
ccache version 2.4 [enabled]
dev-java/java-config: 1.3.7, 2.0.31-r3
dev-lang/python:     2.3.6, 2.4.4
dev-python/pycrypto: 2.0.1-r5
dev-util/ccache:     2.4-r6
sys-apps/sandbox:    1.2.18.1
sys-devel/autoconf:  2.13, 2.61
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2, 1.10
sys-devel/binutils:  2.17
sys-devel/gcc-config: 1.3.14
sys-devel/libtool:   1.5.22
virtual/os-headers:  2.6.20
ACCEPT_KEYWORDS="x86 ~x86"
AUTOCLEAN="yes"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-O2 -march=athlon-xp -pipe"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/3.5/env /usr/kde/3.5/share/config
/usr/kde/3.5/shutdown /usr/share/X11/xkb /usr/share/config /var/bind"
CONFIG_PROTECT_MASK="/etc/env.d /etc/env.d/java/ /etc/gconf
/etc/java-config/vms/ /etc/revdep-rebuild /etc/terminfo"
CXXFLAGS="-O2 -march=athlon-xp -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoconfig ccache collision-protect distcc distlocks
metadata-transfer parallel-fetch sandbox sfperms strict"
GENTOO_MIRRORS="http://gentoo.chem.wisc.edu/gentoo/
ftp://gentoo.chem.wisc.edu/gentoo/ ftp://gentoo.mirrors.tds.net/gentoo
http://mirror.datapipe.net/gentoo"
LINGUAS="en"
MAKEOPTS="-j7"
PKGDIR="/usr/portage/packages"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress
--force --whole-file --delete --delete-after --stats --timeout=180
--exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://rsync.namerica.gentoo.org/gentoo-portage"
USE="3dnow X alsa am berkdb bitmap-fonts bzip2 cairo cdr chroot cli cracklib
crypt dbus dlloader dri dv dvd dvdr eds emboss encode fam firefox fortran gdbm
gif gnome gpm gstreamer gtk gtk2 hal iconv isdnlog jpeg kde kdeenablefinal
libg++ mad midi mikmod mmx mp3 mpeg ncurses nls nptl nptlonly ogg oggvorbis
opengl oss pam pcre pdflib perl png ppds pppd pwdb python qt3 qt4 quicktime
readline reflection sdl session spell spl sse ssl tiff truetype truetype-fonts
type1-fonts udev unicode vorbis win32codecs x86 xml xorg xv zlib"
ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1
emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m
maestro3 trident usb-audio via82xx via82xx-modem ymfpci"
ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file
hooks iec958 ioplug ladspa lfloat linear meter mulaw multi null plug rate route
share shm softvol" ELIBC="glibc" INPUT_DEVICES="keyboard mouse" KERNEL="linux"
LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses
text" LINGUAS="en" USERLAND="GNU" VIDEO_CARDS="nv"
Unset:  CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LANG, LC_ALL, LDFLAGS,
PORTAGE_RSYNC_EXTRA_OPTS

And just to make sure: this is a build-time issue, so please fix it in a way
that works with both 2.1 and 2.2/2.3, and don't revbump the ebuild, so that we
don't need a new stable to mark new freetype stable too.

Created an attachment (id=109897) [details]
nsType1.cpp has some const-correctness issues. this patch fixes it

(In reply to comment #3)
> Created an attachment (id=109897) [edit] [details]
> nsType1.cpp has some const-correctness issues. this patch fixes it
> 

With that patch applied, it fails to build with freetype <2.2. Need to say that
this patch is supplied by freetype upstream.

Diego, i think in this case we need to do a rev-bump, and modify the dep of
freetype to >2.1, and apply the patch. We'll need to stabilize it just before
freetype-2.2 hits stable.

Or make the patch work with both freetype. I'm not an expert, so a patch is
welcomed.

You have two choices: make the patch use preprocessor #ifs depending on the
version of Freetype being used or apply the patch conditionally depending on
has_version results.

Please do not revbump this as it's not really needed to be revbumped.

Fixed, thanks.