Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 165294 - www-servers/webfs: bug in /etc/init.d/webfs
Summary: www-servers/webfs: bug in /etc/init.d/webfs
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Server (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: www-servers Herd (OBSOLETE)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-02-04 16:52 UTC by Norberto Bensa
Modified: 2009-09-30 11:12 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch for /usr/portage/www-servers/webfs/files/webfs.initd (webfs.initd.patch,829 bytes, patch)
2007-02-04 16:55 UTC, Norberto Bensa
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Norberto Bensa 2007-02-04 16:52:42 UTC
As you can see, there's a bug in /etc/init.d/webfs. The log option is never added to WEBFS_LOG because of a typo:

[[ -n "${WEBFS_LOG}" ]] && WEBF_OPTS="${WEBFS_OPTS} -l ${WEBFS_LOG}"
                           ^^^^^^^^^

And while you're at it, change -l to -L which flushes with every request. From man webfsd:

       -l log Log all requests to the logfile >log< (common log format).
       Using "-" as filename makes webfsd print the access log to stdout, 
       which is only useful together with the -F switch (see below).

       -L log Same  as  above,  but additional flush every line.  Useful
       if you want monitor the logfile with tail -f.


Thanks and best regards,
Norberto
Comment 1 Jakub Moc (RETIRED) gentoo-dev 2007-02-04 16:54:40 UTC
We might even fix it if you post the ebuild name... :)
Comment 2 Norberto Bensa 2007-02-04 16:55:17 UTC
Created attachment 109145 [details, diff]
Patch for /usr/portage/www-servers/webfs/files/webfs.initd
Comment 3 Norberto Bensa 2007-02-04 16:57:02 UTC
You're waaay to fast jakub :)

The ebuild is 
/usr/portage/www-servers/webfs/webfs-1.21.ebuild

But just patching files/webfs.initd is enough
Comment 4 Norberto Bensa 2007-02-04 17:00:20 UTC
Added patch. Reopen bug
Comment 5 Jakub Moc (RETIRED) gentoo-dev 2007-02-04 17:09:03 UTC
Thanks. :)
Comment 6 Thilo Bangert (RETIRED) (RETIRED) gentoo-dev 2007-02-28 22:57:18 UTC
fixed in cvs.
thanks for the report!
Comment 7 Pavel Raykov 2009-09-30 11:07:37 UTC
Hello guys!

The problem surfaced again :(

# ps ax | grep webfsd
# /etc/init.d/webfs start
webfs           |* Caching service dependencies...   [ ok ]
webfs           |* Starting webfsd...                [ ok ]
# ps ax | grep webfsd
 4630 ?        Ss     0:00 /usr/bin/webfsd -p 80 -f index.html -t 30 -c 3 -u web -g web -r /opt/www/localhost/ -L /var/log/webfsd.log -c 10 -n localhost -j
# /etc/init.d/webfs stop
webfs           |* Stopping webfsd...                [ ok ]

but the daemon is still running:

 # ps ax | grep webfsd
 4630 ?        Ss     0:00 /usr/bin/webfsd -p 80 -f index.html -t 30 -c 3 -u web -g web -r /files/www/localhost/ -L /var/log/webfsd.log -c 10 -n rabbit.avp.ru -j

I use the latest webfs package:
# equery l webfs
 * Searching for webfs ...
[IP-] [  ] www-servers/webfs-1.21-r1 (0)

Regards,
Pavel Raykov
Comment 8 Pavel Raykov 2009-09-30 11:12:01 UTC
(In reply to comment #7)

> but the daemon is still running:
> 
>  # ps ax | grep webfsd
>  4630 ?        Ss     0:00 /usr/bin/webfsd -p 80 -f index.html -t 30 -c 3 -u
> web -g web -r /files/www/localhost/ -L /var/log/webfsd.log -c 10 -n
> rabbit.avp.ru -j

oops, a was forget to hide my options, please read text above as:

but the daemon is still running:

 # ps ax | grep webfsd
 4630 ?        Ss     0:00 /usr/bin/webfsd -p 80 -f index.html -t 30 -c 3 -u web -g web -r /opt/www/localhost/ -L /var/log/webfsd.log -c 10 -n localhost -j

;]

Regards,
Pavel Raykov