Bug List: (This bug is not in your last search results)   Show last search results      Search page      Enter new bug
Bug#: 164588
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Vim Maintainers <vim@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Marc Finet <m.dreadlock@gmail.com>
Add CC:
CC:
Remove selected CCs
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
make-conf.diff Add CAMERAS patch Marc Finet 2007-01-30 19:04 0000 1.67 KB Details | Diff
use-desc.diff Add + and . in package names patch Marc Finet 2007-01-30 19:05 0000 769 bytes Details | Diff
make-conf.diff Add CAMERAS patch Marc Finet 2007-01-30 19:07 0000 1.67 KB Details | Diff
use-desc.diff Add + and . in package names patch Marc Finet 2007-01-30 19:07 0000 769 bytes Details | Diff
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 164588 depends on: Show dependency tree
Bug 164588 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug


Description:   Opened: 2007-01-30 19:03 0000
make.conf is missing the new CAMERAS
use.desc is missing + and . in the package names.


Reproducible: Always

------- Comment #1 From Marc Finet 2007-01-30 19:04:16 0000 -------
Created an attachment (id=108644) [details]
Add CAMERAS

------- Comment #2 From Marc Finet 2007-01-30 19:05:14 0000 -------
Created an attachment (id=108646) [details]
Add + and . in package names

------- Comment #3 From Marc Finet 2007-01-30 19:07:05 0000 -------
Created an attachment (id=108650) [details]
Add CAMERAS

------- Comment #4 From Marc Finet 2007-01-30 19:07:32 0000 -------
Created an attachment (id=108651) [details]
Add + and . in package names

------- Comment #5 From Mike Kelly (RETIRED) 2007-01-30 19:56:41 0000 -------
(In reply to comment #3)
> Created an attachment (id=108650) [edit] [details]
> Add CAMERAS

I don't think I'll add this patch. If you can come up with a patch that
dynamically works on all variables in USE_EXPAND, I'll use it. Otherwise, I
don't think this is a good idea.

------- Comment #6 From Harald van Dijk 2007-01-31 07:02:53 0000 -------
(In reply to comment #5)
> I don't think I'll add this patch. If you can come up with a patch that
> dynamically works on all variables in USE_EXPAND, I'll use it. Otherwise, I
> don't think this is a good idea.

Does it have to find them all at runtime, or would you be happy with a patch
that gets all USE_EXPAND variables when gentoo-syntax is merged? The former is
not reasonably possible, but the latter shouldn't be much of a problem.

------- Comment #7 From Mike Kelly (RETIRED) 2007-02-12 15:07:53 0000 -------
Hmm, after further discussion w/ some vim folks, doing it dynamically isn't
reasonable (too slow at runtime, folks won't have it up-to-date if it's done at
install time). I've just applied your USE_EXPAND patch to svn, r24.

------- Comment #8 From Mike Kelly (RETIRED) 2007-02-12 15:17:11 0000 -------
Your other patch is not correct. You patched the line for what characters are
allowed in a USE flag name, not the line for what is allowed in a package name.

------- Comment #9 From Mike Kelly (RETIRED) 2007-02-12 15:45:50 0000 -------
I've fixed gentoo-use-desc.vim properly in svn, r25 and r26.

This will all be in the next release of gentoo-syntax (probably later tonight).

------- Comment #10 From Mike Kelly (RETIRED) 2007-02-13 04:47:34 0000 -------
Fixed in 20070212 release, which should hit mirrors in a few hours.

Bug List: (This bug is not in your last search results)   Show last search results      Search page      Enter new bug