Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 164240 - x11-base/xorg-server: emerge fails on alpha with sys-kernel/linux-headers-2.6.19.2-r1 (and probably some older versions as well)
Summary: x11-base/xorg-server: emerge fails on alpha with sys-kernel/linux-headers-2.6...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: Alpha Linux
: High normal (vote)
Assignee: Gentoo X packagers
URL:
Whiteboard:
Keywords: Inclusion
Depends on:
Blocks: sane-linux-headers
  Show dependency tree
 
Reported: 2007-01-28 14:46 UTC by Stefaan De Roeck (RETIRED)
Modified: 2007-08-01 22:19 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
patch that should fix the system-header problems (alpha-includes.patch,838 bytes, patch)
2007-01-28 14:47 UTC, Stefaan De Roeck (RETIRED) 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stefaan De Roeck (RETIRED) gentoo-dev 2007-01-28 14:46:04 UTC 
Tested on a ~alpha box, x11-base/xorg-server-1.2.0, sys-kernel/linux-headers-2.6.19.2-r1.  

Problem is missing <asm/pci.h> in newer linux-headers.  
Judging by the source of x11-base/xorg-server-1.1.1-r4, older versions will probably fail as well.  

This include is only done in code specific to alpha on linux.  

Will attach a patch that I hope fixes the problem in a clean way.  I hope someone can test it in combination with an older linux-headers version.  

Possibly related to bug #152655.
Comment 1 Stefaan De Roeck (RETIRED) gentoo-dev 2007-01-28 14:47:53 UTC 
Created attachment 108370 [details, diff]
patch that should fix the system-header problems

I hope someone can test this with an older sys-kernel/linux-headers version.
Comment 2 Joshua Baergen (RETIRED) gentoo-dev 2007-01-28 22:34:08 UTC 
This is probably something that should be filed at https://bugs.freedesktop.org as well.
Comment 3 Donnie Berkholz (RETIRED) gentoo-dev 2007-05-02 07:39:31 UTC 
Does this remain an issue with 1.3?
Comment 4 Raúl Porcel (RETIRED) gentoo-dev 2007-07-02 18:29:44 UTC 
with older linux-headers version? 1.2 and 1.1 compiled fine with linux-headers-2.6.11-r2
Comment 5 Jose Luis Rivero (yoswink) (RETIRED) gentoo-dev 2007-07-17 17:35:26 UTC 
(In reply to comment #3)
> Does this remain an issue with 1.3?
> 

Yup. Problem is the new sanitized kernel headers (>=2.6.19 in the tree) which don't include <asm/pci.h> anymore.

The patch seems sane to me.

@Stefaan: did you check if the patch work against non-sanitized headers (current alpha stable)? If so, please submit the bug to freedesktop. If don't, I can give it a try.

Thanks!
Comment 6 Stefaan De Roeck (RETIRED) gentoo-dev 2007-07-18 12:18:27 UTC 
> @Stefaan: did you check if the patch work against non-sanitized headers
> (current alpha stable)? If so, please submit the bug to freedesktop. If don't,
> I can give it a try.

I've just tried it on my stable box.
Portage 2.1.2.9 (default-linux/alpha/2006.1/server, gcc-4.1.2, glibc-2.3.6-r5, 2.6.19-gentoo-r5 alpha), virtual/os-headers:  2.6.11-r4
and it builds fine.  

Created bug https://bugs.freedesktop.org/show_bug.cgi?id=11648
Comment 7 Stefaan De Roeck (RETIRED) gentoo-dev 2007-07-31 22:24:50 UTC 
The patch (or at least an alternate version of it) has been committed upstream.  I however have no clue of when it will appear in a release.  As the patch is quite straightforward, small, and harmless...

I want to pop up the question: could we apply this patch in the ebuild until it appears in a release?
Comment 8 Donnie Berkholz (RETIRED) gentoo-dev 2007-07-31 22:57:43 UTC 
Yes, will get to it soon.
Comment 9 Donnie Berkholz (RETIRED) gentoo-dev 2007-08-01 22:19:48 UTC 
Just committed to 1.3.0.0, thanks for your patience!