Bugzilla Bug 16403

There are two issues I see with ntp-4.1.1b-r4.ebuild:

First, it doesn't use the doc USE variable for the html files that are installed
in /usr/share/doc/ntp-4.1.1b-r4/html.

Second, this code from the ebuild is broken:

    insinto /usr/share/ntp
    doins scripts/* ${FILESDIR}/ntp.conf

because it results in this:

/usr/share/ntp/Makefile
/usr/share/ntp/Makefile.am
/usr/share/ntp/Makefile.in
/usr/share/ntp/README
/usr/share/ntp/calc_tickadj
/usr/share/ntp/calc_tickadj.in
/usr/share/ntp/checktime
/usr/share/ntp/checktime.in
/usr/share/ntp/fixautomakedepsmagic
/usr/share/ntp/freq_adj
/usr/share/ntp/freq_adj.in
/usr/share/ntp/hpadjtime.sh
/usr/share/ntp/mkver
/usr/share/ntp/mkver.in
/usr/share/ntp/ntp-close
/usr/share/ntp/ntp-groper
/usr/share/ntp/ntp-restart
/usr/share/ntp/ntp-status
/usr/share/ntp/ntp-wait
/usr/share/ntp/ntp-wait.in
/usr/share/ntp/ntpsweep
/usr/share/ntp/ntpsweep.in
/usr/share/ntp/ntpver
/usr/share/ntp/ntpver.in
/usr/share/ntp/plot_summary
/usr/share/ntp/plot_summary.in
/usr/share/ntp/summary
/usr/share/ntp/summary.in
/usr/share/ntp/ntp.conf

Note the presence of the .in files and the various Makefiles.  Ugly.

Reproducible: Always
Steps to Reproduce:
1. emerge ntp
2. qpkg -l ntp

Actual Results:  
shows the html files and the ugliness in /usr/share/ntp

Expected Results:  
no html files for me and just the scripts in /usr/share ntp

Portage 2.0.47-r4 (default-1.0, gcc-2.95.3, glibc-2.2.5-r2,2.2.5-r7)
=================================================================
System uname: 2.4.19-gentoo-r7 i586 Pentium MMX
GENTOO_MIRRORS="http://csociety-ftp.ecn.purdue.edu/pub/gentoo
http://gentoo.oregonstate.edu/
http://www.ibiblio.org/pub/Linux/distributions/gentoo"
CONFIG_PROTECT="/etc /var/qmail/control /usr/share/config
/usr/kde/2/share/config /usr/kde/3/share/config /usr/X11R6/lib/X11/xkb"
CONFIG_PROTECT_MASK="/etc/bash_completion /etc/sound/events /etc/X11/rstart
/etc/X11/xdm /etc/pango /etc/gconf /etc/env.d"
PORTDIR="/usr/portage"
DISTDIR="/usr/portage/distfiles"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR_OVERLAY="/usr/local/portage"
USE="x86 oss 3dnow apm avi crypt cups encode jpeg libg++ mikmod mmx mpeg ncurses
pdflib qtmt sdl spell truetype xml2 xmms xv berkdb esd gdbm gif gnome gnome-libs
gtk guile java libwww oggvorbis opengl pam perl png python readline slang snmp
ssl tcpd tetex tiff X -doc -quicktime -svga -motif -nls -imlib -kde -qt -arts
gpm mozilla"
COMPILER=""
CHOST="i586-pc-linux-gnu"
CFLAGS="-march=i586 -O3 -pipe"
CXXFLAGS="-march=i586 -O3 -pipe"
ACCEPT_KEYWORDS="x86"
MAKEOPTS="-j2"
AUTOCLEAN="yes"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
FEATURES="sandbox ccache userpriv"

(1) we will not check for doc USE inside an ebuild because we'd be doing it in 
just about every single ebuild we have ...
yeah, we have over 3000 ebuilds ...

(2) doc is for 'extra documentation' ... usually defined as documentation that is
generated by extra utilities or something ...

fixed in cvs, thanks for the heads up

http://cvs.gentoo.org/cgi-bin/viewcvs.cgi/gentoo-x86/net-misc/ntp/ntp-4.1.1b-r5.ebuild?rev=1.1&content-type=text/vnd.viewcvs-markup