Bug 163613 – x11-proto/damageproto-1.1.0 & x11-libs/libXdamage-1.1 should be masked

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Todd Merrill 2007-01-24 15:56:31 UTC]

x11-proto/damageproto-1.1.0 and x11-libs/libXdamage-1.1 should be hard masked.  

These versions add reporting of damage by DRI drivers.  No official Portage tree version of xorg-server or mesa support this.  Only recent git snapshots (as of 6 January) can take advantage of them.

Building a git master version of mesa against damageproto-1.1.0 and libXdamage-1.1 will lead to errors like this when running some GL applications on an X server that does not support damage reporting:

X Error of failed request:  BadRequest (invalid request code or no such operation)
  Major opcode of failed request:  156 (DAMAGE)
  Minor opcode of failed request:  4 ()
  Serial number of failed request:  37
  Current serial number in output stream:  38

My suggestion; mask them and revive x11-libs/libXdamage-1.0.4.

Reproducible: Always

Steps to Reproduce:

[Comment 1 Samuli Suominen (RETIRED) 2007-01-24 16:23:31 UTC]

Portage has xorg-server-1.2.0 in ~arch, I believe that is more new than those git snapshots you just mentioned.. in fact, it's prolly server for upcoming X.org 7.2 more or less.

[Comment 2 Todd Merrill 2007-01-24 16:35:15 UTC]

(In reply to comment #1)
> Portage has xorg-server-1.2.0 in ~arch, I believe that is more new than those
> git snapshots you just mentioned.. in fact, it's prolly server for upcoming
> X.org 7.2 more or less.

xorg-server-1.2.0 does not support damage reporting.  It has only been merged into the 1.2.99 series.

http://gitweb.freedesktop.org/?p=xorg/xserver.git;a=commit;h=0b73a7eb17fd848c6bdc6a65ba835aa2cbfc3cfd

For reference, the xorg-server-1.2.99.0 snapshot is dated 1 November 2006.

[Comment 3 Donnie Berkholz (RETIRED) 2007-01-24 19:36:10 UTC]

Let me get this straight. You're saying it should be masked because it is broken with git snapshots of mesa and otherwise does nothing?

[Comment 4 Todd Merrill 2007-01-24 19:54:06 UTC]

(In reply to comment #3)
> Let me get this straight. You're saying it should be masked because it is
> broken with git snapshots of mesa and otherwise does nothing?

Basically, yes.

This problem will crop up when Mesa 6.5.3 is released and MESA_PV is bumped, at least for xorg-server-1.2.0.

[Comment 5 Todd Merrill 2007-01-25 19:27:59 UTC]

The >=x11-libs/libXdamage-1.1 dependency in x11-base/xorg-x11-7.2 is incorrect.

[Comment 6 Todd Merrill 2007-02-01 20:41:23 UTC]

No, I'm not crazy.

http://gitweb.freedesktop.org/?p=xorg/xserver.git;a=commit;h=8274ea6aa97b06a56b7468c3908894c0ff72b687

[Comment 7 Donnie Berkholz (RETIRED) 2007-02-01 21:06:55 UTC]

(In reply to comment #6)
> No, I'm not crazy.

I know, because I reported that to Anholt.

[Comment 8 wbrana 2007-02-09 21:11:30 UTC]

I have got same error. Mesa git works after downgrade of damageproto and libXdamage. 

[Comment 9 Donnie Berkholz (RETIRED) 2007-02-09 21:19:15 UTC]

We should do a revbump of xorg-server 1.2.0 to add that patch.

[Comment 10 Todd Merrill 2007-02-09 21:31:32 UTC]

(In reply to comment #9)
> We should do a revbump of xorg-server 1.2.0 to add that patch.

I agree.

As an aside, damage tracking has been merged into the git server-1.2-branch, so it should be in the next 1.2 release.

[Comment 11 Joshua Baergen (RETIRED) 2007-02-10 18:53:23 UTC]

(In reply to comment #6)
> http://gitweb.freedesktop.org/?p=xorg/xserver.git;a=commit;h=8274ea6aa97b06a56b7468c3908894c0ff72b687
> 

Is there a 1.2 counterpart to this commit?  This is the mainline version (not that it would be a stretch to edit it, mind you...).

[Comment 12 Joshua Baergen (RETIRED) 2007-02-17 17:44:42 UTC]

Hmm, looks like there won't be a patch for 1.2 now.  I can only assume that the 1.3 server will arrive before Mesa 6.5.3...

[Comment 13 Joshua Baergen (RETIRED) 2007-02-19 21:35:15 UTC]

Fixed in 1.2.0-r1.  I patched the server to report damage version 1.0 instead of the protocol header version.