Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 162975 - sys-apps/irqbalance-0.55 - tests in the start-up script are overkill
Summary: sys-apps/irqbalance-0.55 - tests in the start-up script are overkill
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: AMD64 Linux
: High minor (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-01-20 20:57 UTC by J.Taimr
Modified: 2007-01-21 19:06 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description J.Taimr 2007-01-20 20:57:48 UTC
The tests for uniproc and dualcore-hyperthreading processors in the start-up stript of irqbalance (/etc/init.d/irqbalance) seem to be far too excessive.
a)The uniproc/dual-core-hyperthreading processor tests are present in the code already:
-----
       /* On single core UP systems irqbalance obviously has no work to do */
        if (core_count<2)
                exit(EXIT_SUCCESS);
        /* On dual core/hyperthreading shared cache systems just do a one shot setup */
        if (cache_domain_count==1)
                one_shot_mode = 1;
-----
(irqbalance.c, line 73)
b)this test exclude AMD64X2 processors; as far as I know, these processors have not shared cache, but separated ones.

Reproducible: Always

Steps to Reproduce:
1.Try start irqbalance on AMD64X2 system via /etc/init.d/irqbalance script
2.it will not start, because of dual-core processor
3.try start irqbalance in the debug mode manually - it seems to be working prefectly



Expected Results:  
It should be possible to start irqbalance on AMD64X2 systems, equipped by processors with separated caches (i.e. 939Toledo e.t.c).
Comment 1 SpanKY gentoo-dev 2007-01-21 19:06:43 UTC
incvs