Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 162841 - dos2unix -> edos2unix conversion
Summary: dos2unix -> edos2unix conversion
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-01-19 19:32 UTC by Christian Ludwig
Modified: 2007-03-31 19:28 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Ludwig 2007-01-19 19:32:28 UTC
Grepping in the current portage tree reveals that there are some programs using "dos2unix" without RDEPEND'ing on it. So they mainly use it in the ebuild itself. Since there is an edos2unix function in current stable portage available, using this and dumping the dos2unix DEPEND would be nice.

I did not verify, if dos2unix definitely isn't used by the programs. It would be nice to clarify this.

The following packages are affected:
net-mail/gml-0.5
games-board/freedoko-0.7.3
media-video/vstrip-0.8f


Reproducible: Always

Steps to Reproduce:
1. find /usr/portage -name "*.ebuild" -exec egrep -H "(unix|dos)2(dos|unix)" {} \; | grep -v edos2unix
2. use your eyes on the results.
Actual Results:  
./net-mail/gml/gml-0.5.ebuild:  app-text/dos2unix"
./net-mail/gml/gml-0.5.ebuild:  dos2unix -o gmlw.py
./games-board/freedoko/freedoko-0.7.3.ebuild:   app-text/dos2unix"
./games-board/freedoko/freedoko-0.7.3.ebuild:   dos2unix ${S}/src/Makefile.rules
./media-video/vstrip/vstrip-0.8f.ebuild:DEPEND="app-text/dos2unix
./media-video/vstrip/vstrip-0.8f.ebuild:        dos2unix -q -o *.c *.h

[and some irrelevant ones]


Expected Results:  
Not the ones mentioned above.
Comment 1 Jakub Moc (RETIRED) gentoo-dev 2007-01-19 21:12:40 UTC
(In reply to comment #0)
> Grepping in the current portage tree reveals that there are some programs using
> "dos2unix" without RDEPEND'ing on it. 

Why should they RDEPEND on it? It's not a runtime dependency at all; the deps are just fine...
Comment 2 Charlie Shepherd (RETIRED) gentoo-dev 2007-01-19 21:55:06 UTC
(In reply to comment #0)
> Grepping in the current portage tree reveals that there are some programs using
> "dos2unix" without RDEPEND'ing on it. So they mainly use it in the ebuild
> itself. Since there is an edos2unix function in current stable portage
> available, using this and dumping the dos2unix DEPEND would be nice.

dos2unix is a function in eutils.eclass, not a package.... 
Comment 3 Jakub Moc (RETIRED) gentoo-dev 2007-01-19 22:27:04 UTC
(In reply to comment #2)
> dos2unix is a function in eutils.eclass, not a package.... 

Nope, that's edos2unix :) 

Comment 4 Mr. Bones. (RETIRED) gentoo-dev 2007-01-19 22:29:44 UTC
freedoko fixed.
Comment 5 Charlie Shepherd (RETIRED) gentoo-dev 2007-01-19 23:01:07 UTC
(In reply to comment #3)
> (In reply to comment #2)
> > dos2unix is a function in eutils.eclass, not a package.... 
> 
> Nope, that's edos2unix :) 
 
:( i guess i'll just go and be quiet over here then...
Comment 6 Andrej Kacian (RETIRED) gentoo-dev 2007-01-19 23:02:18 UTC
gml fixed
Comment 7 Samuli Suominen (RETIRED) gentoo-dev 2007-03-31 19:28:11 UTC
media-video/vstrip converted to edos2unix.. the package is borqued in many different ways, it was least of it's worries.