Bugzilla Bug 162080

gentoo needs high dynamic range photography tools
pfstools, pfscalibration and pfstmo provides such tools:
http://www.mpi-inf.mpg.de/resources/pfstools


Reproducible: Always

Created an attachment (id=106968) [details]
pfstools ebuild

Created an attachment (id=106969) [details]
pfscalibration ebuild

Created an attachment (id=106971) [details]
pfstmo ebuild

pfstmo is for converting HDR images to LDR (low dynamic range pot, like jpeg
for printing for example)

Created an attachment (id=106972) [details]
pfstmo front-end ebuild

Created an attachment (id=106973) [details]
patch for pfscalibration

Solve the problem that appears if locale is not set so that numerical seperator
is "." like in french locales.

Created an attachment (id=113921) [details]
qtpfsgui-1.8.2.ebuild

Here is an ebuild for qtpfsgui, which is a Qt4 frontend for pfs*. I'm not sure
if the dependencies in the ebuild are correct.

qtpfsgui-1.8.2.ebuild is missing a non-version-specific dependency on
media-gfx/exiv2.  With that dependency added, I can confirm that qtpfsgui
installs the correct dependencies and functions correctly.  It's a great
program.

Created an attachment (id=114225) [details]
new version of qtpfsgui with exiv2 in the dependences

Alost the same ebuild as the las one.
Just the new version of qtpfsgui with exiv2 in the dependences an some
modifications :
adjusted the homepage
replaced qtpfsgui by ${PN}
modified the SRC_URI to:
SRC_URI="mirror://sourceforge/${PN}/${P}.tgz"

Created an attachment (id=114816) [details]
ebuild for qtpfsgui-1.8.3

Here is an ebuild for qtpfsgui-1.8.3

It adds the desktop file, icon, and HTML documentation.

Created an attachment (id=132260) [details]
ebuild for pfstools-1.6.2

I added useflags for all the various features, so that they may be
enabled/disabled independently.

Created an attachment (id=132269) [details]
ebuild for media-gfx/qtpfsgui-1.8.12

Latests version of qtpfsgui.  Tested and working.

Created an attachment (id=132270) [details]
ebuild for media-libs/pfstmo-1.1

This ebuild works for pfstmo-1.1.

This is only to let you all know that I was able to install and run
successfully pfstools, pfstmo and qtpfsgui on my Gentoo 64bit by adding ~amd64
to the keywords.

FYI: I added media-gfx/qtpfsgui-1.9.0 to the tree.

I did my last update like this
emerge -uDav world
emerge -v depclean
revdep-rebuild -pv

And it resulted in an error when compiling pfstools-1.6.2 (looks like I'm
missing a lib ?):

if i686-pc-linux-gnu-g++ -DHAVE_CONFIG_H -I. -I. -I../.. -I./../pfs -pthread
-I/usr/include/OpenEXR       -O2  -march=pentium-m -pipe -fomit-frame-pointer
-MT ppmio.o -MD -MP -MF ".deps/ppmio.Tpo" \
          -c -o ppmio.o `test -f 'ppmio.cpp' || echo './'`ppmio.cpp; \
        then mv -f ".deps/ppmio.Tpo" ".deps/ppmio.Po"; \
        else rm -f ".deps/ppmio.Tpo"; exit 1; \
        fi
ppmio.cpp:31:18: erreur: ppm.h : Aucun fichier ou répertoire de ce type
ppmio.cpp:38: erreur: ‘pixval’ does not name a type
ppmio.cpp: In constructor ‘PPMReader::PPMReader(FILE*)’:
ppmio.cpp:53: erreur: ‘struct PPMData’ has no member named ‘maxPV’
ppmio.cpp:53: erreur: ‘ppm_readppminit’ was not declared in this scope
ppmio.cpp: In member function ‘bool PPMReader::is8bitdata()’:
ppmio.cpp:58: erreur: ‘struct PPMData’ has no member named ‘maxPV’
ppmio.cpp: In member function ‘void PPMReader::readImage(pfs::Array2D*,
pfs::Array2D*, pfs::Array2D*)’:
ppmio.cpp:63: erreur: ‘pixel’ was not declared in this scope
ppmio.cpp:63: erreur: ‘ppmRow’ was not declared in this scope
ppmio.cpp:64: erreur: ‘ppm_allocrow’ was not declared in this scope
ppmio.cpp:71: erreur: ‘struct PPMData’ has no member named ‘maxPV’
ppmio.cpp:71: erreur: ‘ppm_readppmrow’ was not declared in this scope
ppmio.cpp:78: erreur: ‘PPM_GETR’ was not declared in this scope
ppmio.cpp:79: erreur: ‘PPM_GETG’ was not declared in this scope
ppmio.cpp:80: erreur: ‘PPM_GETB’ was not declared in this scope
ppmio.cpp:84: erreur: ‘PPM_GETR’ was not declared in this scope
ppmio.cpp:85: erreur: ‘PPM_GETG’ was not declared in this scope
ppmio.cpp:86: erreur: ‘PPM_GETB’ was not declared in this scope
ppmio.cpp:90: erreur: ‘ppm_freerow’ was not declared in this scope
ppmio.cpp: In member function ‘void PPMWriter::writeImage(pfs::Array2D*,
pfs::Array2D*, pfs::Array2D*)’:
ppmio.cpp:103: erreur: ‘pixel’ was not declared in this scope
ppmio.cpp:103: erreur: ‘ppmRow’ was not declared in this scope
ppmio.cpp:106: erreur: ‘ppm_allocrow’ was not declared in this scope
ppmio.cpp:109: erreur: ‘ppm_writeppminit’ was not declared in this scope
ppmio.cpp:115: erreur: ‘pixval’ was not declared in this scope
ppmio.cpp:117: erreur: ‘PPM_ASSIGN’ was not declared in this scope
ppmio.cpp:119: erreur: ‘ppm_writeppmrow’ was not declared in this scope
ppmio.cpp:122: erreur: ‘ppm_freerow’ was not declared in this scope
make[3]: *** [ppmio.o] Erreur 1

It looks like I'm facing the same problem as was found with
subtitleripper-0.3.4-r2 that does not compile fine with netpbm 10.41.0 that put
ppm.h in /usr/include/netpbm/ instead of /usr/include for version 10.40.0, see
bug 210435 : http://bugs.gentoo.org/show_bug.cgi?id=210435

I produced a new ebuild for pfstools that warn that pfstools does compile with
netpbm flag if netpbm version is >=10.41.0 and die. The ebuild allows to
compile without pbm.

I had a small problem with a colision with some "octave-type" pfstools file but
I guess this was due to the previous manual installation of pfstools that looks
like is not very safe and installed some files out of the prefix choosen
(/opt/pfstools).

Created an attachment (id=146966) [details]
improved ebuild for pfstools-1.6.2

improved ebuild allowing to enable or not features and warn user about pfstools
compilation difficulty when netpbm version is >=10.41.0

Created an attachment (id=149133) [details]
Version bump to 1.6.4

Only a slight modification of the 1.6.2-r2 ebuild. Added ~amd64. Added a matlab
use flag (that enables / disables matlab script creation). Also applies a patch
(submitted upstream already) for building the matlab scripts on 64-bit
platforms.

Created an attachment (id=149136) [details]
Patch fixing compile / installation of matlab scripts on non x86 platforms.

Created an attachment (id=159584) [details]
Updated dependencies of media-gfx/pfscalibration

I think all these packages should be in category media-gfx, since they are
command line tools and not libraries.

Created an attachment (id=159585) [details]
Version bump to media-gfx/pfstmo-1.3

Created an attachment (id=159587) [details]
Version bump to media-gfx/pfstools-1.6.5

Created an attachment (id=159588) [details]
Fixes building of pfstools-1.6.5 against >=media-libs/netpbm-10.41.0

Created an attachment (id=164295) [details]
Minor updates to media-gfx/pfstools-1.6.5

Added ~amd64 keyword. Changed emake to force -j1 which was causing matlab
scripts not to compile correctly.

Created an attachment (id=164297) [details]
Added ~amd64 keyword to pfstmo-1.3 ebuild.

Created an attachment (id=165048) [details]
Version bump of media-gfx/pfstmo to version 1.3.2

Created an attachment (id=165050) [details]
Version bump of media-gfx/pfscalibration to version 1.4

pfstools is now at 1.7.0. version bumping 1.6.5-r1 seems to work okay.

So what is preventing pfstools from going to the tree?

(In reply to comment #29)
> So what is preventing pfstools from going to the tree?
> 

Prolly the fact that you're not yet a developer so you could add and maintain
it ;-)

Created an attachment (id=209680) [details]
last pfstools ebuild

working.

Created an attachment (id=209682) [details]
pfscalibration-1.4.ebuild

Created an attachment (id=209683) [details]
pfstmo-1.4.ebuild (mantiuk08 not working)

mantiuk08 operator still not working, so i had to delete the " || die" commands
to compile phase. Other operators works fine.

Created an attachment (id=210153) [details]
Improved ebuild, dependencies

I'm posting new ebuild, based on Carlo's work. Few things remain unresolved,
namely pre-stripped octave modules and matlab and qt support.

Created an attachment (id=210157) [details]
Improved ebuild

Improved ebuild, based on Carlo's work. Included hard dependency on fftw:3.0
and patch for mantiuk08

Created an attachment (id=210158) [details]
Patch for the ebuild

this patch is too stupid, but anyway...

Created an attachment (id=210160) [details]
Yet improved ebuild

Corrected few own mistakes.

Created an attachment (id=212113) [details]
Fix for gcc-4.4 / glibc 2.11 

I had this error with pfstools on gcc-4.4.2

pfspanoramic.cpp: In static member function ‘static Projection*
ProjectionFactory::getProjection(const char*)’:
pfspanoramic.cpp:198: error: invalid conversion from ‘const char*’ to
‘char*’

Created an attachment (id=212116) [details]
Apply fix

Modified Wojciech's ebuild to apply the patch.