Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 160302 - Evolution needs dependancy changes and checks for GnuPG-2.0 support
Summary: Evolution needs dependancy changes and checks for GnuPG-2.0 support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GNOME (show other bugs)
Hardware: All Linux
: High major (vote)
Assignee: GNOME Office (OBSOLETE)
URL:
Whiteboard:
Keywords:
: 161846 (view as bug list)
Depends on:
Blocks: 159505
  Show dependency tree
 
Reported: 2007-01-05 11:17 UTC by Robin Johnson
Modified: 2007-10-13 22:40 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
evolution-gnupg-2.0-support.patch (evolution-gnupg-2.0-support.patch,3.52 KB, patch)
2007-01-05 11:17 UTC, Robin Johnson
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2007-01-05 11:17:21 UTC
For supporting GnuPG-2.0, the Evolution ebuilds need some minor changes.

In the attached patch:
DEPEND on '=gnupg-1.4*' OR '>=gnupg-2.0.1-r2'

If gnupg-2.0* is used, app-crypt/pinentry must be built with qt3 or gtk support.

See bug 159590 for more information, as marduk raised the issue there.
Comment 1 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2007-01-05 11:17:53 UTC
Created attachment 105553 [details, diff]
evolution-gnupg-2.0-support.patch
Comment 2 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2007-01-05 11:19:05 UTC
oops, wrong number for the other bug.
Comment 3 Alon Bar-Lev (RETIRED) gentoo-dev 2007-01-19 14:04:43 UTC
GNOME:
Hello,
Is there a problem in the patch?
If there is no, can you please apply/close this bug?
Thanks!
Comment 4 Gilles Dartiguelongue (RETIRED) gentoo-dev 2007-01-19 14:20:11 UTC
patch looks fine to me
Comment 5 Mart Raudsepp gentoo-dev 2007-02-08 11:52:41 UTC
(In reply to comment #3)
> GNOME:
> Hello,
> Is there a problem in the patch?

emerge -vp pinentry:
[ebuild   R   ] app-crypt/pinentry-0.7.2-r3  USE="ncurses qt3 -caps -gtk" 0 kB 

emerge evolution:
!!! ERROR: mail-client/evolution-2.8.3 failed.
Call stack:
  ebuild.sh, line 1630:   Called dyn_setup
  ebuild.sh, line 702:   Called qa_call 'pkg_setup'
  ebuild.sh, line 38:   Called pkg_setup
  evolution-2.8.3.ebuild, line 90:   Called die

!!! You must build app-crypt/pinentry with GTK or QT support
!!! If you need support, post the topmost build error, and the call stack if relevant.
!!! A complete build log is located at '/var/tmp/portage/mail-client/evolution-2.8.3/temp/build.log'.
Comment 6 Mart Raudsepp gentoo-dev 2007-02-08 12:15:14 UTC
So the problem is of course misunderstanding of bash boolean operators with the return codes from built_with_use:

command1 || command2
  command2 is executed if and only if command1 returns a non-zero exit status.

command1 && command2
  command2 is executed if, and only if, command1 returns an exit status of zero.

Anyhow, instead of making this confusing by using built_with_use && built_with_use, I used the OR check that the built_with_use function supports:

Usage: built_with_use [--missing <action>] [-a|-o] <DEPEND ATOM> <List of USE flags>
Flags: -a             all USE flags should be utilized
       -o             at least one USE flag should be utilized
       --missing  peform the specified action if the flag is not in IUSE (true/false/die)

So in evolution-2.8.3 it simply reads:
if ! built_with_use -o app-crypt/pinentry gtk qt3; then

This has been tested with all possibly combinations of gtk and qt3 USE flags on pinentry and confirmed to work as soon as at least one of gtk or qt3 USE flag is active.

I also made the message say QT3 instead of QT.

With gnupg-2.0.2 evolution starts using 100% CPU while the pinentry dialog is shown - it polls like crazy for a return value. I'm not sure if this problem did or didn't exist with gnupg-1.4 as I've always in the past entered the password quickly without paying attention to CPU utilization.

I will commit evolution-2.8.3 version bump immediately with this pinentry/gnupg USE flag fix included. I did not touch the earlier stable versions, at least not yet.
Comment 7 William Keaney 2007-02-14 02:11:10 UTC
*** Bug 161846 has been marked as a duplicate of this bug. ***
Comment 8 Gilles Dartiguelongue (RETIRED) gentoo-dev 2007-09-08 17:49:03 UTC
should that bug be considered fixed ?
Comment 9 Gilles Dartiguelongue (RETIRED) gentoo-dev 2007-10-13 22:40:42 UTC
looks like it's fixed so closing.