Bug 159736 – java-config-2 doesn't hava a csh equivalent of /etc/profile.d/java-config-2.sh

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Troy Bowman 2007-01-02 10:34:46 UTC]

I run tcsh out of preference, and java-config-2 doesn't seem to install an equivalent csh script for /etc/profile.d/java-config-2.sh, so my shell never properly gains the java environment variables that get set up using preferennces set by eselect or java-config-2.

[Comment 1 Troy Bowman 2007-01-02 10:37:38 UTC]

Created attachment 105189 [details]
a csh equivalent

I've attached a csh equivalent, /etc/profile.d/java-config-2.csh, which could be used to be a part of the java-config-2 to provide csh compatibility.

[Comment 2 Petteri Räty (RETIRED) 2007-01-12 17:57:51 UTC]

+*java-config-2.0.31-r1 (12 Jan 2007)
+
+  12 Jan 2007; Petteri Räty <[e-mail]>
+  -files/java-config-2.profiled, +files/java-config-2.profiled.csh,
+  +files/java-config-2.profiled.sh, +java-config-2.0.31-r1.ebuild:
+  Added /etc/profile.d/ file for c shells. Fixes bug #159736. Thanks to Troy
+  Bowman <[e-mail]>.
+

Thanks.

[Comment 3 Alexander Puchmayr 2007-01-13 10:56:39 UTC]

It seems as if somebody forgot to add this change in the ebuild-file as well.

I got error

[...]
cp: cannot stat `/usr/portage/dev-java/java-config/files/java-config-2.profiled': No such file or directory
[...]

/usr/portage/dev-java/java-config/java-config-2.0.30.ebuild, line 40

Replace
        newexe ${FILESDIR}/${PN}-${SLOT}.profiled ${PN}-${SLOT}.sh || die "newexe failed"

with
        newexe ${FILESDIR}/${PN}-${SLOT}.profiled.sh ${PN}-${SLOT}.sh || die "newexe failed"

then it emerges fine.

[Comment 4 Petteri Räty (RETIRED) 2007-01-13 12:30:02 UTC]

(In reply to comment #3)
> It seems as if somebody forgot to add this change in the ebuild-file as well.
> 

Well it means I broke the 2.0.31 version. Why would you want to install an older revision any way? Fixing it.

[Comment 5 Vlastimil Babka (Caster) (RETIRED) 2007-01-13 12:36:35 UTC]

(In reply to comment #4)
> Well it means I broke the 2.0.31 version. Why would you want to install an
> older revision any way? Fixing it.

Look closely, comment 3 is about 2.0.30 which is current stable :)
Fixed.

[Comment 6 Petteri Räty (RETIRED) 2007-01-13 12:44:32 UTC]

(In reply to comment #5)
> (In reply to comment #4)
> > Well it means I broke the 2.0.31 version. Why would you want to install an
> > older revision any way? Fixing it.
> 
> Look closely, comment 3 is about 2.0.30 which is current stable :)
> Fixed.
> 

Uups. Sorry about that.

[Comment 7 Bernhard Sonderegger 2007-01-13 14:58:40 UTC]

In dev-java/java-config-2.0.31-r1:2 there appears to be a bug in "/etc/profile.d/java-config-2.csh" (see attachment "a csh equivalent")

the following line causes an "if syntax" error and halts script execution:

      else if (-L $gentoo_system_vm) then

I believe the "-L" should be "-l". Is this correct?

In any case, it prevents tcsh from ever reaching my login scripts when it starts up.

[Comment 8 Petteri Räty (RETIRED) 2007-01-13 16:36:36 UTC]

Fixed. This bug is present for root only it seems. Teaches you to always remember to test user contributed stuff as best as you can. If the bug prevented you from logging in I think you should file a bug for tcsh as I think it would be better for it to let you login at least.

[Comment 9 Dan Foster 2007-01-14 04:57:15 UTC]

*** Bug 161983 has been marked as a duplicate of this bug. ***

[Comment 10 Bernhard Sonderegger 2007-01-17 09:20:10 UTC]

Petteri,

Thanks for fixing.

As for your comment about a tcsh bug: It let me login. The problem was that my login scripts (.cshrc etc.) were not run. I believe this is unavoidable behaviour for a shell. If a script has a syntax error, it's execution stops.

Cheers,

Bernhard