Bugzilla Bug 159454

I ran emerge --depclean --ask which unmerged gsf-sharp among other packages. I
ran revdep-rebuild and it reported no packages to rebuild. But beagled stopped
working and printed error message that gsf-sharp is missing. The problem
disappeared when I re-emerged app-misc/beagle.

IMO some message should be added to gsf-sharp ebuild (when it is unmerged)
about possible need of re-emerging some packages depending on it, like beagle.

I set severity to minor, because the problem causes beagle to stop working and
an easy workaround is present (re-emerging beagle).

Post the output of emerge -pv beagle, please... This is just wrong, see
http://www.gentoo.org/proj/en/qa/automagic.xml

$ emerge -pv app-misc/beagle # stripped unneeded output
[ebuild   R   ] app-misc/beagle-0.2.14  USE="pdf python thunderbird -chm -debug
-doc -evo -galago -gtk -ole" 0 kB

i'm still not getting the point. I added gst# dependency for beagle 0.1.13
because there was a bug on the makefiles but the issue was fixed for 0.1.14 so
only with OLE use it will use it. So you don't need gsf# if you don't have
USE=ole.

metalgod: you are right that gsf is not needed with USE="-ole" and
beagle-0.2.14. That's why emerge --depclean removed it.

Now we have the issue: gsf-sharp was needed earlier, when I had beagle-0.2.13.
At the time I upgraded to 0.2.14 gsf-sharp was not needed, but beagle's
configure script detected presence of gsf-sharp and enabled support/dependency
for it (automagic dependency).

When I removed gsf-sharp the problem appeared: support for gsf-sharp was
enabled even when USE="-ole" was set.

Created an attachment (id=104999) [edit]
Patch against beagle's configure.in

I made a little patch that fixes the automagic dependency on gsf-sharp in
beagle's configure.in. I am not sure whether this patch is 100% correct (though
it fixes the problem for me). After applying the patch eautoreconf should
probably be called.

(In reply to comment #5)
> Created an attachment (id=104999) [edit]
> Patch against beagle's configure.in

23:08:33 <@jakub> Flameeyes: can you check this one, please?
http://bugs.gentoo.org/attachment.cgi?id=104999&action=view 
23:09:07 <@Flameeyes> sounds pretty much broken to me                           
23:09:29 <@Flameeyes> a) there's no AC_HELP_STRING to comment the
AC_ARG_ENABLE, and upstream probably won't accept that
23:09:37 <@Flameeyes> [remember: gentoo patches has to be upstreamable as much
as we can]
23:09:50 <@Flameeyes> b) the enable_gsf_sharp is unneeded, as it's already set  
23:10:11 <@Flameeyes> c) the PKG_CHECK_MODULES should only happen if the
support was requested   

Look at the configure flag for evo-sharp as an example as how it should be done
(it's ugly, but this is autoconf we're dealing with!)

Created an attachment (id=105028) [edit]
Updated patch

Thanks for your review.

> a) there's no AC_HELP_STRING

Fixed.

> b) the enable_gsf_sharp is unneeded, as it's already set  

I don't understand this one, so I don't know whether it's fixed in the updated
patch or not.

> c) the PKG_CHECK_MODULES should only happen if the support was requested 

Fixed.  

can you open an upstream bug and cc us too please ? The patch looks good but
i'm not sure if upstream will accept due gsf-sharp job.

(In reply to comment #9)
> can you open an upstream bug and cc us too please ? The patch looks good but
> i'm not sure if upstream will accept due gsf-sharp job.

OK, opened bug report http://bugzilla.gnome.org/show_bug.cgi?id=396906

CC-ed you and dsd.

Upstream accepted the patch. Now we only have to wait for new version of
beagle.

Added dependency on version bump bug (I assume this was the right thing to do).
When beagle is bumped, this bug can be resolved as fixed.

this bug can be closed because the fix is in 0.2.15.1 now you'll have USE="ole"
enables gsf-sharp

Thanks for helping.