First Last Prev Next    No search results available      Search page      Enter new bug
Bug#: 159399
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Alon Bar-Lev (RETIRED) <alonbl@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Stefan Becker <schtefan@gmx.net>
Add CC:
CC:
Remove selected CCs
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
hibernate-script-1.94-855resolution.patch restart instead of start patch Stefan Becker 2006-12-29 10:46 0000 2.23 KB Details | Diff
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 159399 depends on: Show dependency tree
Bug 159399 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug


Description:   Opened: 2006-12-29 10:45 0000
/etc/init.d/855resolution has to be restarted instead of just started see bug
http://bugs.gentoo.org/show_bug.cgi?id=141204 for details). Patch applied.

------- Comment #1 From Stefan Becker 2006-12-29 10:46:38 0000 -------
Created an attachment (id=104945) [edit]
/etc/init.d/855resolution has to be restarted instead of just started in order
to work (for me)

------- Comment #2 From Alon Bar-Lev (RETIRED) 2006-12-30 02:32:51 0000 -------
Thanks!
Added.
Next time, please submit only your modifications, it will be easier to apply.

------- Comment #3 From Santiago Gala 2006-12-30 05:56:19 0000 -------
Not sure why the patch changes i915resolution, when there is a 915resolution
ebuild (that I need and is ~amd64) in addition to 855resolution.

I think unifying both ebuilds would make sense, and have this unified tweak
called in the script, rather than fight if the options should be for 855 or
915/945*/965 chips (I have a 945GM).

------- Comment #4 From Stefan Becker 2006-12-30 14:41:30 0000 -------
I think 915resolution is not in portage that long, is it? Because I could only
find 855resolution when I proposed the patch originally. 915resolution seems
newer (more maintained?), probably makes 855resolution obsolete. Both won't be
needed much longer quoting 915's homepage http://www.geocities.com/stomljen/ :

"Using 915resolution from within an Xserver 915resolution is going to be
incorporated into the i810 driver from X.org. It should be in an upcoming
release. This will void the need to run 915resolution manually."

Let's hope this will work with hibernation smoothly.

------- Comment #5 From Daniel Drake 2006-12-30 15:03:03 0000 -------
Actually, I think the put-915resolution-inside-i810-driver patches were
rejected, because future versions of i810 will not use the video BIOS at all
(like Windows). Either way, these apps wont be required at some point in the
near future.

------- Comment #6 From Alon Bar-Lev (RETIRED) 2006-12-30 23:25:57 0000 -------
OK.
I will drop the patch of 915->855 so people with start using 915 (Original
requirement from upstream).

------- Comment #7 From Stefan Becker 2006-12-31 04:28:41 0000 -------
Not so fast! You still need a little bit of patching, because the init.d-script
in gentoo is called "/etc/init.d/915resolution", not
"/etc/init.d/i915resolution", and it also has to be "restarted" instead of just
started. But for 915 you only need to patch this one line in
"/usr/share/hibernate/scriptlets.d/hardware_tweaks", right. 915resolution works
just as fine as 855resolution for me.

Be it as it may, I think all this whole thing really does can be replaced by a
one-liner in /etc/hibernate/common.conf:

OnResume 98 /etc/init.d/855resolution restart

-or-

OnResume 98 /etc/init.d/915resolution restart

Maybe it's not worth the patch. But it's better to have an option in the config
file that works rather than one that pretends to do what you want.

------- Comment #8 From Alon Bar-Lev (RETIRED) 2006-12-31 10:27:31 0000 -------
Done.
Please check.

------- Comment #9 From Alon Bar-Lev (RETIRED) 2006-12-31 10:29:25 0000 -------
Patrick, I will open a new bug for treecleaner to remove 855resolution.

------- Comment #10 From Stefan Becker 2007-01-03 01:52:56 0000 -------
(In reply to comment #8)
> Done.
> Please check.
> 

Works fine for me, thanks.

First Last Prev Next    No search results available      Search page      Enter new bug