Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 159399 - sys-power/hibernate-script-1.94-r1 and 855resolution
Summary: sys-power/hibernate-script-1.94-r1 and 855resolution
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High minor (vote)
Assignee: Alon Bar-Lev (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-12-29 10:45 UTC by Stefan Becker
Modified: 2007-01-03 01:52 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
restart instead of start (hibernate-script-1.94-855resolution.patch,2.23 KB, patch)
2006-12-29 10:46 UTC, Stefan Becker
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Becker 2006-12-29 10:45:19 UTC
/etc/init.d/855resolution has to be restarted instead of just started see bug
http://bugs.gentoo.org/show_bug.cgi?id=141204 for details). Patch applied.
Comment 1 Stefan Becker 2006-12-29 10:46:38 UTC
Created attachment 104945 [details, diff]
restart instead of start
Comment 2 Alon Bar-Lev (RETIRED) gentoo-dev 2006-12-30 02:32:51 UTC
Thanks!
Added.
Next time, please submit only your modifications, it will be easier to apply.
Comment 3 Santiago Gala 2006-12-30 05:56:19 UTC
Not sure why the patch changes i915resolution, when there is a 915resolution ebuild (that I need and is ~amd64) in addition to 855resolution.

I think unifying both ebuilds would make sense, and have this unified tweak called in the script, rather than fight if the options should be for 855 or 915/945*/965 chips (I have a 945GM).
Comment 4 Stefan Becker 2006-12-30 14:41:30 UTC
I think 915resolution is not in portage that long, is it? Because I could only find 855resolution when I proposed the patch originally. 915resolution seems newer (more maintained?), probably makes 855resolution obsolete. Both won't be needed much longer quoting 915's homepage http://www.geocities.com/stomljen/ :

"Using 915resolution from within an Xserver 915resolution is going to be incorporated into the i810 driver from X.org. It should be in an upcoming release. This will void the need to run 915resolution manually."

Let's hope this will work with hibernation smoothly.
Comment 5 Daniel Drake (RETIRED) gentoo-dev 2006-12-30 15:03:03 UTC
Actually, I think the put-915resolution-inside-i810-driver patches were rejected, because future versions of i810 will not use the video BIOS at all (like Windows). Either way, these apps wont be required at some point in the near future.
Comment 6 Alon Bar-Lev (RETIRED) gentoo-dev 2006-12-30 23:25:57 UTC
OK.
I will drop the patch of 915->855 so people with start using 915 (Original requirement from upstream).
Comment 7 Stefan Becker 2006-12-31 04:28:41 UTC
Not so fast! You still need a little bit of patching, because the init.d-script in gentoo is called "/etc/init.d/915resolution", not "/etc/init.d/i915resolution", and it also has to be "restarted" instead of just started. But for 915 you only need to patch this one line in "/usr/share/hibernate/scriptlets.d/hardware_tweaks", right. 915resolution works just as fine as 855resolution for me.

Be it as it may, I think all this whole thing really does can be replaced by a one-liner in /etc/hibernate/common.conf:

OnResume 98 /etc/init.d/855resolution restart

-or-

OnResume 98 /etc/init.d/915resolution restart

Maybe it's not worth the patch. But it's better to have an option in the config file that works rather than one that pretends to do what you want.
Comment 8 Alon Bar-Lev (RETIRED) gentoo-dev 2006-12-31 10:27:31 UTC
Done.
Please check.
Comment 9 Alon Bar-Lev (RETIRED) gentoo-dev 2006-12-31 10:29:25 UTC
Patrick, I will open a new bug for treecleaner to remove 855resolution.
Comment 10 Stefan Becker 2007-01-03 01:52:56 UTC
(In reply to comment #8)
> Done.
> Please check.
> 

Works fine for me, thanks.