First Last Prev Next    No search results available      Search page      Enter new bug
Bug#: 159051
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Gunnar Wrobel <wrobel@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Harrison Metzger <harrisonmetz@gmail.com>
Add CC:
CC:
Remove selected CCs
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
fix_ret.diff Patch to check return codes of sync patch Harrison Metzger 2006-12-25 08:34 0000 679 bytes Details | Diff
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 159051 depends on: Show dependency tree
Bug 159051 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug

Description:   Opened: 2006-12-24 20:22 0000 
When syncing an overlay with layman 1.0.8 to a server that was going slow, I
ctrl+c out of it but it claimed success. Here is the output:

* Running command "/usr/bin/svn update "/usr/portage/local/layman/initng""...
svn: PROPFIND request failed on '/portage/gentoo'
svn: PROPFIND of '/portage/gentoo': could not connect to server
(https://svn.initng.org)
*
* Success:
* ------
*
* Successfully synchronized overlay "initng".

Perhaps layman does not check the return status of SVN?

------- Comment #1 From Harrison Metzger 2006-12-24 20:26:26 0000 ------- 
*** Bug 159052 has been marked as a duplicate of this bug. ***

------- Comment #2 From Andrew Gaffney 2006-12-24 20:51:07 0000 ------- 
If I'm reading the code correct, layman doesn't seem to check the return code
of any call to sync(), even though the return code is sent back by
overlay.cmd()'s call to os.system(). Patches are welcome ;)

------- Comment #3 From Harrison Metzger 2006-12-24 22:08:14 0000 ------- 
Yep. I see that on line 182 of db.py in
/usr/lib/python2.4/site-packages/layman.
I don't know python but let me read a tutorial and see if i can solve this.

------- Comment #4 From Harrison Metzger 2006-12-25 08:34:33 0000 ------- 
Created an attachment (id=104712) [details]
Patch to check return codes of sync

Very small patch to db.py in /usr/lib/python2.4/site-packages/layman/. All it
does is check the return code and if its non 0. I looked and all, svn, rsync,
and cvs code all use the cmd to execute their sync command, so it should work
for all of them. I patched mine and its working fine.

------- Comment #5 From Gunnar Wrobel 2006-12-30 08:15:53 0000 ------- 
Fixed in layman-1.0.9. The new version was added to my overlay
(http://overlays.gentoo.org/dev/wrobel) and will be moved to the overlay soon.

Thanks for the patch.
First Last Prev Next    No search results available      Search page      Enter new bug