157786 – sys-fs/dosfstools: do NOT ignore user CFLAGS

Bug 157786 - sys-fs/dosfstools: do NOT ignore user CFLAGS

Summary: sys-fs/dosfstools: do NOT ignore user CFLAGS

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	New packages (show other bugs)
Hardware:	All Linux

Importance:	High normal (vote)
Assignee:	Gentoo's Team for Core System packages

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2006-12-10 18:10 UTC by Diego Elio Pettenò (RETIRED)
Modified:	2006-12-13 21:47 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
Ebuild patch (dosfstools-cflags-ebuild.patch,944 bytes, patch) 2006-12-10 18:10 UTC, Diego Elio Pettenò (RETIRED)	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Diego Elio Pettenò (RETIRED) gentoo-dev

2006-12-10 18:10:27 UTC

Ignoring entirely user's CFLAGS is not a good practice, as the user might be trying to use -ggdb, or a specific needed -march value.

The attached patch copes with the optimisations problem by using strip-flags and then appending the largefile cflags as they are used already by the package, to maintain the behaviour.

This patch is incremental to bug #157785.

HTH,
Diego

Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev

2006-12-10 18:10:46 UTC

Created attachment 103774 [details, diff]
Ebuild patch

Comment 2 SpanKY gentoo-dev

2006-12-13 21:47:14 UTC

fixed in cvs