First Last Prev Next    No search results available      Search page      Enter new bug
Bug#: 157752
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Diego E. 'Flameeyes' Pettenò <flameeyes@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Grant McDorman <grmcdorman@gmail.com>
Add CC:
CC:
Remove selected CCs
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
patch Backport of Amarok SVN fixes for MTP charset problems patch Grant McDorman 2006-12-10 12:42 0000 3.84 KB Details | Diff
patch Unified diff version of patch patch Grant McDorman 2006-12-10 16:52 0000 2.71 KB Details | Diff
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 157752 depends on: Show dependency tree
Show dependency graph
Bug 157752 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug


Description:   Opened: 2006-12-10 11:44 0000
When transferring tracks to a media device [MP3 player] with non-ASCII
characters - i.e. characters outside of the 0-FF standard ASCII range - Amarok
will either create incorrect strings or fail to transfer the affected file.

Similarly, in the list of device tracks, strings containing these characters do
not display correctly.

For example, 

------- Comment #1 From Grant McDorman 2006-12-10 11:44:39 0000 -------
When transferring tracks to a media device [MP3 player] with non-ASCII
characters - i.e. characters outside of the 0-FF standard ASCII range - Amarok
will either create incorrect strings or fail to transfer the affected file.

Similarly, in the list of device tracks, strings containing these characters do
not display correctly.

For example, ç (c-cedilla) will display as ç (tilde-capital A, section).
Tracks with 'é' in the resulting media device filename will not transfer at
all.

Inspecting the source, it looks like 'mtpmediadevice.cpp' is converting strings
to UTF8 where Latin1, presumably, should be used. It is not immediately clear
from the source where the reverse conversion would apply.

The libmtp documentation does not specify which charset should be used, but it
does appear that Latin1, not UTF8, should be used.

The media device being used is a Creative Zen MicroPhoto.

This applies to amarok 1.4.4 R2 ebuild.

------- Comment #2 From Diego E. 'Flameeyes' Pettenò 2006-12-10 11:57:56 0000 -------
Please report upstream.

------- Comment #3 From Grant McDorman 2006-12-10 12:25:07 0000 -------
FYI, I poked around in bugs.kde.org; this is apparently fixed in the amarok SVN
repository (see, e.g, http://bugs.kde.org/show_bug.cgi?id=129801).

I've generated a patch based on that and am trying it out now. If it works, I
will not submit a bug to KDE (and will attach a patch here).

------- Comment #4 From Grant McDorman 2006-12-10 12:42:46 0000 -------
Created an attachment (id=103756) [edit]
Backport of Amarok SVN fixes for MTP charset problems

Confirmed: the current Amarok SVN does not have the issue, as per
http://bugs.kde.org/show_bug.cgi?id=129801. The attached patch is a backport of
the current SVN stream to 1.4.4.

------- Comment #5 From Diego E. 'Flameeyes' Pettenò 2006-12-10 13:46:12 0000 -------
Please just give me the SVN revision or attach the patch in unified format
(diff -u).

------- Comment #6 From Grant McDorman 2006-12-10 16:52:40 0000 -------
Created an attachment (id=103768) [edit]
Unified diff version of patch

Sorry, I was not aware that patches were required in unified format.

This is the full output of svn info on the file (unfortunately I'm not
conversant with svn, so I don't know if this is what you need). If it's any
help, I just checked out the svn tree today.

Path: mtpmediadevice.cpp
Name: mtpmediadevice.cpp
URL:
svn://anonsvn.kde.org/home/kde/trunk/extragear/multimedia/amarok/src/mediadevice/mtp/mtpmediadevice.cpp
Repository Root: svn://anonsvn.kde.org/home/kde
Repository UUID: 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
Revision: 612302
Node Kind: file
Schedule: normal
Last Changed Author: kelk
Last Changed Rev: 611972
Last Changed Date: 2006-12-10 01:02:33 -0500 (Sun, 10 Dec 2006)
Text Last Updated: 2006-12-10 15:14:05 -0500 (Sun, 10 Dec 2006)
Properties Last Updated: 2006-12-10 15:14:05 -0500 (Sun, 10 Dec 2006)
Checksum: a2eab81e4e02b9ff89e691ab31fa627a

------- Comment #7 From Diego E. 'Flameeyes' Pettenò 2006-12-19 04:51:33 0000 -------
I was waiting for Luis to add libkarma to the tree to do just one bump adding
this and Rio Karma support, but I'll just apply this tonight now.

------- Comment #8 From Diego E. 'Flameeyes' Pettenò 2006-12-22 08:06:44 0000 -------
Fixed now in -r3.

First Last Prev Next    No search results available      Search page      Enter new bug