Bugzilla Bug 157707

This patch applies to 0.10.4 and not to 0.10.3 that is in the tree, so this
might need a bump.

Mail from Josh Coalson:
"
I sent this out a month back but accidentally with no subject
so I'm not sure if it got filtered out since there was no
response... anyway, attached are patches to gstreamer-plugins-good
to make the flac plugins work with both the upcoming FLAC 1.1.3
release and previous versions.  a beta of FLAC 1.1.3 is available
here:

http://prdownloads.sourceforge.net/flac/flac-1.1.3-beta2.tar.gz?download

changelog:

http://flac.cvs.sourceforge.net/*checkout*/flac/flac/doc/html/changelog.html

there are 2 patches, one for 0.10.4 and one for CVS HEAD as of
2006-oct-18 (also works for current HEAD since relevant files
are the same)

let me know if you have any questions or problems...

Josh
"

Maybe this would help if you want to carefully review the patch : 
http://flac.sourceforge.net/api/group__porting.html


The guideline I've followed to patch sound/video apps is : 
review and apply the patch
test with both flac 1.1.2 & flac 1.1.3
remove the ~ dep on flac 1.1.2


By doing so we'll be able to unmask flac 1.1.3 as soon as the deptree will be
correct.

Created an attachment (id=103734) [details]
Patch from Josh Coalson

I tried your patch, but somehow the plugin is not liked against libFLAC.so and
thus gstreamer fails to load it:

0:00:00.054136000  5149 0x50b830 WARN    GST_PLUGIN_LOADING
gstplugin.c:414:gst_plugin_load_file: module_open failed:
/usr/lib64/gstreamer-0.10/libgstflac.so: undefined symbol:
FLAC__StreamDecoderStateString

If I add LD_PRELOAD=/usr/lib/libFLAC.so to the commandline then everything
works fine.

Created an attachment (id=105683) [details]
Configure patch

You're right, configure checks had not been updated for flac 1.1.3 and then it
thought that flac will not be built. With the ebuild it builds it anyway but
lacks the linking to libflac that configure has just not set because it
couldn't detect flac.

Here is a patch to configure.ac that will make it check for the new and old
flac api.

even with your second patch it doesn't work:

configure: *** checking feature: FLAC lossless audio ***
configure: *** for plug-ins: flac ***
checking for FLAC__seekable_stream_encoder_new in -lFLAC... no
configure: *** These plugins will not be built: flac

it compiles, but I still have to use LD_PRELOAD. And I couldn't get configure
to recognize the new flac (/usr/include/FLAC/export.h:#define
FLAC_API_VERSION_CURRENT 8)

> it compiles, but I still have to use LD_PRELOAD. And I couldn't get configure
> to recognize the new flac (/usr/include/FLAC/export.h:#define
> FLAC_API_VERSION_CURRENT 8)
> 

You probably forgot to call eautoconf / eautoreconf

(In reply to comment #5)
> You probably forgot to call eautoconf / eautoreconf
> 

Thanks, inherit autotools and calling eautoconf in src_compile() did the trick.
Any news when this will this be merged into the official portage tree? Or do yo
just wait for upstream to fix it in the next release?

Adding this in gentoo's portage tree doesn't depend on me, that's up to
gstreamer herd.
According to http://bugzilla.gnome.org/show_bug.cgi?id=385887, this will be
included in future releases, but I don't know which one nor when.

I'm not pushing this migration because there are still some apps I'm supposed
to fix. I opened those bugs to help maintainers / users to migrate, adding this
to portage would help making the transition smooth but it's not a high priority
problem.

@gstreamer/gnome : ping, you're one of the last ones remaining for this
migration, mind if I port & apply the patch to the latest release in the tree ?

/me dons gnome hat

Both patches look fine to me. I see your last message on gnome's bugzy dates
back from January, don't let them forget this patch if they haven't committed
it yet

@gstreamer, package is still yours though, your call. :)

Hmmm, ping?

patch ported, merged in a single one, tested against flac 1.1.2 & 1.1.4 and
commited.