Bugzilla Bug 157588

Mail from Josh Coalson :
"
> (cc'ing other package maintainers)
> hi Allan, attached is a patch to akode-2.0.1 to make the code
> work with both the upcoming FLAC 1.1.3 release and previous
> versions.  a beta of FLAC 1.1.3 is available here:
>
http://prdownloads.sourceforge.net/flac/flac-1.1.3-beta2.tar.gz?download
> 
> changelog:
>
http://flac.cvs.sourceforge.net/*checkout*/flac/flac/doc/html/changelog.html
> 
> the main change is the merging of libOggFLAC into libFLAC.
> the LEGACY_FLAC stuff can be removed once FLAC-1.1.3 has propagated
> everywhere.  I know it's ugly, the main purpose of the patch is for
> package maintainers to be able to move to FLAC-1.1.3 with as little
> pain as possible.  for trunk code you can remove the LEGACY_FLAC
> stuff completely; after that you'll notice that native FLAC and
> Ogg FLAC can be handled with the same code except for the call to
> init().
> 
> let me know if you have any questions or problems...
> 
> Josh
> 
"


Maybe this would help if you want to carefully review the patch : 
http://flac.sourceforge.net/api/group__porting.html


The guideline I've followed to patch sound/video apps is : 
review and apply the patch
test with both flac 1.1.2 & flac 1.1.3
remove the ~ dep on flac 1.1.2


By doing so we'll be able to unmask flac 1.1.3 as soon as the deptree will be
correct.

Created an attachment (id=103672) [edit]
Patch from Josh Coalson

You'll have such warnings : 

>
> You do not seem to have libOggFLAC installed.
> Without it aKode and aRts will not be
> able to play Ogg-files with embedded FLAC streams
> You need atleast libOggFLAC 1.1.1 or newer.
>

That's normal since it has been merged to libFLAC

Created an attachment (id=103673) [edit]
Second Patch from Josh Coalson

Quoting Josh: 
"
here is one more tiny patch to apply on top of the previous one,
which will prevent a possible problem with Ogg FLAC decoding at
end of stream.

Josh
"

revbumped in ~arch for this.

That's good I did that myself as those patches were not enough for oggflac.