Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 157582 - games-engines/scummvm-0.9.1 flac 1.1.3 compatibility patch
Summary: games-engines/scummvm-0.9.1 flac 1.1.3 compatibility patch
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 152007
  Show dependency tree
 
Reported: 2006-12-09 01:54 UTC by Alexis Ballier
Modified: 2006-12-12 14:41 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch from Josh Coalson (scummvm-0.9.0+flac-1.1.3.patch,19.29 KB, patch)
2006-12-09 01:57 UTC, Alexis Ballier
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexis Ballier gentoo-dev 2006-12-09 01:54:46 UTC
Mail from Josh Coalson : 
"
hi devs, attached are patches to scummvm-0.9.0 to make the code
work with both the upcoming FLAC 1.1.3 release and previous
versions.  a beta of FLAC 1.1.3 is available here:
http://prdownloads.sourceforge.net/flac/flac-1.1.3-beta2.tar.gz?download

changelog:
http://flac.cvs.sourceforge.net/*checkout*/flac/flac/doc/html/changelog.html

the LEGACY_FLAC stuff can be removed once FLAC-1.1.3 has propagated
everywhere.

the patch also should work against svn HEAD as all the files
affected are the same.

let me know if you have any questions or problems...

Josh
"

Maybe this would help if you want to carefully review the patch : 
http://flac.sourceforge.net/api/group__porting.html


The guideline I've followed to patch sound/video apps is : 
review and apply the patch
test with both flac 1.1.2 & flac 1.1.3
remove the ~ dep on flac 1.1.2


By doing so we'll be able to unmask flac 1.1.3 as soon as the deptree will be correct.
Comment 1 Alexis Ballier gentoo-dev 2006-12-09 01:57:29 UTC
Created attachment 103667 [details, diff]
Patch from Josh Coalson

It's named 0.9.0 as it was done when 0.9.1 was not out, but it applies as well to 0.9.1.
Comment 2 Chris Gianelloni (RETIRED) gentoo-dev 2006-12-12 14:41:09 UTC
Fixed in CVS... thanks for the patch...