Bugzilla Bug 156765

New version of JDBC connector for MySQL is available.

As MySQL recommends this for use with 4.1 and forward, and the current stable
version of MySQL in the tree is 5.0.26 - switching over to the jdbc 5-series
maybe isn't a bad thing?

5.x series seems to have same build deps as 3.1x, so a bump should be rather
straightforward.  

I concur :). It would be great if we had a current jdbc-mysql connector.

Unfortunately not a straight forward bump, seems to have a dependency on some
jboss stuff.

compile-testsuite:
    [javac] Compiling 38 source files to
/usr/portage/tmp/portage/dev-java/jdbc-mysql-5.0.5/work/mysql-connector-java-5.0.5/build/mysql-connector-java-5.0.5
    [javac]
/usr/portage/tmp/portage/dev-java/jdbc-mysql-5.0.5/work/mysql-connector-java-5.0.5/build/mysql-connector-java-5.0.5/com/mysql/jdbc/integration/jboss/MysqlValidConnectionChecker.java:31:
package org.jboss.resource.adapter.jdbc does not exist
    [javac] import org.jboss.resource.adapter.jdbc.ValidConnectionChecker;

So looks like some jboss components will need to be packaged and available
first.

Could also look into how JBoss is being used. If it is definately optional, we
could remove it from our package. Having a modular JBoss is still aways a way,
and depending on the entirety of JBoss is pretty unreasonable for a JDBC
driver.

JBoss is definitely optional. This test case just checks the mysql-jdbc
integration bug found a while ago. 
Snip from test case:

         * Tests fix for BUG#20242 - MysqlValidConnectionChecker for JBoss
doesn't
         * work with MySQLXADataSources.
         *
         * @throws Exception if the test fails.
         */
        public void testBug20242() throws Exception {
                if (versionMeetsMinimum(5, 0)) {
                        try {
                               
Class.forName("org.jboss.resource.adapter.jdbc.ValidConnectionChecker");
                        } catch (Exception ex) {
                                return; // class not available for testing
                        }

                ...

                }
        }

Is there anything i can do to help? How would we attack the jboss test
dependency - is a fail ok, or should we patch away that test?

(In reply to comment #6)
> Is there anything i can do to help? How would we attack the jboss test
> dependency - is a fail ok, or should we patch away that test?
> 

Coming up with a patch to remove it would help, yes.

Created an attachment (id=116048) [details]
removes jboss regression tests

OK, here's a stab at that patch. Didn't know what scope you want it in, let me
know if i should create another one. The test suite now works without jboss
(but failed for me in some other places - probably weird setup). If it should
hassle for you - I'm sorry; kinda new to all of this.

Ouch, probably should mention it's for 5.0.5 - not 5.0.4 (I thought the
filename would show in bugzilla)

Sorry for making this look like pointless bumping - but i'd really want to see
this in the tree; is there anything else i can do? (last post, promise)

(In reply to comment #10)
> Sorry for making this look like pointless bumping - but i'd really want to see
> this in the tree; is there anything else i can do? (last post, promise)
> 

Don't worry about making noise when it's not pointless.

Committed. Thanks for reporting and waiting.