Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 156611 - initramfs creation cleanup
Summary: initramfs creation cleanup
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Hosted Projects
Classification: Unclassified
Component: genkernel (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo Genkernel Maintainers
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks:
 
Reported: 2006-11-29 07:20 UTC by Daniel Drake (RETIRED)
Modified: 2007-01-04 09:21 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
patch (cpio.patch,26.20 KB, patch)
2006-11-29 07:20 UTC, Daniel Drake (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Drake (RETIRED) gentoo-dev 2006-11-29 07:20:18 UTC
The primary purpose of this patch is to avoid creating many small cpio archives and concatenating them, and instead just creating a single one and appending data to it incrementally.

These smaller archives were being rebuilt every time and there isn't really any need to turn them into caches (the compiled bits are already cached).

Concatenating multiple archives is an abuse of the format and it is unlikely that the kernel understands concatenated archives by design, more likely they just didn't implement every fine detail of the spec.

Additionally, cpio "breaks" (well, actually does what the spec says) when handling these archives meaning that they cant be easily extracted in entirety.

Compression should be better now, as compressing one big archive rather than compressing many smaller ones (then concatenating them later) should give better results.

There should be no other functional/behavior changes introduced by this patch.

I also cleaned up the code here:
cpio cache is no longer used.
functions like create_lvms_cpio were only being called conditionally based on ${LVMS2}, but the functions themselves were checking this variable as well.

This patch should be applied after the one in bug #156445
Comment 1 Daniel Drake (RETIRED) gentoo-dev 2006-11-29 07:20:51 UTC
Created attachment 102985 [details, diff]
patch
Comment 2 Chris Gianelloni (RETIRED) gentoo-dev 2006-12-13 09:31:27 UTC
OK.  I've added this to SVN... I'm hoping you tested this a good bit... ;]
Comment 3 Chris Gianelloni (RETIRED) gentoo-dev 2007-01-04 09:21:37 UTC
Fixed in 3.4.6