Bugzilla Bug 155526

If I call apg with the -y option (print crypted passwords), apg terminates with
a segfault.

I attach a output of 'strace apg -y'.

BR,
Dustin

Created an attachment (id=102236) [edit]
strace output

Created an attachment (id=102237) [edit]
And 'emerge --info'

i'm unable to reproduce this crash.

could you please re-emerge apg with FEATURES="nostrip" and CFLAGS="-O0 -g" and
post gdb's backtrace here?

gdb --args apg -y
bt

Hi Konstantin,

Happy new year. After the holidays I've got time now to look into this. I
reemerged apg like you asked me. However, I am not familiar with gdb at all.
Invoking it like you asked me I just see the prompt like

dustin@solaris ~ $ gdb --args apg -y
GNU gdb 6.4
Copyright 2005 Free Software Foundation, Inc.
GDB is free software, covered by the GNU General Public License, and you are
welcome to change it and/or distribute copies of it under certain conditions.
Type "show copying" to see the conditions.
There is absolutely no warranty for GDB.  Type "show warranty" for details.
This GDB was configured as "i686-pc-linux-gnu"...Using host libthread_db
library "/lib/libthread_db.so.1".

(gdb) 

Could you give me a hint how to produce some useful output?

Thanks.
Dustin

Okay. found some time to look how gdb works. Is the following output sufficient
 or do you need more? Then please tell me what to do.

dustin@solaris ~ $ gdb --args apg -y
GNU gdb 6.4
Copyright 2005 Free Software Foundation, Inc.
GDB is free software, covered by the GNU General Public License, and you are
welcome to change it and/or distribute copies of it under certain conditions.
Type "show copying" to see the conditions.
There is absolutely no warranty for GDB.  Type "show warranty" for details.
This GDB was configured as "i686-pc-linux-gnu"...Using host libthread_db
library "/lib/libthread_db.so.1".

(gdb) run
Starting program: /usr/bin/apg -y
Failed to read a valid object file image from memory.

Program received signal SIGSEGV, Segmentation fault.
0xb7e5f825 in memcpy () from /lib/libc.so.6

type in shell: gdb --args apg -y
type in gdb: bt

I think this does not help much...

solaris / # gdb --args apg -y
GNU gdb 6.6
Copyright (C) 2006 Free Software Foundation, Inc.
GDB is free software, covered by the GNU General Public License, and you are
welcome to change it and/or distribute copies of it under certain conditions.
Type "show copying" to see the conditions.
There is absolutely no warranty for GDB.  Type "show warranty" for details.
This GDB was configured as "i686-pc-linux-gnu"...
Using host libthread_db library "/lib/libthread_db.so.1".
(gdb) bt
No stack.
(gdb) 

ups.

type in shell: gdb --args apg -y
type in gdb: run
type in gdb: bt

also you can try to add '#include <crack.h>' in restrict.c:~35 and rebuild apg.

Ah, that's better! Here's the output:

GNU gdb 6.6
Copyright (C) 2006 Free Software Foundation, Inc.
GDB is free software, covered by the GNU General Public License, and you are
welcome to change it and/or distribute copies of it under certain conditions.
Type "show copying" to see the conditions.
There is absolutely no warranty for GDB.  Type "show warranty" for details.
This GDB was configured as "i686-pc-linux-gnu"...
Using host libthread_db library "/lib/libthread_db.so.1".
(gdb) run
Starting program: /usr/bin/apg -y
Failed to read a valid object file image from memory.

Program received signal SIGSEGV, Segmentation fault.
0xb7dbc3d5 in memcpy () from /lib/libc.so.6
(gdb) bt
#0  0xb7dbc3d5 in memcpy () from /lib/libc.so.6
#1  0x0805023d in main ()

I added crack.h to restrict.c as well like you suggested but to no avail:

GNU gdb 6.6
Copyright (C) 2006 Free Software Foundation, Inc.
GDB is free software, covered by the GNU General Public License, and you are
welcome to change it and/or distribute copies of it under certain conditions.
Type "show copying" to see the conditions.
There is absolutely no warranty for GDB.  Type "show warranty" for details.
This GDB was configured as "i686-pc-linux-gnu"...
Using host libthread_db library "/lib/libthread_db.so.1".
(gdb) run
Starting program: /usr/bin/apg -y
Failed to read a valid object file image from memory.

Program received signal SIGSEGV, Segmentation fault.
0xb7e603d5 in memcpy () from /lib/libc.so.6
(gdb) bt
#0  0xb7e603d5 in memcpy () from /lib/libc.so.6
#1  0x0805023d in main ()

since i'm still unable to reproduce it, can you please try the following patch:

http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=337116;msg=24

?

Bingo!
That patch did the trick. Thanks a lot fo your help!

Including <crack.h> is needed as well, otherwise compilation gives warnings
about implicit function declaration.

I leave the bug still open until a revised ebuild has been commited to portage.

Dustin

-r3 committed.
thank you for reporting and testing, Dustin.

Could you add a patch to restrict.c as suggested in comment #8?
This will fix the QA warning due to an implicit function declaration.

Thanks.

committed -r4,
thanks.